Commit Graph
4973 Commits
Author SHA1 Message Date
Huy Nguyen 7533118945 Fix unnecessary relayout if table view width is zero initially
- During initial configuration of a table view with a zero size, for each cell, there is a mismatch between the widths of its content view and constrained size. However, don't relayout the cell immediately because an initial data loading will be performed shortly afterward.
2015-10-25 18:54:11 +02:00
Huy Nguyen 52a259a487 Better names in ASTableView. 2015-10-25 18:30:51 +02:00
Adlai Holler ddf867b106 Use NO rather than nil to fix build on Xcode 7.1 2015-10-24 10:58:25 -07:00
Adlai Holler 99113388a8 Make tests use CALayer.asyncdisplaykit_node.name rather than CALayer.asyncdisplaykit_name as needed 2015-10-24 10:58:09 -07:00
Adlai Holler 0d53a82985 Remove dead flag 2015-10-24 01:20:42 -07:00
Adlai Holler 9b2a68781c Use ASObjectIsEqual to make ASDisplayNode.setName faster when setting the same name repeatedly 2015-10-24 01:18:24 -07:00
Adlai Holler 55e22d2e57 Clean up more remnants of Old Ways 2015-10-24 01:09:31 -07:00
Adlai Holler 3bd54a3c5c Don't hold lock while copying ASDisplayNode.name 2015-10-24 01:03:56 -07:00
Adlai Holler 86c6a4648d Update UIViewBridge documentation to state that bridged properties must be accessed from the main thread once the view or layer is loaded 2015-10-24 00:57:24 -07:00
Adlai Holler 5a8e7daace Implement ASDisplayNode.name separate from CALayer 2015-10-24 00:56:00 -07:00
Levi McCallum e0dfe8f0c4 Fix method naming 2015-10-23 06:10:06 -07:00
Levi McCallum 722b90f1cf Implement basic immediate reloadData method on table and collection view 2015-10-22 21:28:44 -07:00
Levi McCallum c33d6efa8a WIP synchronous reload data on collection view 2015-10-22 21:28:30 -07:00
Levi McCallum 6569893c23 Reset inspector selector implementation cache correctly 2015-10-22 18:54:07 -07:00
Levi McCallum d9ea1b52ea Fix unit tests 2015-10-22 15:27:48 -07:00
Levi McCallum e9708633bc Remove stubbed collection view layout setter behavior 2015-10-21 23:17:38 -07:00
Levi McCallum e8ce7fcbb2 Clean up caching of collection view delegate selectors on the inspector 2015-10-21 23:17:38 -07:00
Levi McCallum 084d60883b Add assertion to flow layout inspector down casting 2015-10-21 23:17:38 -07:00
Levi McCallum db0a0326d7 Rename layoutDelegate to layoutInspector in ASCollectionView 2015-10-21 23:17:38 -07:00
Levi McCallum 45ff74b604 Remove array fallback on editing node index paths 2015-10-21 23:17:38 -07:00
Levi McCallum 5736e7c2d2 Clarify editing transaction documentation 2015-10-21 23:17:37 -07:00
Levi McCallum 5645724984 Use pointer comparison helpers for string equality 2015-10-21 23:17:37 -07:00
Levi McCallum ad82c72eb4 Cache flow layout delegate in local variable 2015-10-21 23:17:37 -07:00
Levi McCallum 413307a973 Assert flow layout inspector always initializes with a flow layout 2015-10-21 23:17:37 -07:00
Levi McCallum 5ca14486b6 Make array instantiation consistent 2015-10-21 23:17:37 -07:00
Levi McCallum 9697edac33 Fix conditional block style 2015-10-21 23:17:37 -07:00
Levi McCallum 11076b115e Used cached layout value in node remeasurement 2015-10-21 23:17:37 -07:00
Levi McCallum 8f289d9977 Back internal kind collection with a set 2015-10-21 23:17:37 -07:00
appleguy a88ad0a848 Merge pull request #752 from nguyenhuy/StaticLayousSpecTests
Add snapshot tests for ASStaticLayoutSpec
2015-10-21 18:09:00 -07:00
appleguy c96813c51c Merge pull request #760 from levi/patch-4
Call UIViewController's designated initializer in ASViewController
2015-10-20 19:31:45 -07:00
Levi McCallum 0972c56f73 Call UIViewController's designated initializer in ASViewController
ASViewController currently cannot be subclassed in Swift, as the original call to `[super init]` directs to calling the designated initializer of UIViewController `[self initWithNibName:bundle:]`. Because of Swift's initializer inheritance behavior, this designated initializer will not implicitly be available on the subclassed ASViewController without some extra boilerplate. Adding an explicit call to the designated initializer fixes this issue.
2015-10-20 16:37:39 -07:00
Huy Nguyen 938cd468b3 Add snapshot tests for ASStaticLayoutSpec. 2015-10-19 20:37:20 +03:00
rcancro 050160e6bb fixed the build again (removed all generic collections) 2015-10-19 10:04:49 -07:00
rcancro 5a3b021510 fixed build 2015-10-19 08:57:17 -07:00
rcancro f164b97700 Put all ascii box methods into a Debugging category. 2015-10-19 08:32:14 -07:00
appleguy a1dee22a09 Merge pull request #694 from levi/supplementary-views
Add support for supplementary views in ASCollectionView.  Introduce collection-specific data controller.
2015-10-18 20:23:48 -07:00
rcancro 3b983c5a50 Ascii art for layoutables 2015-10-16 16:15:29 -07:00
Levi McCallum 8b7ac3c37d Ensure layout controller exposes only cell item index paths to range controller 2015-10-15 11:40:53 -07:00
Levi McCallum 55c1b8f6e7 Fix variable naming in debug log 2015-10-15 11:40:53 -07:00
Levi McCallum 31f184b32d Clear collection view delegate/dataSource on test tear down 2015-10-15 11:40:53 -07:00
Levi McCallum 9a37538582 Clean up and test registration of internal supplementary node kinds 2015-10-15 11:40:53 -07:00
Levi McCallum 12194199cd Clean up layout delegate protocol API 2015-10-15 11:40:53 -07:00
Levi McCallum 772e9b95a4 Document layout delegate on ASCollectionView 2015-10-15 11:40:53 -07:00
Levi McCallum 0446902c17 Remove supplementary view assertion 2015-10-15 11:40:53 -07:00
Levi McCallum e2bbde2a4e Clean up usage of internal flow layout inspector 2015-10-15 11:40:53 -07:00
Levi McCallum 8ac02a6eaf Document public supplementary node methods 2015-10-15 11:40:53 -07:00
Levi McCallum ee0cc2001a Add support for loaded node layout for supplementary views 2015-10-15 11:40:52 -07:00
Levi McCallum 952a66a924 Remove initial data loading subclass hook 2015-10-15 11:40:52 -07:00
Levi McCallum 1c717c74b8 Homogenize cell node measuring 2015-10-15 11:40:52 -07:00
Levi McCallum c8a79c5cfb Ignore coverage analysis files in master 2015-10-15 11:40:52 -07:00