Commit Graph
4958 Commits
Author SHA1 Message Date
appleguy fe868b14f4 Merge pull request #1418 from levi/patch-10
[ASPagerNode] Nil out currentIndexPath after usage to prevent ASPagerFlowLayout crashes
2016-03-23 18:35:05 -07:00
Levi McCallum f760c8460a Nil out currentIndexPath after usage to prevent ASPagerFlowLayout crashes 2016-03-23 17:55:25 -07:00
appleguy 505d4ffb5d Merge pull request #1416 from maicki/ASRunLoopQueueAddWakeUpCall
[ASRunLoopQueue] Add CFRunLoopWakeUp in processQueue
2016-03-22 20:30:38 -07:00
Hannah Troisi aa9f21063f Merge remote-tracking branch 'facebook/master' 2016-03-22 20:24:40 -07:00
Michael Schneider 4207e0e1a6 Add CFRunLoopWakeUp in processQueue 2016-03-22 20:19:17 -07:00
Scott Goodson e59431e702 [ASDisplayNode] Restore dispatch_async for clearContents, to prevent discarding contents for nodes that are simply moving to a new container. 2016-03-22 18:39:23 -07:00
Scott Goodson 5b9302b681 Revert "Prevent deallocation of asyncDataSource and asyncDelegate in ASCollectionView and ASTableView"
This reverts commit 3668f45286.
2016-03-22 14:38:50 -07:00
Scott Goodson 953c0f51f0 Revert "Move call of range update completion blocks to consider early returns in _updateVisibleNodeIndexPaths"
This reverts commit 41362fca39.
2016-03-22 14:37:49 -07:00
appleguy 2319197a59 Merge pull request #1415 from facebook/DeallocInterfaceState
[ASInterfaceState] Clear the "Visible" bit immediately upon deallocation, rather than waiting for ASRangeController on the next runloop.
2016-03-22 14:37:29 -07:00
Scott Goodson 76b38cbe6e [ASInterfaceState] Clear the "Visible" bit immediately upon deallocation, rather than waiting for ASRangeController on the next runloop. 2016-03-22 14:32:32 -07:00
appleguy 1f3cedb4b6 Merge pull request #1414 from maicki/LastRangeUpdateBeforeClosing
[ASRangeController] Move call of range update completion blocks to consider early returns in _updateVisibleNodeIndexPaths
2016-03-22 13:17:42 -07:00
Michael Schneider 41362fca39 Move call of range update completion blocks to consider early returns in _updateVisibleNodeIndexPaths 2016-03-22 12:43:09 -07:00
appleguy e4f14c34f3 Merge pull request #1412 from maicki/LastRangeUpdateBeforeClosing
[ASRangeController] Prevent deallocation of dataSource & delegate in Collection & Table when navigating back, during final range update.
2016-03-22 12:15:07 -07:00
Michael Schneider 3668f45286 Prevent deallocation of asyncDataSource and asyncDelegate in ASCollectionView and ASTableView
Grab a strong reference for asyncDataSource and asyncDelegate in ASCollectionView and ASTableView before executing the range update to be sure they are not going away while executing the range update. This can happen in range updates while going back in the view controller hierarchy
2016-03-22 08:09:59 -07:00
Hannah Troisi 3d781d53d4 Merge remote-tracking branch 'facebook/master' 2016-03-21 18:18:37 -07:00
appleguy fbe87cde4b Merge pull request #1410 from maicki/ASRunLoopQueueImproveProcessTriggering
[ASRunLoopQueue] Always signal runloop source if queue is not fully drained, to ensure more batches are guaranteed to run.
2016-03-21 17:12:39 -07:00
Michael Schneider a937184a0b Remove CFRunLoopWakeUp in CFRunLoop observer callback
We don't nee CFRunLoopWakeUp as at this time are currently running in an observer callback, and after running all of the BeforeWaiting observers it must surely check for more sources / etc to run before determining if it will sleep
2016-03-21 17:10:29 -07:00
Michael Schneider b3e98e9f5f If the queue is not fully drained yet force another run loop to process next batch of items 2016-03-21 16:58:39 -07:00
Eric Jensen 12da9ac6a9 Improve Swift compatibility of ASHorizontalAlignment & ASVerticalAlignment by using consistent naming 2016-03-21 11:16:28 -07:00
Eric Jensen b733936133 Improve Swift compatibility of ASCellNodeVisibilityEvent by using NS_ENUM macro 2016-03-21 11:10:28 -07:00
appleguy bae2f232f0 Merge pull request #1407 from nguyenhuy/cancel_layout_transitions
[ASDisplayNode] [Async layout transition] Add method to cancel layout transitions in progress
2016-03-20 23:24:18 -07:00
Huy Nguyen 9e76d7b603 Add method to cancel layout transitions in progress
- Also make sure a transition isn't invalidated right after it passed the validation test and before it proceeds
2016-03-20 23:17:35 -07:00
appleguy 1a57e2c097 Merge pull request #1406 from rahul-malik/rmalik-button-a11y
[Accessibility] Basic a11y support for ASButtonNode (adopt text node title as a11y label)
2016-03-20 19:24:55 -07:00
Rahul Malik 4eb3356615 Basic a11y support for ASButtonNode 2016-03-20 19:22:53 -07:00
appleguy a9eaa9cc82 Merge pull request #1405 from facebook/RelativeSpec
[ASRelativeLayoutSpec] New Layout Spec for 9-part rectangular positioning (corners, edges, center).
2016-03-20 01:05:12 -07:00
Sam Stow 086bd8a52b [ASRelativeLayoutSpec] New core layout spec type: Relative Position, now powers Center as well.
This spec allows positioning a child at any 9-part box position (corners, edges, or center).
2016-03-19 22:37:02 -07:00
appleguy 4297cb1eb5 Merge pull request #1398 from facebook/Placeholders
[ASDisplayNode] Placeholders should always be recreated if returning to cleared nodes, and remain until ASNetwork/MultiplexImageNode finish loading their image from the network.
2016-03-19 21:19:05 -07:00
appleguy 36437f2fb7 Merge pull request #1399 from facebook/MKCancel
[ASMapNode] Reduce number of MapKit calls to -cancel by using the .isLoading property.
2016-03-19 21:16:30 -07:00
appleguy 636b7d937f Merge pull request #1404 from facebook/pragma
[AsyncDisplayKit] Adopt #pragma once, remove last remaining dispatch_sync (UIScreen scale).
2016-03-19 21:15:44 -07:00
appleguy ebd3567f1b Merge pull request #1262 from ekurutepe/carthage-example
[Carthage] Build Test project to ensure framework is never left behind by file additions.
2016-03-19 21:14:46 -07:00
Scott Goodson 8308a4ce49 [AsyncDisplayKit] Adopt #pragma once, remove last remaining dispatch_sync (UIScreen scale). 2016-03-19 19:56:41 -07:00
appleguy 5feedb002f Merge pull request #1403 from hannahmbanana/fixCustomCollectionExampleApp
[CustomCollectionView Example] Fix shouldInvalidateLayoutForBoundsChange: method
2016-03-19 19:08:11 -07:00
appleguy 178301200b Merge pull request #1402 from hannahmbanana/master
[ASVideoNode] Add to AsyncDisplayKit.h
2016-03-19 19:05:42 -07:00
Hannah Troisi 2dae2d1c09 [CustomCollectionView Example]
Issue (#1366):
CustomColelctionView example app always returns YES from shouldInvalidateLayoutForBoundsChange: which triggers a re-layout.

Fix:
Comparing CGSize rather than CGRect is enough to  handle rotation support without always triggering a re-layout. .
2016-03-19 18:14:19 -07:00
Hannah Troisi d99a13f1a7 Revert "[CustomCollectionView Example]"
This reverts commit fcccb1bf03.
2016-03-19 18:10:08 -07:00
Hannah Troisi fcccb1bf03 [CustomCollectionView Example]
Issue (#1366):
CustomColelctionView example app always returns YES from shouldInvalidateLayoutForBoundsChange: which triggers a re-layout.

Fix:
Comparing CGSize rather than CGRect is enough to  handle rotation support without always triggering a re-layout. .
2016-03-19 18:00:24 -07:00
Hannah Troisi f9a92366d3 [AsyncDisplayKit] Fix build so we can weak link AVFoundation
Unclear why the framework target required these seemingly unrelated changes to Collection
classes, but I modeled them after related files and it seems cleaner now (passes tests & framework target)
2016-03-19 17:54:02 -07:00
Hannah Troisi b98920c19f [ASVideoNode] Add to ASDK umbrella header 2016-03-19 17:10:47 -07:00
Hannah Troisi 5716cbf18c Merge remote-tracking branch 'facebook/master' 2016-03-18 23:48:17 -07:00
Scott Goodson 7bb48d266c [ASMapNode] Reduce number of MapKit calls to -cancel by using the .isLoading property. 2016-03-18 23:31:33 -07:00
Scott Goodson c5c7abb1d6 [ASDisplayNode] Placeholders should always be recreated if returning to past nodes.
If previously-displayed contents is gone (e.g. clearContents), and is not finished displaying
by the time the node is onscreen, recreate the placeholder immediately.
2016-03-18 21:13:26 -07:00
appleguy 0745eabec9 Merge pull request #1397 from maicki/ASRunLoopQueueContinueProcessing
[ASRunLoopQueue] Add custom run loop source to signal if jobs are still enqueued, to guarantee another runloop turn.
2016-03-18 14:48:50 -07:00
Michael Schneider 14b9df30a3 Create CFRunLoopSourceContext via calloc 2016-03-18 14:32:45 -07:00
Michael Schneider d1756baae7 Add custom run loop source to signal if new jobs are enqueued in ASRunLoopQueue
It is not guaranteed that the runloop will turn if it has no scheduled work, and this causes processing of the queue to stop. Attaching a custom loop source to the run loop and signal it if new work needs to be done
2016-03-18 14:02:27 -07:00
appleguy c8cbd2ec4a Merge pull request #1393 from ejensen/cleanup
[Refactoring] Redundant function removal; Ternary formatting
2016-03-17 13:47:02 -07:00
Engin Kurutepe 2a978054f2 remove Cartfile.resolved 2016-03-17 20:27:03 +01:00
Eric Jensen 6739a3a4ab Condition logic simplification 2016-03-17 11:22:53 -07:00
Eric Jensen 17aebcbaba Add a space between the ? and : in ternarys 2016-03-17 10:38:51 -07:00
Eric Jensen 14a389c5e0 Replace ASTextKitAttributes' objectsEqual with the shared ASObjectIsEqual 2016-03-17 10:36:35 -07:00
Engin Kurutepe ad09d83f19 make the sample scheme shared 2016-03-17 15:22:00 +01:00