GitHub/Texture
1
0
Fork 0
mirror of https://github.com/TextureGroup/Texture.git synced 2026-04-07 19:17:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
4,958 Commits 371 Branches 222 Tags
MSASTextNode2SupportTruncationTokenAttributesMerging
Commit Graph
4958 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Hannah Troisi ceff3e8987 Jenkins build test 3 
added another space
 2016-06-27 17:14:24 -07:00
Hannah Troisi c10497ed99 Jenkins build test 2 
Added a space to trigger a Jenkins build.
 2016-06-27 17:07:53 -07:00
Hannah Troisi e0fc55e25f Jenkins build test 
Adding a space to test jenkins build hooks.
 2016-06-27 16:57:08 -07:00
Hannah Troisi 20edc81f55 Update build.sh file 
Adding MODE = "examples" will allow Kosta to speed up internal ASDK build.
 2016-06-27 11:19:32 -07:00
Adlai Holler f7fa90aafd [Project] Publicize ASPINRemoteImageDownloader.h 2016-06-27 10:21:52 -07:00
Colin McArdell and Robin Chou 9c13018568 Updates exposed method signature and docs for what is now -supplementaryNodeForElementKind:atIndexPath: on ASCollectionView. Assert non-nil for usage of ASCollectionDataControllers -supplementaryNodeOfKind:atIndexPath: within ASCollectionView 2016-06-27 11:05:53 -04:00
Colin McArdell and Robin Chou 1c103333f7 ASCollectionView docs for -supplementaryNodeOfKind:atIndexPath: + nullability. Also, nullability for -nodeForItemAtIndexPath: 2016-06-27 11:05:45 -04:00
Colin McArdell and Robin Chou 488ded2fe8 ASCollectionDataControllers supplementaryNodeOfKind:atIndexPath: now returns nil instead of an assertion if the supplementary node of kind doesn't exist within completedNodesOfKind 2016-06-27 11:05:37 -04:00
Colin McArdell and Robin Chou d69dd880a5 Exposing supplementaryNodeOfKind:atIndexPath: in the ASCollectionView interface. 2016-06-27 11:05:11 -04:00
Michael Schneider 4091d70003 Add conformsToProtocol: to ASDelegateProxy 2016-06-27 06:38:42 -07:00
Gareth Reese d55621c285 [ASCollectionView] Tuning parameters not set 2016-06-27 14:07:00 +01:00
Hannah Troisi db04f4b851 [ASTableView] Add constrainedSizeForRowAtIndexPath: to control row heights from delegate (#1769) 
* [ASTableView] constrainedSizeForRowAtIndexPath

* Quick fix to header file

* Switch to Delegate from DataSource.

* Update testing variables to reflect switch to delegate
 2016-06-26 23:09:53 -07:00
Kiel Gillard cc74fb0cdc Prove the change gets the correct nodes with a pair of tests. 2016-06-27 12:53:33 +10:00
Kiel Gillard 56a5343496 Collect subnodes passing the test, not the node with the subnodes passing the test. 2016-06-27 11:29:28 +10:00
appleguy ae87717263 Revert "Remove old website folder from master branch" (#1818) 2016-06-26 17:12:59 -07:00
Hannah Troisi f71e207e0a Remove old website files from master branch (#1817) 
- new website files are in  gh-pages branch (and have been for awhile)
 2016-06-26 17:08:35 -07:00
Hannah Trosi 7ddef95946 fix compile errors 2016-06-25 01:05:23 -07:00
Hannah Trosi 2e4b1ea053 [ASCellNode] Fix selection / highlight implementation 2016-06-25 00:22:28 -07:00
Hannah Trosi 42a1227d69 Merge remote-tracking branch 'facebook/master' 2016-06-24 20:54:32 -07:00
Hannah Troisi e4abe898d5 [ASEditableTextNode] Support UITextInputTraits pass-through methods (threadsafe for use before view creation) (#1809) 
* [ASEditableTextNode] Support UITextInputTraits

* consistent property attributes

* remove logging, fix tests to account for UIKit weirdness

* address @appleguy's comments
 2016-06-24 16:53:10 -07:00
Michael Schneider 3fb0e18504 [ASTextNode] Further locking improvements for ASTextNode (#1813) 
* Further locking improvements for ASTextNode

* Remove tighter holding of lock as this operation needs to complete with the lock held
 2016-06-24 16:49:05 -07:00
Adlai Holler 0a354f8f4e [ASDataController] Remove implementation for unused hooks 2016-06-24 15:48:23 -07:00
Adlai Holler 211dcdf0e8 [_ASHierarchyChangeSet] Remove unused new method 2016-06-24 13:56:08 -07:00
Adlai Holler 0a525a3c16 [ASFlowLayoutController] Fix enumeration bug in ASFlowLayoutController 2016-06-24 13:52:16 -07:00
Adlai Holler 27dc52c0c5 [ASHierarchyChangeSet] Document reload-splitting behavior 2016-06-24 13:20:06 -07:00
Adlai Holler 304f8f6cb1 [ASHierarchyChangeSet] Clean up and add documentation 2016-06-24 13:17:00 -07:00
Adlai Holler 84e8b2686c [ASDataController] Combine isolated reloads into a batch 2016-06-24 13:03:51 -07:00
Adlai Holler 5d72f2f2cc Enable the thrash testing 2016-06-24 11:12:37 -07:00
Adlai Holler d8d2524b89 One more critical update integrity fix 2016-06-24 11:12:37 -07:00
Adlai Holler 681876bd59 Fix more issues with data integrity 2016-06-24 11:12:37 -07:00
Adlai Holler 9c70cec8d8 Improve update handling more 2016-06-24 11:12:37 -07:00
Adlai Holler 35056f708b [ASDataController] Improve update handling 2016-06-24 11:12:37 -07:00
Adlai Holler 71d9f64535 Carry over first-pass change set improvements 2016-06-24 11:12:37 -07:00
Adlai Holler 77f24231b3 [Documentation] Add a comment why we prefer -indexPathForItem:inSection: 2016-06-24 10:13:51 -07:00
Gareth Reese 9349abb737 Merge branch 'master' of https://github.com/facebook/AsyncDisplayKit into ASVideoNode-overwrittenplaceholder 2016-06-24 11:39:12 +01:00
Adlai Holler 457e08005f [ASDataController] Remove asyncDataFetching Option, Cleanup (#1794) 
* [ASDataController] Add some assertions to clarify what queues things happen on

* [ASCollectionDataController] Optimize willReloadData

* [ASDataController] Minor optimizations, no functional changes

* [ASDataController] Always reload data on _editingTransactionQueue

* [ASDataController] Remove async data fetching option, deprecate callbacks

* [ASDataController] Not mutable

* [ASMultidimensionalArrayUtils] Use fast enumeration

* Optimize ASMultidimensionalArrayUtils
 2016-06-23 21:08:44 -07:00
ricky 997d37dc83 [ASEnvironment] Don't relayout as a result of clearing a traitCollection's context (#1759) 
* Don't relayout as a result of clearing a traitCollection's context

I'm not completely sure this change is the best solution. Here is context:

An ASEnvironmentTraitCollection has a pointer to an optional context that an ASVC is the owner of. When the ASVC is dealloc'ed, we go through all subnodes of the VC and clear out the context so that the struct isn't holding on to a garbage pointer.

Setting the traitCollection on ASCollectionNode/ASTableNode causes the cells to relayout if the trait collection changed (this is  a special case for these two nodes since their cells are not actually subnodes). Setting the context to nil registered as a trait collection change and was causing a layout even as we were dealloc'ing the VC.

The logic I'm implementing here is:
If the trait collection changed AND the displayContext did not, then we should relayout.
If the trait collection changed AND the new displayContext is non-nil then we should layout
In the case where the trait collection change was caused soley by the displayContext going from non-nil to nil, then we should NOT layout.

```
// At this point we know that the two traits collections are NOT equal for some reason
BOOL needsLayout = (oldTraits.displayContext == currentTraits.displayContext) || currentTraits.displayContext != nil;
```

Is there a better place/safer way to do this?

* removed extra setNeedsLayout call
 2016-06-23 20:07:45 -07:00
Hannah Troisi d850057916 [Travis CI] move carthageBuildTest to examples_extra to avoid Travis error 2016-06-23 16:25:48 -07:00
Michael Schneider f0bfa24fa3 Merge pull request #1766 from hannahmbanana/collectionLayout 
[ASCollectionView, ASCellNode] Add support applyLayoutAttributes: on ASCellNode
 2016-06-23 15:09:10 -07:00
Michael Schneider 2375e31033 Merge pull request #1721 from rcancro/layoutSpec 
[ASLayoutSpec] Remove use of dictionary to hold children
 2016-06-23 15:07:08 -07:00
Hannah Troisi 54e29d2236 [Carthage] fix travis build error (#1804) 
* [Carthage] Add cartfile, update example

* [Carthage] fix travis build issue

* [Carthage] fix cartfile for travis build error

* capitalization fix
 2016-06-22 23:22:42 -07:00
Adlai Holler 57310a6fe4 Merge pull request #1802 from facebook/AHThrashTesting 
[Unit Tests] Add Table View Data Thrash Testing
 2016-06-22 21:35:58 -07:00
Michael Schneider 4f61b6e1cc Merge pull request #1777 from maicki/StructsForDrawingParameter 
[ASTextNode / ASImageNode] Use structs for drawing parameter
 2016-06-22 20:48:58 -07:00
Michael Schneider 95b03472f2 Merge pull request #1785 from facebook/AHWillDisplayCellDeprecate 
[ASCollectionView/ASTableView] Warn Users About Index Paths in willDisplayNode:/didEndDisplayingNode: Methods
 2016-06-22 20:47:43 -07:00
Michael Schneider 7175afba59 Merge pull request #1790 from gazreese/ASVideoNode-delegate-superclass 
[ASVideoNode] Ensure that both ASVideoNode and ASNetworkImageNode delegate methods are called
 2016-06-22 20:43:49 -07:00
Adlai Holler 12336de325 [ASThrashTesting] Array is immutable 2016-06-22 17:25:09 -07:00
Adlai Holler 9fc3ec9096 [ASThrashTesting] Numbers so magic 2016-06-22 17:19:36 -07:00
Adlai Holler bd7f90f7ee [ASThrashTesting] Remove unneeded clang diagnostics 2016-06-22 17:14:01 -07:00
Adlai Holler 3ca95778df [ASThrashTesting] Some cleanup 2016-06-22 17:11:21 -07:00
Adlai Holler 383667f2c3 [ASThrashTesting] Rocking and rolling! 2016-06-22 17:02:46 -07:00