From 838ab85a995df21844cc4a7750fa976dc9f044e2 Mon Sep 17 00:00:00 2001
From: Michael Schneider <maicki@users.noreply.github.com>
Date: Thu, 4 Apr 2019 07:32:29 -0700
Subject: [PATCH] Use instance lock for ASPrimitiveTraitCollection (#1442)

* Use instance lock for ASPrimitiveTraitCollection

* Remove the atomic
---
 Source/ASDisplayNode+Layout.mm                   |  7 +++++--
 Source/Details/ASTraitCollection.h               | 10 ----------
 Source/Layout/ASLayoutSpec.mm                    | 12 +++++++++++-
 Source/Private/ASDisplayNodeInternal.h           |  2 +-
 Source/Private/_ASCollectionGalleryLayoutItem.mm | 10 ++++++----
 5 files changed, 23 insertions(+), 18 deletions(-)

diff --git a/Source/ASDisplayNode+Layout.mm b/Source/ASDisplayNode+Layout.mm
index 66eb9987..592b18db 100644
--- a/Source/ASDisplayNode+Layout.mm
+++ b/Source/ASDisplayNode+Layout.mm
@@ -128,15 +128,18 @@ ASLayoutElementStyleExtensibilityForwarding
 
 - (ASPrimitiveTraitCollection)primitiveTraitCollection
 {
-  return _primitiveTraitCollection.load();
+  AS::MutexLocker l(__instanceLock__);
+  return _primitiveTraitCollection;
 }
 
 - (void)setPrimitiveTraitCollection:(ASPrimitiveTraitCollection)traitCollection
 {
-  if (ASPrimitiveTraitCollectionIsEqualToASPrimitiveTraitCollection(traitCollection, _primitiveTraitCollection.load()) == NO) {
+  AS::UniqueLock l(__instanceLock__);
+  if (ASPrimitiveTraitCollectionIsEqualToASPrimitiveTraitCollection(traitCollection, _primitiveTraitCollection) == NO) {
     _primitiveTraitCollection = traitCollection;
     ASDisplayNodeLogEvent(self, @"asyncTraitCollectionDidChange: %@", NSStringFromASPrimitiveTraitCollection(traitCollection));
 
+    l.unlock();
     [self asyncTraitCollectionDidChange];
   }
 }
diff --git a/Source/Details/ASTraitCollection.h b/Source/Details/ASTraitCollection.h
index 68244a66..17e1740c 100644
--- a/Source/Details/ASTraitCollection.h
+++ b/Source/Details/ASTraitCollection.h
@@ -106,16 +106,6 @@ AS_EXTERN void ASTraitCollectionPropagateDown(id<ASLayoutElement> element, ASPri
 
 @end
 
-#define ASPrimitiveTraitCollectionDefaults \
-- (ASPrimitiveTraitCollection)primitiveTraitCollection\
-{\
-  return _primitiveTraitCollection.load();\
-}\
-- (void)setPrimitiveTraitCollection:(ASPrimitiveTraitCollection)traitCollection\
-{\
-  _primitiveTraitCollection = traitCollection;\
-}\
-
 #define ASLayoutElementCollectionTableSetTraitCollection(lock) \
 - (void)setPrimitiveTraitCollection:(ASPrimitiveTraitCollection)traitCollection\
 {\
diff --git a/Source/Layout/ASLayoutSpec.mm b/Source/Layout/ASLayoutSpec.mm
index 8da22d3d..2bcb9278 100644
--- a/Source/Layout/ASLayoutSpec.mm
+++ b/Source/Layout/ASLayoutSpec.mm
@@ -146,7 +146,17 @@ ASLayoutElementLayoutCalculationDefaults
   return [ASTraitCollection traitCollectionWithASPrimitiveTraitCollection:self.primitiveTraitCollection];
 }
 
-ASPrimitiveTraitCollectionDefaults
+- (ASPrimitiveTraitCollection)primitiveTraitCollection
+{
+  AS::MutexLocker l(__instanceLock__);
+  return _primitiveTraitCollection;
+}
+
+- (void)setPrimitiveTraitCollection:(ASPrimitiveTraitCollection)traitCollection
+{
+  AS::MutexLocker l(__instanceLock__);
+  _primitiveTraitCollection = traitCollection;
+}
 
 #pragma mark - ASLayoutElementStyleExtensibility
 
diff --git a/Source/Private/ASDisplayNodeInternal.h b/Source/Private/ASDisplayNodeInternal.h
index 879639f1..0cb4f1cc 100644
--- a/Source/Private/ASDisplayNodeInternal.h
+++ b/Source/Private/ASDisplayNodeInternal.h
@@ -153,7 +153,7 @@ static constexpr CACornerMask kASCACornerAllCorners =
 
   // Layout support
   ASLayoutElementStyle *_style;
-  std::atomic<ASPrimitiveTraitCollection> _primitiveTraitCollection;
+  ASPrimitiveTraitCollection _primitiveTraitCollection;
 
   // Layout Spec
   ASLayoutSpecBlock _layoutSpecBlock;
diff --git a/Source/Private/_ASCollectionGalleryLayoutItem.mm b/Source/Private/_ASCollectionGalleryLayoutItem.mm
index 57337029..e0faa180 100644
--- a/Source/Private/_ASCollectionGalleryLayoutItem.mm
+++ b/Source/Private/_ASCollectionGalleryLayoutItem.mm
@@ -14,9 +14,12 @@
 #import <AsyncDisplayKit/ASLayoutElementStylePrivate.h>
 #import <AsyncDisplayKit/ASLayoutSpec.h>
 
-@implementation _ASGalleryLayoutItem {
-  std::atomic<ASPrimitiveTraitCollection> _primitiveTraitCollection;
-}
+@interface _ASGalleryLayoutItem ()
+@property ASPrimitiveTraitCollection primitiveTraitCollection;
+
+@end
+
+@implementation _ASGalleryLayoutItem
 
 @synthesize style;
 
@@ -33,7 +36,6 @@
 }
 
 ASLayoutElementStyleExtensibilityForwarding
-ASPrimitiveTraitCollectionDefaults
 
 - (ASTraitCollection *)asyncTraitCollection
 {