- Renamed -addButton... methods as buttons were not being added. Just titled being set. Original name was based off NSAlert.
- Ditch -addButtonWithTitle: altogether and force caller to specify the target button.
This fixes input prompt alerts not having correct number of buttons because -addButtonWithTitle: was not incrementing button count and no one bother to test that.
The theme temp folder is that which WebkIt2 is granted permission to access. As we cannot grant it access to multiple locations, then this is the immediate solution. The theme temp folder is stored in the Caches folder under its own name.
Gives dictionaries greater context of which operation is in progress
As part of this, during copies, defaults are not stripped. Copy objects whole. Only strip defaults when we want to save to disk or cloud.
Previous behavior, when enabling inline media, was to show user a prompt that their IP address may be leaked. What is the point of a warning if a leak can occur while the user is reading the prompt because the feature is now enabled?
New behavior requires user to grant permission through the prompt to enable inline media. The method for this prompt has been relocated to TVCLogControllerInlineMediaService because it's related to inline media and I could not think of a better place.
Furthermore, the prompt has been configured so that clicking the button to open System Settings to configure a proxy does not dismiss the prompt.
Notify user when there are no certificates that can be used for identifying.
Disabled selection of certificate fingerprints. Selecting these text fields make the contents grow beyond the column. Instead of debugging that behavior, it is easier to just disable selection. There is already a copy button associated with each.
When initializing scrollback manager, pass directory in which to save database. No longer pass complete file path. The service will manage the filename so that it can changed it if need be.
When there is a need for the service to change the name of the database, such as being unable to open it, then it will no longer attempt to delete the old copy as well.
Implemented moot delegate methods and changed NSToolbar item implementation use slightly to get rid of console warnings regarding deprecations and other stuff.
Extracted bulk of migration logic out of TPCResourceManager into its own class named TPCSandboxMigration.
Some logic of the migration remained in a private category of TPCResourceManager as it makes sense given the methods are related to resources / file access.
The entire migration system has been modified to be completely modular. Everything relies on the unified `installation` argument to perform migration on any number of containers.
The container for Standard Release was renamed to conform to Apple's standards. No more warnings. The migrator includes an entry for migrating beta users which will be removed before this goes into stable.
Michael
Peter Abbasi