mirror of
https://github.com/phranck/TUIkit.git
synced 2026-06-20 09:54:37 +00:00
Replace vague assertions with concrete, specific checks:
**Pattern 1: !buffer.isEmpty → Specific content checks**
- ViewTests.swift (1): Check bold ANSI code + content
- StatusBarTests.swift (4): Check item labels present
- ModifierTests.swift (1): Check border characters
- ButtonTests.swift (3): Check height + border characters
- ComponentViewTests.swift (4): Check titles + content
- ContainerViewTests.swift (1): Check height + content
- FrameBufferTests.swift (2): Check overlay composition
**Pattern 2: Weak contains() → Exact ANSI codes**
- ANSIRendererFullTests.swift (1): contains("1") → contains("\u{1B}[1m")
**Summary:**
- 17 tests strengthened across 8 files
- All tests now assert observable behavior
- No property readback, no empty checks
- 412 tests passing
Addresses to-dos.md line 34: "Weak Test Rewrites"
501 lines
16 KiB
Swift
501 lines
16 KiB
Swift
//
|
|
// ModifierTests.swift
|
|
// TUIkit
|
|
//
|
|
// Tests for Frame, Padding, Border, and Background modifiers.
|
|
//
|
|
|
|
import Testing
|
|
|
|
@testable import TUIkit
|
|
|
|
// MARK: - Test Helpers
|
|
|
|
/// Creates a default render context for testing.
|
|
private func testContext(width: Int = 40, height: Int = 24) -> RenderContext {
|
|
RenderContext(availableWidth: width, availableHeight: height)
|
|
}
|
|
|
|
// MARK: - EdgeInsets Tests
|
|
|
|
@Suite("EdgeInsets Tests")
|
|
struct EdgeInsetsTests {
|
|
|
|
@Test("EdgeInsets uniform value")
|
|
func edgeInsetsUniform() {
|
|
let insets = EdgeInsets(all: 3)
|
|
#expect(insets.top == 3)
|
|
#expect(insets.leading == 3)
|
|
#expect(insets.bottom == 3)
|
|
#expect(insets.trailing == 3)
|
|
}
|
|
|
|
@Test("EdgeInsets horizontal and vertical")
|
|
func edgeInsetsHorizontalVertical() {
|
|
let insets = EdgeInsets(horizontal: 2, vertical: 1)
|
|
#expect(insets.top == 1)
|
|
#expect(insets.leading == 2)
|
|
#expect(insets.bottom == 1)
|
|
#expect(insets.trailing == 2)
|
|
}
|
|
|
|
@Test("EdgeInsets is Equatable")
|
|
func edgeInsetsEquatable() {
|
|
let insetsA = EdgeInsets(all: 2)
|
|
let insetsB = EdgeInsets(top: 2, leading: 2, bottom: 2, trailing: 2)
|
|
#expect(insetsA == insetsB)
|
|
}
|
|
}
|
|
|
|
// MARK: - Edge Tests
|
|
|
|
@Suite("Edge Tests")
|
|
struct EdgeTests {
|
|
|
|
@Test("Edge.all contains all edges")
|
|
func edgeAll() {
|
|
#expect(Edge.all.contains(.top))
|
|
#expect(Edge.all.contains(.leading))
|
|
#expect(Edge.all.contains(.bottom))
|
|
#expect(Edge.all.contains(.trailing))
|
|
}
|
|
|
|
@Test("Edge.horizontal contains leading and trailing")
|
|
func edgeHorizontal() {
|
|
#expect(Edge.horizontal.contains(.leading))
|
|
#expect(Edge.horizontal.contains(.trailing))
|
|
#expect(!Edge.horizontal.contains(.top))
|
|
#expect(!Edge.horizontal.contains(.bottom))
|
|
}
|
|
|
|
@Test("Edge.vertical contains top and bottom")
|
|
func edgeVertical() {
|
|
#expect(Edge.vertical.contains(.top))
|
|
#expect(Edge.vertical.contains(.bottom))
|
|
#expect(!Edge.vertical.contains(.leading))
|
|
#expect(!Edge.vertical.contains(.trailing))
|
|
}
|
|
}
|
|
|
|
// MARK: - PaddingModifier Tests
|
|
|
|
@Suite("PaddingModifier Tests")
|
|
struct PaddingModifierTests {
|
|
|
|
@Test("Padding adds empty lines for top and bottom")
|
|
func paddingTopBottom() {
|
|
let modifier = PaddingModifier(insets: EdgeInsets(top: 1, leading: 0, bottom: 1, trailing: 0))
|
|
let buffer = FrameBuffer(lines: ["Hello"])
|
|
let context = testContext()
|
|
|
|
let result = modifier.modify(buffer: buffer, context: context)
|
|
|
|
// 1 top + 1 content + 1 bottom = 3
|
|
#expect(result.height == 3)
|
|
#expect(result.lines[0].trimmingCharacters(in: .whitespaces) == "")
|
|
#expect(result.lines[1] == "Hello")
|
|
#expect(result.lines[2].trimmingCharacters(in: .whitespaces) == "")
|
|
}
|
|
|
|
@Test("Padding adds spaces for leading and trailing")
|
|
func paddingLeadingTrailing() {
|
|
let modifier = PaddingModifier(insets: EdgeInsets(top: 0, leading: 2, bottom: 0, trailing: 3))
|
|
let buffer = FrameBuffer(lines: ["Hi"])
|
|
let context = testContext()
|
|
|
|
let result = modifier.modify(buffer: buffer, context: context)
|
|
|
|
#expect(result.height == 1)
|
|
// " Hi " — 2 leading + "Hi" + 3 trailing
|
|
#expect(result.lines[0] == " Hi ")
|
|
}
|
|
|
|
@Test("Padding all sides")
|
|
func paddingAllSides() {
|
|
let modifier = PaddingModifier(insets: EdgeInsets(all: 1))
|
|
let buffer = FrameBuffer(lines: ["X"])
|
|
let context = testContext()
|
|
|
|
let result = modifier.modify(buffer: buffer, context: context)
|
|
|
|
// 1 top + 1 content + 1 bottom = 3
|
|
#expect(result.height == 3)
|
|
// Content line: 1 leading + "X" + 1 trailing = " X "
|
|
#expect(result.lines[1] == " X ")
|
|
}
|
|
|
|
@Test("Padding on empty buffer returns empty")
|
|
func paddingEmptyBuffer() {
|
|
let modifier = PaddingModifier(insets: EdgeInsets(all: 2))
|
|
let buffer = FrameBuffer()
|
|
let context = testContext()
|
|
|
|
let result = modifier.modify(buffer: buffer, context: context)
|
|
|
|
// Only padding lines (no content)
|
|
#expect(result.height == 4) // 2 top + 0 content + 2 bottom
|
|
}
|
|
|
|
@Test("Padding preserves multiple content lines")
|
|
func paddingMultipleLines() {
|
|
let modifier = PaddingModifier(insets: EdgeInsets(top: 1, leading: 1, bottom: 1, trailing: 1))
|
|
let buffer = FrameBuffer(lines: ["AAA", "BBB"])
|
|
let context = testContext()
|
|
|
|
let result = modifier.modify(buffer: buffer, context: context)
|
|
|
|
// 1 top + 2 content + 1 bottom = 4
|
|
#expect(result.height == 4)
|
|
#expect(result.lines[1] == " AAA ")
|
|
#expect(result.lines[2] == " BBB ")
|
|
}
|
|
|
|
@Test("Zero padding returns original dimensions")
|
|
func paddingZero() {
|
|
let modifier = PaddingModifier(insets: EdgeInsets())
|
|
let buffer = FrameBuffer(lines: ["Test"])
|
|
let context = testContext()
|
|
|
|
let result = modifier.modify(buffer: buffer, context: context)
|
|
|
|
#expect(result.height == 1)
|
|
#expect(result.lines[0] == "Test")
|
|
}
|
|
}
|
|
|
|
// MARK: - FrameModifier Tests
|
|
|
|
@Suite("FrameModifier Tests")
|
|
struct FrameModifierTests {
|
|
|
|
@Test("FlexibleFrameView with maxWidth infinity fills available width")
|
|
func frameMaxWidthInfinity() {
|
|
let frame = FlexibleFrameView(
|
|
content: Text("Hi"),
|
|
minWidth: nil,
|
|
idealWidth: nil,
|
|
maxWidth: .infinity,
|
|
minHeight: nil,
|
|
idealHeight: nil,
|
|
maxHeight: nil,
|
|
alignment: .center
|
|
)
|
|
let context = testContext(width: 30)
|
|
let buffer = frame.renderToBuffer(context: context)
|
|
|
|
#expect(buffer.width == 30)
|
|
}
|
|
|
|
@Test("FlexibleFrameView with fixed maxWidth constrains")
|
|
func frameFixedMaxWidth() {
|
|
let frame = FlexibleFrameView(
|
|
content: Text("Short"),
|
|
minWidth: nil,
|
|
idealWidth: nil,
|
|
maxWidth: .fixed(10),
|
|
minHeight: nil,
|
|
idealHeight: nil,
|
|
maxHeight: nil,
|
|
alignment: .leading
|
|
)
|
|
let context = testContext(width: 40)
|
|
let buffer = frame.renderToBuffer(context: context)
|
|
|
|
// Content "Short" is 5 chars, no maxWidth expansion without infinity
|
|
#expect(buffer.width <= 10)
|
|
}
|
|
|
|
@Test("FlexibleFrameView with minWidth enforces minimum")
|
|
func frameMinWidth() {
|
|
let frame = FlexibleFrameView(
|
|
content: Text("Hi"),
|
|
minWidth: 10,
|
|
idealWidth: nil,
|
|
maxWidth: nil,
|
|
minHeight: nil,
|
|
idealHeight: nil,
|
|
maxHeight: nil,
|
|
alignment: .leading
|
|
)
|
|
let context = testContext(width: 40)
|
|
let buffer = frame.renderToBuffer(context: context)
|
|
|
|
#expect(buffer.width >= 10)
|
|
}
|
|
|
|
@Test("FlexibleFrameView with minHeight enforces minimum")
|
|
func frameMinHeight() {
|
|
let frame = FlexibleFrameView(
|
|
content: Text("Hi"),
|
|
minWidth: nil,
|
|
idealWidth: nil,
|
|
maxWidth: nil,
|
|
minHeight: 5,
|
|
idealHeight: nil,
|
|
maxHeight: nil,
|
|
alignment: .top
|
|
)
|
|
let context = testContext()
|
|
let buffer = frame.renderToBuffer(context: context)
|
|
|
|
#expect(buffer.height >= 5)
|
|
}
|
|
|
|
@Test("FlexibleFrameView alignment center")
|
|
func frameCenterAlignment() {
|
|
let frame = FlexibleFrameView(
|
|
content: Text("Hi"),
|
|
minWidth: 10,
|
|
idealWidth: nil,
|
|
maxWidth: nil,
|
|
minHeight: 3,
|
|
idealHeight: nil,
|
|
maxHeight: nil,
|
|
alignment: .center
|
|
)
|
|
let context = testContext()
|
|
let buffer = frame.renderToBuffer(context: context)
|
|
|
|
#expect(buffer.width >= 10)
|
|
#expect(buffer.height >= 3)
|
|
// Center vertically: content should be on line 1 (middle of 3)
|
|
let contentLine = buffer.lines[1]
|
|
#expect(contentLine.contains("Hi"))
|
|
}
|
|
|
|
@Test("FlexibleFrameView alignment trailing")
|
|
func frameTrailingAlignment() {
|
|
let frame = FlexibleFrameView(
|
|
content: Text("Hi"),
|
|
minWidth: 10,
|
|
idealWidth: nil,
|
|
maxWidth: nil,
|
|
minHeight: nil,
|
|
idealHeight: nil,
|
|
maxHeight: nil,
|
|
alignment: .trailing
|
|
)
|
|
let context = testContext()
|
|
let buffer = frame.renderToBuffer(context: context)
|
|
|
|
// "Hi" should be right-aligned within 10 chars
|
|
let line = buffer.lines[0]
|
|
#expect(line.hasSuffix("Hi"))
|
|
}
|
|
|
|
@Test("FlexibleFrameView alignment bottom")
|
|
func frameBottomAlignment() {
|
|
let frame = FlexibleFrameView(
|
|
content: Text("Hi"),
|
|
minWidth: nil,
|
|
idealWidth: nil,
|
|
maxWidth: nil,
|
|
minHeight: 3,
|
|
idealHeight: nil,
|
|
maxHeight: nil,
|
|
alignment: .bottom
|
|
)
|
|
let context = testContext()
|
|
let buffer = frame.renderToBuffer(context: context)
|
|
|
|
#expect(buffer.height >= 3)
|
|
// Content on last line
|
|
let lastLine = buffer.lines[buffer.height - 1]
|
|
#expect(lastLine.contains("Hi"))
|
|
}
|
|
|
|
}
|
|
|
|
// MARK: - BorderModifier Tests
|
|
|
|
@Suite("BorderModifier Tests")
|
|
struct BorderModifierTests {
|
|
|
|
@Test("BorderedView renders with top and bottom borders")
|
|
func borderedViewRenders() {
|
|
let bordered = BorderedView(content: Text("Test"), style: .line, color: nil)
|
|
let context = testContext()
|
|
let buffer = bordered.renderToBuffer(context: context)
|
|
|
|
// Top border + content + bottom border
|
|
#expect(buffer.height == 3)
|
|
#expect(buffer.lines[0].contains("┌")) // top-left corner
|
|
#expect(buffer.lines[1].contains("Test"))
|
|
#expect(buffer.lines[2].contains("└")) // bottom-left corner
|
|
}
|
|
|
|
@Test("BorderedView with empty content returns empty")
|
|
func borderedViewEmptyContent() {
|
|
let bordered = BorderedView(content: EmptyView(), style: .line, color: nil)
|
|
let context = testContext()
|
|
let buffer = bordered.renderToBuffer(context: context)
|
|
|
|
#expect(buffer.isEmpty)
|
|
}
|
|
|
|
@Test("BorderedView with line style uses correct corner characters")
|
|
func borderedViewLineStyle() {
|
|
let bordered = BorderedView(content: Text("X"), style: .line, color: nil)
|
|
let context = testContext()
|
|
let buffer = bordered.renderToBuffer(context: context)
|
|
|
|
let topLine = buffer.lines[0].stripped
|
|
let bottomLine = buffer.lines[buffer.height - 1].stripped
|
|
|
|
#expect(topLine.hasPrefix("┌"))
|
|
#expect(topLine.hasSuffix("┐"))
|
|
#expect(bottomLine.hasPrefix("└"))
|
|
#expect(bottomLine.hasSuffix("┘"))
|
|
}
|
|
|
|
@Test("BorderedView with doubleLine style uses correct characters")
|
|
func borderedViewDoubleLineStyle() {
|
|
let bordered = BorderedView(content: Text("X"), style: .doubleLine, color: nil)
|
|
let context = testContext()
|
|
let buffer = bordered.renderToBuffer(context: context)
|
|
|
|
let topLine = buffer.lines[0].stripped
|
|
let bottomLine = buffer.lines[buffer.height - 1].stripped
|
|
|
|
#expect(topLine.hasPrefix("╔"))
|
|
#expect(topLine.hasSuffix("╗"))
|
|
#expect(bottomLine.hasPrefix("╚"))
|
|
#expect(bottomLine.hasSuffix("╝"))
|
|
}
|
|
|
|
@Test("BorderedView with rounded style uses correct characters")
|
|
func borderedViewRoundedStyle() {
|
|
let bordered = BorderedView(content: Text("X"), style: .rounded, color: nil)
|
|
let context = testContext()
|
|
let buffer = bordered.renderToBuffer(context: context)
|
|
|
|
let topLine = buffer.lines[0].stripped
|
|
let bottomLine = buffer.lines[buffer.height - 1].stripped
|
|
|
|
#expect(topLine.hasPrefix("╭"))
|
|
#expect(topLine.hasSuffix("╮"))
|
|
#expect(bottomLine.hasPrefix("╰"))
|
|
#expect(bottomLine.hasSuffix("╯"))
|
|
}
|
|
|
|
@Test("BorderedView with heavy style uses correct characters")
|
|
func borderedViewHeavyStyle() {
|
|
let bordered = BorderedView(content: Text("X"), style: .heavy, color: nil)
|
|
let context = testContext()
|
|
let buffer = bordered.renderToBuffer(context: context)
|
|
|
|
let topLine = buffer.lines[0].stripped
|
|
let bottomLine = buffer.lines[buffer.height - 1].stripped
|
|
|
|
#expect(topLine.hasPrefix("┏"))
|
|
#expect(topLine.hasSuffix("┓"))
|
|
#expect(bottomLine.hasPrefix("┗"))
|
|
#expect(bottomLine.hasSuffix("┛"))
|
|
}
|
|
|
|
@Test("BorderedView with ascii style uses correct characters")
|
|
func borderedViewAsciiStyle() {
|
|
let bordered = BorderedView(content: Text("X"), style: .ascii, color: nil)
|
|
let context = testContext()
|
|
let buffer = bordered.renderToBuffer(context: context)
|
|
|
|
let topLine = buffer.lines[0].stripped
|
|
let bottomLine = buffer.lines[buffer.height - 1].stripped
|
|
|
|
#expect(topLine.hasPrefix("+"))
|
|
#expect(topLine.hasSuffix("+"))
|
|
#expect(bottomLine.hasPrefix("+"))
|
|
#expect(bottomLine.hasSuffix("+"))
|
|
}
|
|
|
|
@Test("BorderedView adds 2 to content width")
|
|
func borderedViewWidthOverhead() {
|
|
let bordered = BorderedView(content: Text("ABCDE"), style: .line, color: nil)
|
|
let context = testContext()
|
|
let buffer = bordered.renderToBuffer(context: context)
|
|
|
|
// Content "ABCDE" = 5, + 2 for borders = 7
|
|
let topLine = buffer.lines[0].stripped
|
|
#expect(topLine.count == 7)
|
|
}
|
|
|
|
}
|
|
|
|
// MARK: - BorderStyle Tests
|
|
|
|
@Suite("BorderStyle Tests")
|
|
struct BorderStyleTests {
|
|
|
|
@Test("Custom border style defaults T-junctions to vertical")
|
|
func customBorderStyleDefaultTJunctions() {
|
|
let custom = BorderStyle(
|
|
topLeft: "A",
|
|
topRight: "B",
|
|
bottomLeft: "C",
|
|
bottomRight: "D",
|
|
horizontal: "E",
|
|
vertical: "F"
|
|
)
|
|
#expect(custom.leftT == "F")
|
|
#expect(custom.rightT == "F")
|
|
}
|
|
|
|
}
|
|
|
|
// MARK: - BackgroundModifier Tests
|
|
|
|
@Suite("BackgroundModifier Tests")
|
|
struct BackgroundModifierTests {
|
|
|
|
@Test("Background modifier applies ANSI background code")
|
|
func backgroundAppliesCode() {
|
|
let modifier = BackgroundModifier(color: .red)
|
|
let buffer = FrameBuffer(lines: ["Hello"])
|
|
let context = testContext()
|
|
|
|
let result = modifier.modify(buffer: buffer, context: context)
|
|
|
|
#expect(result.height == 1)
|
|
// Should contain ANSI escape codes
|
|
let line = result.lines[0]
|
|
#expect(line.contains("\u{1B}["))
|
|
#expect(line.contains("Hello"))
|
|
// Should end with reset
|
|
#expect(line.hasSuffix(ANSIRenderer.reset))
|
|
}
|
|
|
|
@Test("Background modifier preserves line count")
|
|
func backgroundPreservesLineCount() {
|
|
let modifier = BackgroundModifier(color: .blue)
|
|
let buffer = FrameBuffer(lines: ["Line 1", "Line 2", "Line 3"])
|
|
let context = testContext()
|
|
|
|
let result = modifier.modify(buffer: buffer, context: context)
|
|
|
|
#expect(result.height == 3)
|
|
}
|
|
|
|
@Test("Background modifier on empty buffer returns empty")
|
|
func backgroundEmptyBuffer() {
|
|
let modifier = BackgroundModifier(color: .green)
|
|
let buffer = FrameBuffer()
|
|
let context = testContext()
|
|
|
|
let result = modifier.modify(buffer: buffer, context: context)
|
|
|
|
#expect(result.isEmpty)
|
|
}
|
|
|
|
@Test("Background modifier pads lines to full width")
|
|
func backgroundPadsLines() {
|
|
let modifier = BackgroundModifier(color: .red)
|
|
let buffer = FrameBuffer(lines: ["Short", "VeryLongLine"])
|
|
let context = testContext()
|
|
|
|
let result = modifier.modify(buffer: buffer, context: context)
|
|
|
|
// Both lines should have the same visible width after padding
|
|
#expect(result.lines[0].strippedLength == result.lines[1].strippedLength)
|
|
}
|
|
}
|