mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
Zev Eisenberg
fcf848608e
* Add Example wrapper in order to display test failures inline when running in Xcode. * Stop using Swift 5.1-only features so we can compile on Xcode 10.2. * Wrap strings in Example. * Add Changelog entry. * Wrap all examples in Example struct. * Better and more complete capturing of line numbers. * Fix broken test. * Better test traceability. * Address or disable linting warnings. * Add documentation comments. * Disable linter for a few cases. * Limit mutability and add copy-and-mutate utility functions. * Limit scope of mutability.
46 lines
1.8 KiB
Swift
46 lines
1.8 KiB
Swift
import SourceKittenFramework
|
|
|
|
public struct EmptyCountRule: ConfigurationProviderRule, OptInRule, AutomaticTestableRule {
|
|
public var configuration = SeverityConfiguration(.error)
|
|
|
|
public init() {}
|
|
|
|
public static let description = RuleDescription(
|
|
identifier: "empty_count",
|
|
name: "Empty Count",
|
|
description: "Prefer checking `isEmpty` over comparing `count` to zero.",
|
|
kind: .performance,
|
|
nonTriggeringExamples: [
|
|
Example("var count = 0\n"),
|
|
Example("[Int]().isEmpty\n"),
|
|
Example("[Int]().count > 1\n"),
|
|
Example("[Int]().count == 1\n"),
|
|
Example("[Int]().count == 0xff\n"),
|
|
Example("[Int]().count == 0b01\n"),
|
|
Example("[Int]().count == 0o07\n"),
|
|
Example("discount == 0\n"),
|
|
Example("order.discount == 0\n")
|
|
],
|
|
triggeringExamples: [
|
|
Example("[Int]().↓count == 0\n"),
|
|
Example("[Int]().↓count > 0\n"),
|
|
Example("[Int]().↓count != 0\n"),
|
|
Example("[Int]().↓count == 0x0\n"),
|
|
Example("[Int]().↓count == 0x00_00\n"),
|
|
Example("[Int]().↓count == 0b00\n"),
|
|
Example("[Int]().↓count == 0o00\n"),
|
|
Example("↓count == 0\n")
|
|
]
|
|
)
|
|
|
|
public func validate(file: SwiftLintFile) -> [StyleViolation] {
|
|
let pattern = "\\bcount\\s*(==|!=|<|<=|>|>=)\\s*0(\\b|([box][0_]+\\b){1})"
|
|
let excludingKinds = SyntaxKind.commentAndStringKinds
|
|
return file.match(pattern: pattern, excludingSyntaxKinds: excludingKinds).map {
|
|
StyleViolation(ruleDescription: type(of: self).description,
|
|
severity: configuration.severity,
|
|
location: Location(file: file, characterOffset: $0.location))
|
|
}
|
|
}
|
|
}
|