mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
65 lines
2.2 KiB
Swift
65 lines
2.2 KiB
Swift
//
|
|
// ControlStatementRule.swift
|
|
// SwiftLint
|
|
//
|
|
// Created by Andrea Mazzini on 26/05/15.
|
|
// Copyright (c) 2015 Realm. All rights reserved.
|
|
//
|
|
|
|
import SourceKittenFramework
|
|
|
|
public struct ControlStatementRule: Rule {
|
|
public init() {}
|
|
|
|
public let identifier = "control_statement"
|
|
|
|
public func validateFile(file: File) -> [StyleViolation] {
|
|
return ["if", "for", "while"].flatMap { statementKind in
|
|
let pattern = "\(statementKind)\\s*\\([^,]*\\)\\s*\\{"
|
|
return compact(file.matchPattern(pattern).map { match, syntaxKinds in
|
|
if syntaxKinds.first != .Keyword {
|
|
return nil
|
|
}
|
|
return StyleViolation(type: .ControlStatement,
|
|
location: Location(file: file, offset: match.location),
|
|
severity: .Low,
|
|
reason: "\(statementKind) statements shouldn't wrap their conditionals in " +
|
|
"parentheses.")
|
|
})
|
|
}
|
|
}
|
|
|
|
public let example = RuleExample(
|
|
ruleName: "Control Statement",
|
|
ruleDescription: "if,for,while,do statements shouldn't wrap their conditionals in " +
|
|
"parentheses.",
|
|
nonTriggeringExamples: [
|
|
"if condition {\n",
|
|
"if (a, b) == (0, 1) {\n",
|
|
"if renderGif(data) {\n",
|
|
"renderGif(data)\n",
|
|
"for item in collection {\n",
|
|
"for (key, value) in dictionary {\n",
|
|
"for (index, value) in enumerate(array) {\n",
|
|
"for var index = 0; index < 42; index++ {\n",
|
|
"while condition {\n",
|
|
"} while condition {\n",
|
|
"do { ; } while condition {\n"
|
|
],
|
|
triggeringExamples: [
|
|
"if (condition) {\n",
|
|
"if(condition) {\n",
|
|
"for (item in collection) {\n",
|
|
"for (var index = 0; index < 42; index++) {\n",
|
|
"for(item in collection) {\n",
|
|
"for(var index = 0; index < 42; index++) {\n",
|
|
"while (condition) {\n",
|
|
"while(condition) {\n",
|
|
"} while (condition) {\n",
|
|
"} while(condition) {\n",
|
|
"do { ; } while(condition) {\n",
|
|
"do { ; } while (condition) {\n"
|
|
]
|
|
)
|
|
}
|