Files
SwiftLint/Source/SwiftLintFramework/Rules/Idiomatic/StaticOperatorRule.swift
T
Marcelo FabriandGitHub ca7510a394 Migrate static_operator rule to SwiftSyntax (#4271)
* Migrate `static_operator` rule to SwiftSyntax

* PR feedback
2022-10-08 01:49:15 -07:00

132 lines
3.9 KiB
Swift

import SwiftSyntax
public struct StaticOperatorRule: SwiftSyntaxRule, ConfigurationProviderRule, OptInRule {
public var configuration = SeverityConfiguration(.warning)
public init() {}
public static let description = RuleDescription(
identifier: "static_operator",
name: "Static Operator",
description: "Operators should be declared as static functions, not free functions.",
kind: .idiomatic,
nonTriggeringExamples: [
Example("""
class A: Equatable {
static func == (lhs: A, rhs: A) -> Bool {
return false
}
"""),
Example("""
class A<T>: Equatable {
static func == <T>(lhs: A<T>, rhs: A<T>) -> Bool {
return false
}
"""),
Example("""
public extension Array where Element == Rule {
static func == (lhs: Array, rhs: Array) -> Bool {
if lhs.count != rhs.count { return false }
return !zip(lhs, rhs).contains { !$0.0.isEqualTo($0.1) }
}
}
"""),
Example("""
private extension Optional where Wrapped: Comparable {
static func < (lhs: Optional, rhs: Optional) -> Bool {
switch (lhs, rhs) {
case let (lhs?, rhs?):
return lhs < rhs
case (nil, _?):
return true
default:
return false
}
}
}
""")
],
triggeringExamples: [
Example("""
↓func == (lhs: A, rhs: A) -> Bool {
return false
}
"""),
Example("""
↓func == <T>(lhs: A<T>, rhs: A<T>) -> Bool {
return false
}
"""),
Example("""
↓func == (lhs: [Rule], rhs: [Rule]) -> Bool {
if lhs.count != rhs.count { return false }
return !zip(lhs, rhs).contains { !$0.0.isEqualTo($0.1) }
}
"""),
Example("""
private ↓func < <T: Comparable>(lhs: T?, rhs: T?) -> Bool {
switch (lhs, rhs) {
case let (lhs?, rhs?):
return lhs < rhs
case (nil, _?):
return true
default:
return false
}
}
""")
]
)
public func makeVisitor(file: SwiftLintFile) -> ViolationsSyntaxVisitor? {
Visitor(viewMode: .sourceAccurate)
}
}
private extension StaticOperatorRule {
final class Visitor: SyntaxVisitor, ViolationsSyntaxVisitor {
private(set) var violationPositions: [AbsolutePosition] = []
override func visitPost(_ node: FunctionDeclSyntax) {
if node.isFreeFunction, node.isOperator {
violationPositions.append(node.funcKeyword.positionAfterSkippingLeadingTrivia)
}
}
override func visit(_ node: ClassDeclSyntax) -> SyntaxVisitorContinueKind {
.skipChildren
}
override func visit(_ node: ExtensionDeclSyntax) -> SyntaxVisitorContinueKind {
.skipChildren
}
override func visit(_ node: StructDeclSyntax) -> SyntaxVisitorContinueKind {
.skipChildren
}
override func visit(_ node: EnumDeclSyntax) -> SyntaxVisitorContinueKind {
.skipChildren
}
override func visit(_ node: ProtocolDeclSyntax) -> SyntaxVisitorContinueKind {
.skipChildren
}
}
}
private extension FunctionDeclSyntax {
var isFreeFunction: Bool {
parent?.is(CodeBlockItemSyntax.self) ?? false
}
var isOperator: Bool {
switch identifier.tokenKind {
case .spacedBinaryOperator:
return true
default:
return false
}
}
}