Files
SwiftLint/Source/SwiftLintFramework/Rules/Idiomatic/UnavailableFunctionRule.swift
T
Danny Mösch 449190d324 Verify examples in rules by default and enforce explicit exclusion (#4065)
A rule must conform to ManuallyTestedExamplesRule to skip generation of a test for its examples.
2022-08-09 22:32:09 +02:00

127 lines
4.6 KiB
Swift

import Foundation
import SourceKittenFramework
public struct UnavailableFunctionRule: ASTRule, ConfigurationProviderRule, OptInRule {
public var configuration = SeverityConfiguration(.warning)
public init() {}
public static let description = RuleDescription(
identifier: "unavailable_function",
name: "Unavailable Function",
description: "Unimplemented functions should be marked as unavailable.",
kind: .idiomatic,
nonTriggeringExamples: [
Example("""
class ViewController: UIViewController {
@available(*, unavailable)
public required init?(coder aDecoder: NSCoder) {
preconditionFailure("init(coder:) has not been implemented")
}
}
"""),
Example("""
func jsonValue(_ jsonString: String) -> NSObject {
let data = jsonString.data(using: .utf8)!
let result = try! JSONSerialization.jsonObject(with: data, options: [])
if let dict = (result as? [String: Any])?.bridge() {
return dict
} else if let array = (result as? [Any])?.bridge() {
return array
}
fatalError()
}
"""),
Example("""
func resetOnboardingStateAndCrash() -> Never {
resetUserDefaults()
// Crash the app to re-start the onboarding flow.
fatalError("Onboarding re-start crash.")
}
""")
],
triggeringExamples: [
Example("""
class ViewController: UIViewController {
public required ↓init?(coder aDecoder: NSCoder) {
fatalError("init(coder:) has not been implemented")
}
}
"""),
Example("""
class ViewController: UIViewController {
public required ↓init?(coder aDecoder: NSCoder) {
let reason = "init(coder:) has not been implemented"
fatalError(reason)
}
}
"""),
Example("""
class ViewController: UIViewController {
public required ↓init?(coder aDecoder: NSCoder) {
preconditionFailure("init(coder:) has not been implemented")
}
}
"""),
Example("""
func resetOnboardingStateAndCrash() {
resetUserDefaults()
// Crash the app to re-start the onboarding flow.
fatalError("Onboarding re-start crash.")
}
""")
]
)
private static let terminatingFunctions = Set([
"abort",
"fatalError",
"preconditionFailure"
])
public func validate(file: SwiftLintFile, kind: SwiftDeclarationKind,
dictionary: SourceKittenDictionary) -> [StyleViolation] {
guard SwiftDeclarationKind.functionKinds.contains(kind) else {
return []
}
let containsTerminatingCall = dictionary.substructure.contains { dict -> Bool in
return dict.expressionKind == .call && (dict.name.map { name in
Self.terminatingFunctions.contains(name)
} ?? false)
}
let hasReturnTypeNever = dictionary.typeName == "Never"
guard
containsTerminatingCall,
!hasReturnTypeNever,
!isFunctionUnavailable(file: file, dictionary: dictionary),
let offset = dictionary.offset,
let bodyRange = dictionary.bodyByteRange,
let range = file.stringView.byteRangeToNSRange(bodyRange),
file.match(pattern: "\\breturn\\b", with: [.keyword], range: range).isEmpty
else {
return []
}
return [
StyleViolation(ruleDescription: Self.description,
severity: configuration.severity,
location: Location(file: file, byteOffset: offset))
]
}
private func isFunctionUnavailable(file: SwiftLintFile, dictionary: SourceKittenDictionary) -> Bool {
return dictionary.swiftAttributes.contains { dict -> Bool in
guard dict.attribute.flatMap(SwiftDeclarationAttributeKind.init(rawValue:)) == .available,
let byteRange = dict.byteRange,
let contents = file.stringView.substringWithByteRange(byteRange) else {
return false
}
return contents.contains("unavailable")
}
}
}