Files
SwiftLint/Source/SwiftLintFramework/Rules/Performance/ContainsOverRangeNilComparisonRule.swift
T
2019-11-07 15:19:17 +02:00

36 lines
1.5 KiB
Swift

import SourceKittenFramework
public struct ContainsOverRangeNilComparisonRule: CallPairRule, OptInRule, ConfigurationProviderRule,
AutomaticTestableRule {
public var configuration = SeverityConfiguration(.warning)
public init() {}
public static let description = RuleDescription(
identifier: "contains_over_range_nil_comparison",
name: "Contains over range(of:) comparison to nil",
description: "Prefer `contains` over `range(of:) != nil` and `range(of:) == nil`.",
kind: .performance,
nonTriggeringExamples: [
"let range = myString.range(of: \"Test\")",
"myString.contains(\"Test\")",
"!myString.contains(\"Test\")",
"resourceString.range(of: rule.regex, options: .regularExpression) != nil"
],
triggeringExamples: ["!=", "=="].flatMap { comparison in
return [
"↓myString.range(of: \"Test\") \(comparison) nil"
]
}
)
public func validate(file: SwiftLintFile) -> [StyleViolation] {
let pattern = "\\)\\s*(==|!=)\\s*nil"
return validate(file: file, pattern: pattern, patternSyntaxKinds: [.keyword],
callNameSuffix: ".range", severity: configuration.severity,
reason: "Prefer `contains` over range(of:) comparison to nil") { expression in
return expression.enclosedArguments.map { $0.name } == ["of"]
}
}
}