mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
b83e0991b9
The MIT license doesn't require that all files be prepended with this licensing or copyright information. Realm confirmed that they're ok with this change. This will enable some companies to contribute to SwiftLint and the date & authorship information will remain accessible via git source control.
167 lines
6.7 KiB
Swift
167 lines
6.7 KiB
Swift
import Foundation
|
|
import SourceKittenFramework
|
|
|
|
public struct DiscouragedOptionalCollectionRule: ASTRule, OptInRule, ConfigurationProviderRule {
|
|
public var configuration = SeverityConfiguration(.warning)
|
|
|
|
public init() {}
|
|
|
|
public static let description = RuleDescription(
|
|
identifier: "discouraged_optional_collection",
|
|
name: "Discouraged Optional Collection",
|
|
description: "Prefer empty collection over optional collection.",
|
|
kind: .idiomatic,
|
|
nonTriggeringExamples: DiscouragedOptionalCollectionExamples.nonTriggeringExamples,
|
|
triggeringExamples: DiscouragedOptionalCollectionExamples.triggeringExamples
|
|
)
|
|
|
|
public func validate(file: File,
|
|
kind: SwiftDeclarationKind,
|
|
dictionary: [String: SourceKitRepresentable]) -> [StyleViolation] {
|
|
|
|
let offsets = variableViolations(file: file, kind: kind, dictionary: dictionary) +
|
|
functionViolations(file: file, kind: kind, dictionary: dictionary)
|
|
|
|
return offsets.map {
|
|
StyleViolation(ruleDescription: type(of: self).description,
|
|
severity: configuration.severity,
|
|
location: Location(file: file, byteOffset: $0))
|
|
}
|
|
}
|
|
|
|
// MARK: - Private
|
|
|
|
private func variableViolations(file: File,
|
|
kind: SwiftDeclarationKind,
|
|
dictionary: [String: SourceKitRepresentable]) -> [Int] {
|
|
guard
|
|
SwiftDeclarationKind.variableKinds.contains(kind),
|
|
let offset = dictionary.offset,
|
|
let typeName = dictionary.typeName else { return [] }
|
|
|
|
return typeName.optionalCollectionRanges().map { _ in offset }
|
|
}
|
|
|
|
private func functionViolations(file: File,
|
|
kind: SwiftDeclarationKind,
|
|
dictionary: [String: SourceKitRepresentable]) -> [Int] {
|
|
guard
|
|
SwiftDeclarationKind.functionKinds.contains(kind),
|
|
let nameOffset = dictionary.nameOffset,
|
|
let nameLength = dictionary.nameLength,
|
|
let length = dictionary.length,
|
|
let offset = dictionary.offset,
|
|
case let start = nameOffset + nameLength,
|
|
case let end = dictionary.bodyOffset ?? offset + length,
|
|
case let contents = file.contents.bridge(),
|
|
let range = contents.byteRangeToNSRange(start: start, length: end - start),
|
|
let match = file.match(pattern: "->\\s*(.*?)\\{", excludingSyntaxKinds: excludingKinds, range: range).first
|
|
else { return [] }
|
|
|
|
return contents.substring(with: match).optionalCollectionRanges().map { _ in nameOffset }
|
|
}
|
|
|
|
private let excludingKinds = SyntaxKind.allKinds.subtracting([.typeidentifier])
|
|
}
|
|
|
|
private extension String {
|
|
/// Ranges of optional collections within the bounds of the string.
|
|
///
|
|
/// Example: [String: [Int]?]
|
|
///
|
|
/// [ S t r i n g : [ I n t ] ? ]
|
|
/// 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
|
|
/// ^ ^
|
|
/// = [9, 14]
|
|
/// = [9, 15), mathematical interval, w/ lower and upper bounds.
|
|
///
|
|
/// Example: [String: [Int]?]?
|
|
///
|
|
/// [ S t r i n g : [ I n t ] ? ] ?
|
|
/// 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16
|
|
/// ^ ^ ^ ^
|
|
/// = [0, 16], [9, 14]
|
|
/// = [0, 17), [9, 15), mathematical interval, w/ lower and upper bounds.
|
|
///
|
|
/// Example: var x = Set<Int>?
|
|
///
|
|
/// v a r x = S e t < I n t > ?
|
|
/// 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16
|
|
/// ^ ^
|
|
/// = [8, 16]
|
|
/// = [8, 17), mathematical interval, w/ lower and upper bounds.
|
|
///
|
|
/// - Returns: An array of ranges.
|
|
func optionalCollectionRanges() -> [Range<String.Index>] {
|
|
let squareBrackets = balancedRanges(from: "[", to: "]").compactMap { range -> Range<String.Index>? in
|
|
guard
|
|
range.upperBound < endIndex,
|
|
let finalIndex = index(range.upperBound, offsetBy: 1, limitedBy: endIndex),
|
|
self[range.upperBound] == "?" else { return nil }
|
|
|
|
return Range(range.lowerBound..<finalIndex)
|
|
}
|
|
|
|
let angleBrackets = balancedRanges(from: "<", to: ">").compactMap { range -> Range<String.Index>? in
|
|
guard
|
|
range.upperBound < endIndex,
|
|
let initialIndex = index(range.lowerBound, offsetBy: -3, limitedBy: startIndex),
|
|
let finalIndex = index(range.upperBound, offsetBy: 1, limitedBy: endIndex),
|
|
self[initialIndex..<range.lowerBound] == "Set",
|
|
self[range.upperBound] == "?" else { return nil }
|
|
|
|
return Range(initialIndex..<finalIndex)
|
|
}
|
|
|
|
return squareBrackets + angleBrackets
|
|
}
|
|
|
|
/// Indices of character within the bounds of the string.
|
|
///
|
|
/// Example:
|
|
/// a m a n h a
|
|
/// 0 1 2 3 4 5
|
|
/// ^ ^ ^
|
|
/// = [0, 2, 5]
|
|
///
|
|
/// - Parameter character: The character to look for.
|
|
/// - Returns: Array of indices.
|
|
private func indices(of character: Character) -> [String.Index] {
|
|
return indices.compactMap { self[$0] == character ? $0 : nil }
|
|
}
|
|
|
|
/// Ranges of balanced substrings.
|
|
///
|
|
/// Example: ((1+2)*(3+4))
|
|
///
|
|
/// ( ( 1 + 2 ) * ( 3 + 4 ) )
|
|
/// 0 1 2 3 4 5 6 7 8 9 10 11 12
|
|
/// ^ ^ ^ ^ ^ ^
|
|
/// = [0, 12], [1, 5], [7, 11]
|
|
/// = [0, 13), [1, 6), [7, 12), mathematical interval, w/ lower and upper bounds.
|
|
///
|
|
/// - Parameters:
|
|
/// - prefix: The prefix to look for.
|
|
/// - suffix: The suffix to look for.
|
|
/// - Returns: Array of ranges of balanced substrings
|
|
private func balancedRanges(from prefix: Character, to suffix: Character) -> [Range<String.Index>] {
|
|
return indices(of: prefix).compactMap { prefixIndex in
|
|
var pairCount = 0
|
|
var currentIndex = prefixIndex
|
|
var foundCharacter = false
|
|
|
|
while currentIndex < endIndex {
|
|
let character = self[currentIndex]
|
|
currentIndex = index(after: currentIndex)
|
|
|
|
if character == prefix { pairCount += 1 }
|
|
if character == suffix { pairCount -= 1 }
|
|
if pairCount != 0 { foundCharacter = true }
|
|
if pairCount == 0 && foundCharacter { break }
|
|
}
|
|
|
|
return pairCount == 0 && foundCharacter ? Range(prefixIndex..<currentIndex) : nil
|
|
}
|
|
}
|
|
}
|