mirror of
https://github.com/realm/SwiftLint.git
synced 2026-05-07 20:12:49 +00:00
JP Simard
d768897f1d
Performance has gotten pretty bad for complex SwiftLint configurations like the one used for Lyft's iOS code base involving lots of files in the directories being linted, large configuration files and many nested configuration files. Two main areas were particularly ripe for improvement were: 1. Collecting which files to lint 2. Lint cache lookups ### Collecting which files to lint Improve this by: * using an NSOrderedSet to remove excluded paths instead of `Array.filter` * parallelizing calls to `filesToLint` for all paths to lint and exclude * using `FileManager.subpaths(atPath:)` instead of `enumerator(atPath:)` |Change|Before|After|Speed up| |-|-|-|-| |NSOrderedSet|2.438s|0.917s|2.659x| |Parallel Flat Map|2.438s|2.248s|1.085x| |Subpaths|0.939s|0.867s|1.083x| |**Total**|**2.438s**|**0.720s**|**3.386x**| ### Lint cache lookups By using an MD5 hash of the Configuration description from CryptoSwift as the cache key instead of instead the full description, we can drastically speed up cache lookups for projects with complex SwiftLint configurations. I think the dictionary lookup for very large string keys doesn't perform very well. --- * Speed up Configuration.lintablePaths * Improve cache lookup performance by up to 10x By using an MD5 hash of the Configuration description from CryptoSwift as the cache key instead of instead the full description. * Add changelog entries * Swift 4.0 & Linux compatibility * os(Darwin) isn't a thing * Allow warnings in pod lib lint SwiftLint supports building with Swift 4.0 to 4.2. There is no version of CryptoSwift to support both Swift 4.0 and Swift 4.2. So allow warnings for now. We'll make one more Swift 4.0 compatible release, then we'll bump the build requirements to Swift 4.2 and remove the `--allow-warnings` flag.
16 lines
787 B
Ruby
16 lines
787 B
Ruby
Pod::Spec.new do |s|
|
|
s.name = 'SwiftLintFramework'
|
|
s.version = `make get_version`
|
|
s.summary = 'A tool to enforce Swift style and conventions.'
|
|
s.homepage = 'https://github.com/realm/SwiftLint'
|
|
s.source = { :git => s.homepage + '.git', :tag => s.version }
|
|
s.license = { :type => 'MIT', :file => 'LICENSE' }
|
|
s.author = { 'JP Simard' => 'jp@jpsim.com' }
|
|
s.platform = :osx, '10.10'
|
|
s.source_files = 'Source/SwiftLintFramework/**/*.swift'
|
|
s.pod_target_xcconfig = { 'APPLICATION_EXTENSION_API_ONLY' => 'YES' }
|
|
s.dependency 'CryptoSwift', '0.8.3'
|
|
s.dependency 'SourceKittenFramework', '~> 0.21'
|
|
s.dependency 'Yams', '~> 1.0'
|
|
end
|