mirror of
https://github.com/realm/SwiftLint.git
synced 2026-05-07 20:12:49 +00:00
86d60400c1
Over the years, SwiftLintFramework had become a fairly massive monolith, containing over 400 source files with both core infrastructure and rules. Architecturally, the rules should rely on the core infrastructure but not the other way around. There are two exceptions to this: `custom_rules` and `superfluous_disable_command` which need special integration with the linter infrastructure. Now the time has come to formalize this architecture and one way to do that is to move the core SwiftLint functionality out of SwiftLintFramework and into a new SwiftLintCore module that the rules can depend on. Beyond enforcing architectural patterns, this also has the advantage of speeding up incremental compilation by skipping rebuilding the core functionality when iterating on rules. Because the core functionality is always useful when building rules, I'm opting to import SwiftLintCore in SwiftLintFramework as `@_exported` so that it's implicitly available to all files in SwiftLintFramework without needing to import it directly. In a follow-up I'll also split the built-in rules and the extra rules into their own modules. More modularization is possible from there, but not planned. The bulk of this PR just moves files from `Source/SwiftLintFramework/*` to `Source/SwiftLintCore/*`. There are some other changes that can't be split up into their own PRs: * Change jazzy to document the SwiftLintCore module instead of SwiftLintFramework. * Change imports in unit tests to reflect where code was moved to. * Update `sourcery` make rule to reflect where code was moved to. * Create a new `coreRules` array and register those rules with the registry. This allows the `custom_rules` and `superfluous_disable_command` rule implementations to remain internal to the SwiftLintCore module, preventing more implementation details from leaking across architectural layers. * Move `RuleRegistry.registerAllRulesOnce()` out of the type declaration and up one level so it can access rules defined downstream from SwiftLintCore.
298 lines
12 KiB
Swift
298 lines
12 KiB
Swift
import Foundation
|
|
import SourceKittenFramework
|
|
|
|
public func regex(_ pattern: String,
|
|
options: NSRegularExpression.Options? = nil) -> NSRegularExpression {
|
|
// all patterns used for regular expressions in SwiftLint are string literals which have been
|
|
// confirmed to work, so it's ok to force-try here.
|
|
|
|
let options = options ?? [.anchorsMatchLines, .dotMatchesLineSeparators]
|
|
// swiftlint:disable:next force_try
|
|
return try! .cached(pattern: pattern, options: options)
|
|
}
|
|
|
|
extension SwiftLintFile {
|
|
public func regions(restrictingRuleIdentifiers: Set<RuleIdentifier>? = nil) -> [Region] {
|
|
var regions = [Region]()
|
|
var disabledRules = Set<RuleIdentifier>()
|
|
let commands: [Command]
|
|
if let restrictingRuleIdentifiers {
|
|
commands = self.commands().filter { command in
|
|
return command.ruleIdentifiers.contains(where: restrictingRuleIdentifiers.contains)
|
|
}
|
|
} else {
|
|
commands = self.commands()
|
|
}
|
|
let commandPairs = zip(commands, Array(commands.dropFirst().map(Optional.init)) + [nil])
|
|
for (command, nextCommand) in commandPairs {
|
|
switch command.action {
|
|
case .disable:
|
|
disabledRules.formUnion(command.ruleIdentifiers)
|
|
|
|
case .enable:
|
|
disabledRules.subtract(command.ruleIdentifiers)
|
|
|
|
case .invalid:
|
|
break
|
|
}
|
|
|
|
let start = Location(file: path, line: command.line, character: command.character)
|
|
let end = endOf(next: nextCommand)
|
|
guard start < end else { continue }
|
|
var didSetRegion = false
|
|
for (index, region) in zip(regions.indices, regions) where region.start == start && region.end == end {
|
|
regions[index] = Region(
|
|
start: start,
|
|
end: end,
|
|
disabledRuleIdentifiers: disabledRules.union(region.disabledRuleIdentifiers)
|
|
)
|
|
didSetRegion = true
|
|
}
|
|
if !didSetRegion {
|
|
regions.append(
|
|
Region(start: start, end: end, disabledRuleIdentifiers: disabledRules)
|
|
)
|
|
}
|
|
}
|
|
return regions
|
|
}
|
|
|
|
public func commands(in range: NSRange? = nil) -> [Command] {
|
|
guard let range else {
|
|
return commands
|
|
.flatMap { $0.expand() }
|
|
}
|
|
|
|
let rangeStart = Location(file: self, characterOffset: range.location)
|
|
let rangeEnd = Location(file: self, characterOffset: NSMaxRange(range))
|
|
return commands
|
|
.filter { command in
|
|
let commandLocation = Location(file: path, line: command.line, character: command.character)
|
|
return rangeStart <= commandLocation && commandLocation <= rangeEnd
|
|
}
|
|
.flatMap { $0.expand() }
|
|
}
|
|
|
|
fileprivate func endOf(next command: Command?) -> Location {
|
|
guard let nextCommand = command else {
|
|
return Location(file: path, line: .max, character: .max)
|
|
}
|
|
let nextLine: Int
|
|
let nextCharacter: Int?
|
|
if let nextCommandCharacter = nextCommand.character {
|
|
nextLine = nextCommand.line
|
|
if nextCommandCharacter > 0 {
|
|
nextCharacter = nextCommandCharacter - 1
|
|
} else {
|
|
nextCharacter = nil
|
|
}
|
|
} else {
|
|
nextLine = max(nextCommand.line - 1, 0)
|
|
nextCharacter = .max
|
|
}
|
|
return Location(file: path, line: nextLine, character: nextCharacter)
|
|
}
|
|
|
|
public func match(pattern: String, with syntaxKinds: [SyntaxKind], range: NSRange? = nil) -> [NSRange] {
|
|
return match(pattern: pattern, range: range)
|
|
.filter { $0.1 == syntaxKinds }
|
|
.map { $0.0 }
|
|
}
|
|
|
|
public func matchesAndTokens(matching pattern: String,
|
|
range: NSRange? = nil) -> [(NSTextCheckingResult, [SwiftLintSyntaxToken])] {
|
|
let contents = stringView
|
|
let range = range ?? contents.range
|
|
let syntax = syntaxMap
|
|
return regex(pattern).matches(in: contents, options: [], range: range).compactMap { match in
|
|
let matchByteRange = contents.NSRangeToByteRange(start: match.range.location, length: match.range.length)
|
|
return matchByteRange.map { (match, syntax.tokens(inByteRange: $0)) }
|
|
}
|
|
}
|
|
|
|
public func matchesAndSyntaxKinds(matching pattern: String,
|
|
range: NSRange? = nil) -> [(NSTextCheckingResult, [SyntaxKind])] {
|
|
return matchesAndTokens(matching: pattern, range: range).map { textCheckingResult, tokens in
|
|
(textCheckingResult, tokens.kinds)
|
|
}
|
|
}
|
|
|
|
public func rangesAndTokens(matching pattern: String,
|
|
range: NSRange? = nil) -> [(NSRange, [SwiftLintSyntaxToken])] {
|
|
return matchesAndTokens(matching: pattern, range: range).map { ($0.0.range, $0.1) }
|
|
}
|
|
|
|
public func match(pattern: String, range: NSRange? = nil, captureGroup: Int = 0) -> [(NSRange, [SyntaxKind])] {
|
|
return matchesAndSyntaxKinds(matching: pattern, range: range).map { textCheckingResult, syntaxKinds in
|
|
(textCheckingResult.range(at: captureGroup), syntaxKinds)
|
|
}
|
|
}
|
|
|
|
public func swiftDeclarationKindsByLine() -> [[SwiftDeclarationKind]]? {
|
|
if sourcekitdFailed {
|
|
return nil
|
|
}
|
|
var results = [[SwiftDeclarationKind]](repeating: [], count: lines.count + 1)
|
|
var lineIterator = lines.makeIterator()
|
|
var structureIterator = structureDictionary.kinds().makeIterator()
|
|
var maybeLine = lineIterator.next()
|
|
var maybeStructure = structureIterator.next()
|
|
while let line = maybeLine, let structure = maybeStructure {
|
|
if line.byteRange.contains(structure.byteRange.location),
|
|
let swiftDeclarationKind = SwiftDeclarationKind(rawValue: structure.kind) {
|
|
results[line.index].append(swiftDeclarationKind)
|
|
}
|
|
if structure.byteRange.location >= line.byteRange.upperBound {
|
|
maybeLine = lineIterator.next()
|
|
} else {
|
|
maybeStructure = structureIterator.next()
|
|
}
|
|
}
|
|
return results
|
|
}
|
|
|
|
public func syntaxTokensByLine() -> [[SwiftLintSyntaxToken]]? {
|
|
if sourcekitdFailed {
|
|
return nil
|
|
}
|
|
var results = [[SwiftLintSyntaxToken]](repeating: [], count: lines.count + 1)
|
|
var tokenGenerator = syntaxMap.tokens.makeIterator()
|
|
var lineGenerator = lines.makeIterator()
|
|
var maybeLine = lineGenerator.next()
|
|
var maybeToken = tokenGenerator.next()
|
|
while let line = maybeLine, let token = maybeToken {
|
|
let tokenRange = token.range
|
|
if line.byteRange.contains(token.offset) ||
|
|
tokenRange.contains(line.byteRange.location) {
|
|
results[line.index].append(token)
|
|
}
|
|
let tokenEnd = tokenRange.upperBound
|
|
let lineEnd = line.byteRange.upperBound
|
|
if tokenEnd < lineEnd {
|
|
maybeToken = tokenGenerator.next()
|
|
} else if tokenEnd > lineEnd {
|
|
maybeLine = lineGenerator.next()
|
|
} else {
|
|
maybeLine = lineGenerator.next()
|
|
maybeToken = tokenGenerator.next()
|
|
}
|
|
}
|
|
return results
|
|
}
|
|
|
|
public func syntaxKindsByLine() -> [[SyntaxKind]]? {
|
|
guard !sourcekitdFailed, let tokens = syntaxTokensByLine() else {
|
|
return nil
|
|
}
|
|
|
|
return tokens.map { $0.kinds }
|
|
}
|
|
|
|
/**
|
|
This function returns only matches that are not contained in a syntax kind
|
|
specified.
|
|
|
|
- parameter pattern: regex pattern to be matched inside file.
|
|
- parameter excludingSyntaxKinds: syntax kinds the matches to be filtered
|
|
when inside them.
|
|
|
|
- returns: An array of [NSRange] objects consisting of regex matches inside
|
|
file contents.
|
|
*/
|
|
public func match(pattern: String,
|
|
excludingSyntaxKinds syntaxKinds: Set<SyntaxKind>,
|
|
range: NSRange? = nil,
|
|
captureGroup: Int = 0) -> [NSRange] {
|
|
return match(pattern: pattern, range: range, captureGroup: captureGroup)
|
|
.filter { syntaxKinds.isDisjoint(with: $0.1) }
|
|
.map { $0.0 }
|
|
}
|
|
|
|
public typealias MatchMapping = (NSTextCheckingResult) -> NSRange
|
|
|
|
public func match(pattern: String,
|
|
range: NSRange? = nil,
|
|
excludingSyntaxKinds: Set<SyntaxKind>,
|
|
excludingPattern: String,
|
|
exclusionMapping: MatchMapping = { $0.range }) -> [NSRange] {
|
|
let matches = match(pattern: pattern, excludingSyntaxKinds: excludingSyntaxKinds)
|
|
if matches.isEmpty {
|
|
return []
|
|
}
|
|
let range = range ?? stringView.range
|
|
let exclusionRanges = regex(excludingPattern).matches(in: stringView, options: [],
|
|
range: range).map(exclusionMapping)
|
|
return matches.filter { !$0.intersects(exclusionRanges) }
|
|
}
|
|
|
|
public func append(_ string: String) {
|
|
guard string.isNotEmpty else {
|
|
return
|
|
}
|
|
file.contents += string
|
|
if isVirtual {
|
|
return
|
|
}
|
|
guard let stringData = string.data(using: .utf8) else {
|
|
queuedFatalError("can't encode '\(string)' with UTF8")
|
|
}
|
|
guard let path, let fileHandle = FileHandle(forWritingAtPath: path) else {
|
|
queuedFatalError("can't write to path '\(String(describing: self.path))'")
|
|
}
|
|
_ = fileHandle.seekToEndOfFile()
|
|
fileHandle.write(stringData)
|
|
fileHandle.closeFile()
|
|
invalidateCache()
|
|
}
|
|
|
|
public func write<S: StringProtocol>(_ string: S) {
|
|
guard string != contents else {
|
|
return
|
|
}
|
|
file.contents = String(string)
|
|
if isVirtual {
|
|
return
|
|
}
|
|
guard let path else {
|
|
queuedFatalError("file needs a path to call write(_:)")
|
|
}
|
|
guard let stringData = String(string).data(using: .utf8) else {
|
|
queuedFatalError("can't encode '\(string)' with UTF8")
|
|
}
|
|
do {
|
|
try stringData.write(to: URL(fileURLWithPath: path, isDirectory: false), options: .atomic)
|
|
} catch {
|
|
queuedFatalError("can't write file to \(path)")
|
|
}
|
|
invalidateCache()
|
|
}
|
|
|
|
public func ruleEnabled(violatingRanges: [NSRange], for rule: Rule) -> [NSRange] {
|
|
let fileRegions = regions()
|
|
if fileRegions.isEmpty { return violatingRanges }
|
|
return violatingRanges.filter { range in
|
|
let region = fileRegions.first {
|
|
$0.contains(Location(file: self, characterOffset: range.location))
|
|
}
|
|
return region?.isRuleEnabled(rule) ?? true
|
|
}
|
|
}
|
|
|
|
public func ruleEnabled(violatingRange: NSRange, for rule: Rule) -> NSRange? {
|
|
return ruleEnabled(violatingRanges: [violatingRange], for: rule).first
|
|
}
|
|
|
|
public func isACL(token: SwiftLintSyntaxToken) -> Bool {
|
|
guard token.kind == .attributeBuiltin else {
|
|
return false
|
|
}
|
|
|
|
let aclString = contents(for: token)
|
|
return aclString.flatMap(AccessControlLevel.init(description:)) != nil
|
|
}
|
|
|
|
public func contents(for token: SwiftLintSyntaxToken) -> String? {
|
|
return stringView.substringWithByteRange(token.range)
|
|
}
|
|
}
|