mirror of
https://github.com/realm/SwiftLint.git
synced 2026-05-07 20:12:49 +00:00
86d60400c1
Over the years, SwiftLintFramework had become a fairly massive monolith, containing over 400 source files with both core infrastructure and rules. Architecturally, the rules should rely on the core infrastructure but not the other way around. There are two exceptions to this: `custom_rules` and `superfluous_disable_command` which need special integration with the linter infrastructure. Now the time has come to formalize this architecture and one way to do that is to move the core SwiftLint functionality out of SwiftLintFramework and into a new SwiftLintCore module that the rules can depend on. Beyond enforcing architectural patterns, this also has the advantage of speeding up incremental compilation by skipping rebuilding the core functionality when iterating on rules. Because the core functionality is always useful when building rules, I'm opting to import SwiftLintCore in SwiftLintFramework as `@_exported` so that it's implicitly available to all files in SwiftLintFramework without needing to import it directly. In a follow-up I'll also split the built-in rules and the extra rules into their own modules. More modularization is possible from there, but not planned. The bulk of this PR just moves files from `Source/SwiftLintFramework/*` to `Source/SwiftLintCore/*`. There are some other changes that can't be split up into their own PRs: * Change jazzy to document the SwiftLintCore module instead of SwiftLintFramework. * Change imports in unit tests to reflect where code was moved to. * Update `sourcery` make rule to reflect where code was moved to. * Create a new `coreRules` array and register those rules with the registry. This allows the `custom_rules` and `superfluous_disable_command` rule implementations to remain internal to the SwiftLintCore module, preventing more implementation details from leaking across architectural layers. * Move `RuleRegistry.registerAllRulesOnce()` out of the type declaration and up one level so it can access rules defined downstream from SwiftLintCore.
123 lines
4.1 KiB
Swift
123 lines
4.1 KiB
Swift
import Foundation
|
|
import SourceKittenFramework
|
|
|
|
public extension String {
|
|
func hasTrailingWhitespace() -> Bool {
|
|
if isEmpty {
|
|
return false
|
|
}
|
|
|
|
if let unicodescalar = unicodeScalars.last {
|
|
return CharacterSet.whitespaces.contains(unicodescalar)
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
func isUppercase() -> Bool {
|
|
return self == uppercased()
|
|
}
|
|
|
|
func isLowercase() -> Bool {
|
|
return self == lowercased()
|
|
}
|
|
|
|
private subscript (range: Range<Int>) -> String {
|
|
let nsrange = NSRange(location: range.lowerBound,
|
|
length: range.upperBound - range.lowerBound)
|
|
if let indexRange = nsrangeToIndexRange(nsrange) {
|
|
return String(self[indexRange])
|
|
}
|
|
queuedFatalError("invalid range")
|
|
}
|
|
|
|
func substring(from: Int, length: Int? = nil) -> String {
|
|
if let length {
|
|
return self[from..<from + length]
|
|
}
|
|
return String(self[index(startIndex, offsetBy: from, limitedBy: endIndex)!...])
|
|
}
|
|
|
|
func lastIndex(of search: String) -> Int? {
|
|
if let range = range(of: search, options: [.literal, .backwards]) {
|
|
return distance(from: startIndex, to: range.lowerBound)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func nsrangeToIndexRange(_ nsrange: NSRange) -> Range<Index>? {
|
|
guard nsrange.location != NSNotFound else {
|
|
return nil
|
|
}
|
|
let from16 = utf16.index(utf16.startIndex, offsetBy: nsrange.location,
|
|
limitedBy: utf16.endIndex) ?? utf16.endIndex
|
|
let to16 = utf16.index(from16, offsetBy: nsrange.length,
|
|
limitedBy: utf16.endIndex) ?? utf16.endIndex
|
|
|
|
guard let fromIndex = Index(from16, within: self),
|
|
let toIndex = Index(to16, within: self) else {
|
|
return nil
|
|
}
|
|
|
|
return fromIndex..<toIndex
|
|
}
|
|
|
|
var fullNSRange: NSRange {
|
|
return NSRange(location: 0, length: utf16.count)
|
|
}
|
|
|
|
/// Returns a new string, converting the path to a canonical absolute path.
|
|
///
|
|
/// - returns: A new `String`.
|
|
func absolutePathStandardized() -> String {
|
|
return bridge().absolutePathRepresentation().bridge().standardizingPath
|
|
}
|
|
|
|
var isFile: Bool {
|
|
if self.isEmpty {
|
|
return false
|
|
}
|
|
var isDirectoryObjC: ObjCBool = false
|
|
if FileManager.default.fileExists(atPath: self, isDirectory: &isDirectoryObjC) {
|
|
return !isDirectoryObjC.boolValue
|
|
}
|
|
return false
|
|
}
|
|
|
|
/// Count the number of occurrences of the given character in `self`
|
|
/// - Parameter character: Character to count
|
|
/// - Returns: Number of times `character` occurs in `self`
|
|
func countOccurrences(of character: Character) -> Int {
|
|
return self.reduce(0, {
|
|
$1 == character ? $0 + 1 : $0
|
|
})
|
|
}
|
|
|
|
/// If self is a path, this method can be used to get a path expression relative to a root directory
|
|
func path(relativeTo rootDirectory: String) -> String {
|
|
let normalizedRootDir = rootDirectory.bridge().standardizingPath
|
|
let normalizedSelf = bridge().standardizingPath
|
|
if normalizedRootDir.isEmpty {
|
|
return normalizedSelf
|
|
}
|
|
var rootDirComps = normalizedRootDir.components(separatedBy: "/")
|
|
let rootDirCompsCount = rootDirComps.count
|
|
|
|
while true {
|
|
let sharedRootDir = rootDirComps.joined(separator: "/")
|
|
if normalizedSelf == sharedRootDir || normalizedSelf.hasPrefix(sharedRootDir + "/") {
|
|
let path = (0 ..< rootDirCompsCount - rootDirComps.count).map { _ in "/.." }.flatMap { $0 }
|
|
+ String(normalizedSelf.dropFirst(sharedRootDir.count))
|
|
return String(path.dropFirst()) // Remove leading '/'
|
|
} else {
|
|
rootDirComps = rootDirComps.dropLast()
|
|
}
|
|
}
|
|
}
|
|
|
|
func deletingPrefix(_ prefix: String) -> String {
|
|
guard hasPrefix(prefix) else { return self }
|
|
return String(dropFirst(prefix.count))
|
|
}
|
|
}
|