mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
Over the years, SwiftLintFramework had become a fairly massive monolith, containing over 400 source files with both core infrastructure and rules. Architecturally, the rules should rely on the core infrastructure but not the other way around. There are two exceptions to this: `custom_rules` and `superfluous_disable_command` which need special integration with the linter infrastructure. Now the time has come to formalize this architecture and one way to do that is to move the core SwiftLint functionality out of SwiftLintFramework and into a new SwiftLintCore module that the rules can depend on. Beyond enforcing architectural patterns, this also has the advantage of speeding up incremental compilation by skipping rebuilding the core functionality when iterating on rules. Because the core functionality is always useful when building rules, I'm opting to import SwiftLintCore in SwiftLintFramework as `@_exported` so that it's implicitly available to all files in SwiftLintFramework without needing to import it directly. In a follow-up I'll also split the built-in rules and the extra rules into their own modules. More modularization is possible from there, but not planned. The bulk of this PR just moves files from `Source/SwiftLintFramework/*` to `Source/SwiftLintCore/*`. There are some other changes that can't be split up into their own PRs: * Change jazzy to document the SwiftLintCore module instead of SwiftLintFramework. * Change imports in unit tests to reflect where code was moved to. * Update `sourcery` make rule to reflect where code was moved to. * Create a new `coreRules` array and register those rules with the registry. This allows the `custom_rules` and `superfluous_disable_command` rule implementations to remain internal to the SwiftLintCore module, preventing more implementation details from leaking across architectural layers. * Move `RuleRegistry.registerAllRulesOnce()` out of the type declaration and up one level so it can access rules defined downstream from SwiftLintCore.
106 lines
4.1 KiB
Swift
106 lines
4.1 KiB
Swift
import Foundation
|
|
import SourceKittenFramework
|
|
import SwiftSyntax
|
|
|
|
/// The placement of a segment of Swift in a collection of source files.
|
|
public struct Location: CustomStringConvertible, Comparable, Codable {
|
|
/// The file path on disk for this location.
|
|
public let file: String?
|
|
/// The line offset in the file for this location. 1-indexed.
|
|
public let line: Int?
|
|
/// The character offset in the file for this location. 1-indexed.
|
|
public let character: Int?
|
|
|
|
/// A lossless printable description of this location.
|
|
public var description: String {
|
|
// Xcode likes warnings and errors in the following format:
|
|
// {full_path_to_file}{:line}{:character}: {error,warning}: {content}
|
|
let fileString: String = file ?? "<nopath>"
|
|
let lineString: String = ":\(line ?? 1)"
|
|
let charString: String = ":\(character ?? 1)"
|
|
return [fileString, lineString, charString].joined()
|
|
}
|
|
|
|
/// The file path for this location relative to the current working directory.
|
|
public var relativeFile: String? {
|
|
return file?.replacingOccurrences(of: FileManager.default.currentDirectoryPath + "/", with: "")
|
|
}
|
|
|
|
/// Creates a `Location` by specifying its properties directly.
|
|
///
|
|
/// - parameter file: The file path on disk for this location.
|
|
/// - parameter line: The line offset in the file for this location. 1-indexed.
|
|
/// - parameter character: The character offset in the file for this location. 1-indexed.
|
|
public init(file: String?, line: Int? = nil, character: Int? = nil) {
|
|
self.file = file
|
|
self.line = line
|
|
self.character = character
|
|
}
|
|
|
|
/// Creates a `Location` based on a `SwiftLintFile` and a byte-offset into the file.
|
|
/// Fails if the specified offset was not a valid location in the file.
|
|
///
|
|
/// - parameter file: The file for this location.
|
|
/// - parameter offset: The offset in bytes into the file for this location.
|
|
public init(file: SwiftLintFile, byteOffset offset: ByteCount) {
|
|
self.file = file.path
|
|
if let lineAndCharacter = file.stringView.lineAndCharacter(forByteOffset: offset) {
|
|
line = lineAndCharacter.line
|
|
character = lineAndCharacter.character
|
|
} else {
|
|
line = nil
|
|
character = nil
|
|
}
|
|
}
|
|
|
|
/// Creates a `Location` based on a `SwiftLintFile` and a SwiftSyntax `AbsolutePosition` into the file.
|
|
/// Fails if the specified offset was not a valid location in the file.
|
|
///
|
|
/// - parameter file: The file for this location.
|
|
/// - parameter position: The absolute position returned from SwiftSyntax.
|
|
public init(file: SwiftLintFile, position: AbsolutePosition) {
|
|
self.init(file: file, byteOffset: ByteCount(position.utf8Offset))
|
|
}
|
|
|
|
/// Creates a `Location` based on a `SwiftLintFile` and a UTF8 character-offset into the file.
|
|
/// Fails if the specified offset was not a valid location in the file.
|
|
///
|
|
/// - parameter file: The file for this location.
|
|
/// - parameter offset: The offset in UTF8 fragments into the file for this location.
|
|
public init(file: SwiftLintFile, characterOffset offset: Int) {
|
|
self.file = file.path
|
|
if let lineAndCharacter = file.stringView.lineAndCharacter(forCharacterOffset: offset) {
|
|
line = lineAndCharacter.line
|
|
character = lineAndCharacter.character
|
|
} else {
|
|
line = nil
|
|
character = nil
|
|
}
|
|
}
|
|
|
|
// MARK: Comparable
|
|
|
|
public static func < (lhs: Location, rhs: Location) -> Bool {
|
|
if lhs.file != rhs.file {
|
|
return lhs.file < rhs.file
|
|
}
|
|
if lhs.line != rhs.line {
|
|
return lhs.line < rhs.line
|
|
}
|
|
return lhs.character < rhs.character
|
|
}
|
|
}
|
|
|
|
private extension Optional where Wrapped: Comparable {
|
|
static func < (lhs: Optional, rhs: Optional) -> Bool {
|
|
switch (lhs, rhs) {
|
|
case let (lhs?, rhs?):
|
|
return lhs < rhs
|
|
case (nil, _?):
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
}
|