mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
Over the years, SwiftLintFramework had become a fairly massive monolith, containing over 400 source files with both core infrastructure and rules. Architecturally, the rules should rely on the core infrastructure but not the other way around. There are two exceptions to this: `custom_rules` and `superfluous_disable_command` which need special integration with the linter infrastructure. Now the time has come to formalize this architecture and one way to do that is to move the core SwiftLint functionality out of SwiftLintFramework and into a new SwiftLintCore module that the rules can depend on. Beyond enforcing architectural patterns, this also has the advantage of speeding up incremental compilation by skipping rebuilding the core functionality when iterating on rules. Because the core functionality is always useful when building rules, I'm opting to import SwiftLintCore in SwiftLintFramework as `@_exported` so that it's implicitly available to all files in SwiftLintFramework without needing to import it directly. In a follow-up I'll also split the built-in rules and the extra rules into their own modules. More modularization is possible from there, but not planned. The bulk of this PR just moves files from `Source/SwiftLintFramework/*` to `Source/SwiftLintCore/*`. There are some other changes that can't be split up into their own PRs: * Change jazzy to document the SwiftLintCore module instead of SwiftLintFramework. * Change imports in unit tests to reflect where code was moved to. * Update `sourcery` make rule to reflect where code was moved to. * Create a new `coreRules` array and register those rules with the registry. This allows the `custom_rules` and `superfluous_disable_command` rule implementations to remain internal to the SwiftLintCore module, preventing more implementation details from leaking across architectural layers. * Move `RuleRegistry.registerAllRulesOnce()` out of the type declaration and up one level so it can access rules defined downstream from SwiftLintCore.
243 lines
9.1 KiB
Swift
243 lines
9.1 KiB
Swift
import SourceKittenFramework
|
|
|
|
/// A collection of keys and values as parsed out of SourceKit, with many conveniences for accessing SwiftLint-specific
|
|
/// values.
|
|
public struct SourceKittenDictionary {
|
|
/// The underlying SourceKitten dictionary.
|
|
public let value: [String: SourceKitRepresentable]
|
|
/// The cached substructure for this dictionary. Empty if there is no substructure.
|
|
public let substructure: [SourceKittenDictionary]
|
|
|
|
/// The kind of Swift expression represented by this dictionary, if it is an expression.
|
|
public let expressionKind: SwiftExpressionKind?
|
|
/// The kind of Swift declaration represented by this dictionary, if it is a declaration.
|
|
public let declarationKind: SwiftDeclarationKind?
|
|
/// The kind of Swift statement represented by this dictionary, if it is a statement.
|
|
public let statementKind: StatementKind?
|
|
|
|
/// The accessibility level for this dictionary, if it is a declaration.
|
|
public let accessibility: AccessControlLevel?
|
|
|
|
/// Creates a SourceKitten dictionary given a `Dictionary<String, SourceKitRepresentable>` input.
|
|
///
|
|
/// - parameter value: The input dictionary/
|
|
public init(_ value: [String: SourceKitRepresentable]) {
|
|
self.value = value
|
|
|
|
let substructure = value["key.substructure"] as? [SourceKitRepresentable] ?? []
|
|
self.substructure = substructure.compactMap { $0 as? [String: SourceKitRepresentable] }
|
|
.map(Self.init)
|
|
|
|
let stringKind = value["key.kind"] as? String
|
|
self.expressionKind = stringKind.flatMap(SwiftExpressionKind.init)
|
|
self.declarationKind = stringKind.flatMap(SwiftDeclarationKind.init)
|
|
self.statementKind = stringKind.flatMap(StatementKind.init)
|
|
|
|
self.accessibility = (value["key.accessibility"] as? String).flatMap(AccessControlLevel.init(identifier:))
|
|
}
|
|
|
|
/// Body length
|
|
public var bodyLength: ByteCount? {
|
|
return (value["key.bodylength"] as? Int64).map(ByteCount.init)
|
|
}
|
|
|
|
/// Body offset.
|
|
public var bodyOffset: ByteCount? {
|
|
return (value["key.bodyoffset"] as? Int64).map(ByteCount.init)
|
|
}
|
|
|
|
/// Body byte range.
|
|
public var bodyByteRange: ByteRange? {
|
|
guard let offset = bodyOffset, let length = bodyLength else { return nil }
|
|
return ByteRange(location: offset, length: length)
|
|
}
|
|
|
|
/// Kind.
|
|
public var kind: String? {
|
|
return value["key.kind"] as? String
|
|
}
|
|
|
|
/// Length.
|
|
public var length: ByteCount? {
|
|
return (value["key.length"] as? Int64).map(ByteCount.init)
|
|
}
|
|
/// Name.
|
|
public var name: String? {
|
|
return value["key.name"] as? String
|
|
}
|
|
|
|
/// Name length.
|
|
public var nameLength: ByteCount? {
|
|
return (value["key.namelength"] as? Int64).map(ByteCount.init)
|
|
}
|
|
|
|
/// Name offset.
|
|
public var nameOffset: ByteCount? {
|
|
return (value["key.nameoffset"] as? Int64).map(ByteCount.init)
|
|
}
|
|
|
|
/// Byte range of name.
|
|
public var nameByteRange: ByteRange? {
|
|
guard let offset = nameOffset, let length = nameLength else { return nil }
|
|
return ByteRange(location: offset, length: length)
|
|
}
|
|
|
|
/// Offset.
|
|
public var offset: ByteCount? {
|
|
return (value["key.offset"] as? Int64).map(ByteCount.init)
|
|
}
|
|
|
|
/// Returns byte range starting from `offset` with `length` bytes
|
|
public var byteRange: ByteRange? {
|
|
guard let offset, let length else { return nil }
|
|
return ByteRange(location: offset, length: length)
|
|
}
|
|
|
|
/// Setter accessibility.
|
|
public var setterAccessibility: String? {
|
|
return value["key.setter_accessibility"] as? String
|
|
}
|
|
|
|
/// Type name.
|
|
public var typeName: String? {
|
|
return value["key.typename"] as? String
|
|
}
|
|
|
|
/// Documentation length.
|
|
public var docLength: ByteCount? {
|
|
return (value["key.doclength"] as? Int64).flatMap(ByteCount.init)
|
|
}
|
|
|
|
/// The attribute for this dictionary, as returned by SourceKit.
|
|
public var attribute: String? {
|
|
return value["key.attribute"] as? String
|
|
}
|
|
|
|
/// Module name in `@import` expressions.
|
|
public var moduleName: String? {
|
|
return value["key.modulename"] as? String
|
|
}
|
|
|
|
/// The line number for this declaration.
|
|
public var line: Int64? {
|
|
return value["key.line"] as? Int64
|
|
}
|
|
|
|
/// The column number for this declaration.
|
|
public var column: Int64? {
|
|
return value["key.column"] as? Int64
|
|
}
|
|
|
|
/// The `SwiftDeclarationAttributeKind` values associated with this dictionary.
|
|
public var enclosedSwiftAttributes: [SwiftDeclarationAttributeKind] {
|
|
return swiftAttributes.compactMap { $0.attribute }
|
|
.compactMap(SwiftDeclarationAttributeKind.init(rawValue:))
|
|
}
|
|
|
|
/// The fully preserved SourceKitten dictionaries for all the attributes associated with this dictionary.
|
|
public var swiftAttributes: [SourceKittenDictionary] {
|
|
let array = value["key.attributes"] as? [SourceKitRepresentable] ?? []
|
|
return array.compactMap { $0 as? [String: SourceKitRepresentable] }
|
|
.map(Self.init)
|
|
}
|
|
|
|
public var elements: [SourceKittenDictionary] {
|
|
let elements = value["key.elements"] as? [SourceKitRepresentable] ?? []
|
|
return elements.compactMap { $0 as? [String: SourceKitRepresentable] }
|
|
.map(Self.init)
|
|
}
|
|
|
|
public var entities: [SourceKittenDictionary] {
|
|
let entities = value["key.entities"] as? [SourceKitRepresentable] ?? []
|
|
return entities.compactMap { $0 as? [String: SourceKitRepresentable] }
|
|
.map(Self.init)
|
|
}
|
|
|
|
public var enclosedVarParameters: [SourceKittenDictionary] {
|
|
return substructure.flatMap { subDict -> [SourceKittenDictionary] in
|
|
if subDict.declarationKind == .varParameter {
|
|
return [subDict]
|
|
} else if subDict.expressionKind == .argument ||
|
|
subDict.expressionKind == .closure {
|
|
return subDict.enclosedVarParameters
|
|
}
|
|
|
|
return []
|
|
}
|
|
}
|
|
|
|
public var enclosedArguments: [SourceKittenDictionary] {
|
|
return substructure.flatMap { subDict -> [SourceKittenDictionary] in
|
|
guard subDict.expressionKind == .argument else {
|
|
return []
|
|
}
|
|
|
|
return [subDict]
|
|
}
|
|
}
|
|
|
|
public var inheritedTypes: [String] {
|
|
let array = value["key.inheritedtypes"] as? [SourceKitRepresentable] ?? []
|
|
return array.compactMap { ($0 as? [String: String]).flatMap { $0["key.name"] } }
|
|
}
|
|
}
|
|
|
|
extension SourceKittenDictionary {
|
|
/// Traversing all substuctures of the dictionary hierarchically, calling `traverseBlock` on each node.
|
|
/// Traversing using depth first strategy, so deepest substructures will be passed to `traverseBlock` first.
|
|
///
|
|
/// - parameter traverseBlock: block that will be called for each substructure in the dictionary.
|
|
///
|
|
/// - returns: The list of substructure dictionaries with updated values from the traverse block.
|
|
public func traverseDepthFirst<T>(traverseBlock: (SourceKittenDictionary) -> [T]?) -> [T] {
|
|
var result: [T] = []
|
|
traverseDepthFirst(collectingValuesInto: &result, traverseBlock: traverseBlock)
|
|
return result
|
|
}
|
|
|
|
private func traverseDepthFirst<T>(collectingValuesInto array: inout [T],
|
|
traverseBlock: (SourceKittenDictionary) -> [T]?) {
|
|
substructure.forEach { subDict in
|
|
subDict.traverseDepthFirst(collectingValuesInto: &array, traverseBlock: traverseBlock)
|
|
|
|
if let collectedValues = traverseBlock(subDict) {
|
|
array += collectedValues
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Traversing all entities of the dictionary hierarchically, calling `traverseBlock` on each node.
|
|
/// Traversing using depth first strategy, so deepest substructures will be passed to `traverseBlock` first.
|
|
///
|
|
/// - parameter traverseBlock: block that will be called for each entity in the dictionary.
|
|
///
|
|
/// - returns: The list of entity dictionaries with updated values from the traverse block.
|
|
public func traverseEntitiesDepthFirst<T>(traverseBlock: (SourceKittenDictionary) -> T?) -> [T] {
|
|
var result: [T] = []
|
|
traverseEntitiesDepthFirst(collectingValuesInto: &result, traverseBlock: traverseBlock)
|
|
return result
|
|
}
|
|
|
|
private func traverseEntitiesDepthFirst<T>(collectingValuesInto array: inout [T],
|
|
traverseBlock: (SourceKittenDictionary) -> T?) {
|
|
entities.forEach { subDict in
|
|
subDict.traverseEntitiesDepthFirst(collectingValuesInto: &array, traverseBlock: traverseBlock)
|
|
|
|
if let collectedValue = traverseBlock(subDict) {
|
|
array.append(collectedValue)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
public extension Dictionary where Key == Example {
|
|
/// Returns a dictionary with SwiftLint violation markers (↓) removed from keys.
|
|
///
|
|
/// - returns: A new `Dictionary`.
|
|
func removingViolationMarkers() -> [Key: Value] {
|
|
return Dictionary(uniqueKeysWithValues: map { key, value in
|
|
return (key.removingViolationMarkers(), value)
|
|
})
|
|
}
|
|
}
|