Files
SwiftLint/Source/SwiftLintFramework/Rules/Style/RedundantDiscardableLetRule.swift
T
Zev Eisenberg fcf848608e Add Inline test failure messages (#3040)
* Add Example wrapper in order to display test failures inline when running in Xcode.
* Stop using Swift 5.1-only features so we can compile on Xcode 10.2.
* Wrap strings in Example.
* Add Changelog entry.
* Wrap all examples in Example struct.
* Better and more complete capturing of line numbers.
* Fix broken test.
* Better test traceability.
* Address or disable linting warnings.
* Add documentation comments.
* Disable linter for a few cases.
* Limit mutability and add copy-and-mutate utility functions.
* Limit scope of mutability.
2020-02-02 10:35:37 +02:00

91 lines
3.7 KiB
Swift

import Foundation
import SourceKittenFramework
public struct RedundantDiscardableLetRule: SubstitutionCorrectableRule, ConfigurationProviderRule,
AutomaticTestableRule {
public var configuration = SeverityConfiguration(.warning)
public init() {}
public static let description = RuleDescription(
identifier: "redundant_discardable_let",
name: "Redundant Discardable Let",
description: "Prefer `_ = foo()` over `let _ = foo()` when discarding a result from a function.",
kind: .style,
nonTriggeringExamples: [
Example("_ = foo()\n"),
Example("if let _ = foo() { }\n"),
Example("guard let _ = foo() else { return }\n"),
Example("let _: ExplicitType = foo()"),
Example("while let _ = SplashStyle(rawValue: maxValue) { maxValue += 1 }\n")
],
triggeringExamples: [
Example("↓let _ = foo()\n"),
Example("if _ = foo() { ↓let _ = bar() }\n")
],
corrections: [
Example("↓let _ = foo()\n"): Example("_ = foo()\n"),
Example("if _ = foo() { ↓let _ = bar() }\n"): Example("if _ = foo() { _ = bar() }\n")
]
)
public func validate(file: SwiftLintFile) -> [StyleViolation] {
return violationRanges(in: file).map {
StyleViolation(ruleDescription: type(of: self).description,
severity: configuration.severity,
location: Location(file: file, characterOffset: $0.location))
}
}
public func substitution(for violationRange: NSRange, in file: SwiftLintFile) -> (NSRange, String)? {
return (violationRange, "_")
}
public func violationRanges(in file: SwiftLintFile) -> [NSRange] {
let contents = file.stringView
return file.match(pattern: "let\\s+_\\b", with: [.keyword, .keyword]).filter { range in
guard let byteRange = contents.NSRangeToByteRange(start: range.location, length: range.length) else {
return false
}
return !isInBooleanCondition(byteOffset: byteRange.location,
dictionary: file.structureDictionary)
&& !hasExplicitType(utf16Range: range.location ..< range.location + range.length,
fileContents: contents.nsString)
}
}
private func isInBooleanCondition(byteOffset: ByteCount, dictionary: SourceKittenDictionary) -> Bool {
guard let byteRange = dictionary.byteRange, byteRange.contains(byteOffset) else {
return false
}
let kinds: Set<StatementKind> = [.if, .guard, .while]
if let kind = dictionary.statementKind, kinds.contains(kind) {
let conditionKind = "source.lang.swift.structure.elem.condition_expr"
for element in dictionary.elements where element.kind == conditionKind {
guard let elementRange = element.byteRange, elementRange.contains(byteOffset) else {
continue
}
return true
}
}
for subDict in dictionary.substructure where
isInBooleanCondition(byteOffset: byteOffset, dictionary: subDict) {
return true
}
return false
}
private func hasExplicitType(utf16Range: Range<Int>, fileContents: NSString) -> Bool {
guard utf16Range.upperBound != fileContents.length else {
return false
}
let nextUTF16Unit = fileContents.substring(with: NSRange(location: utf16Range.upperBound, length: 1))
return nextUTF16Unit == ":"
}
}