mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
fcf848608e
* Add Example wrapper in order to display test failures inline when running in Xcode. * Stop using Swift 5.1-only features so we can compile on Xcode 10.2. * Wrap strings in Example. * Add Changelog entry. * Wrap all examples in Example struct. * Better and more complete capturing of line numbers. * Fix broken test. * Better test traceability. * Address or disable linting warnings. * Add documentation comments. * Disable linter for a few cases. * Limit mutability and add copy-and-mutate utility functions. * Limit scope of mutability.
55 lines
2.3 KiB
Swift
55 lines
2.3 KiB
Swift
import Foundation
|
|
import SourceKittenFramework
|
|
|
|
public struct ToggleBoolRule: SubstitutionCorrectableRule, ConfigurationProviderRule, OptInRule, AutomaticTestableRule {
|
|
public var configuration = SeverityConfiguration(.warning)
|
|
|
|
public init() {}
|
|
|
|
public static var description = RuleDescription(
|
|
identifier: "toggle_bool",
|
|
name: "Toggle Bool",
|
|
description: "Prefer `someBool.toggle()` over `someBool = !someBool`.",
|
|
kind: .idiomatic,
|
|
minSwiftVersion: .fourDotTwo,
|
|
nonTriggeringExamples: [
|
|
Example("isHidden.toggle()\n"),
|
|
Example("view.clipsToBounds.toggle()\n"),
|
|
Example("func foo() { abc.toggle() }"),
|
|
Example("view.clipsToBounds = !clipsToBounds\n"),
|
|
Example("disconnected = !connected\n")
|
|
],
|
|
triggeringExamples: [
|
|
Example("↓isHidden = !isHidden\n"),
|
|
Example("↓view.clipsToBounds = !view.clipsToBounds\n"),
|
|
Example("func foo() { ↓abc = !abc }")
|
|
],
|
|
corrections: [
|
|
Example("↓isHidden = !isHidden\n"): Example("isHidden.toggle()\n"),
|
|
Example("↓view.clipsToBounds = !view.clipsToBounds\n"): Example("view.clipsToBounds.toggle()\n"),
|
|
Example("func foo() { ↓abc = !abc }"): Example("func foo() { abc.toggle() }")
|
|
]
|
|
)
|
|
|
|
public func validate(file: SwiftLintFile) -> [StyleViolation] {
|
|
return violationRanges(in: file).map {
|
|
StyleViolation(ruleDescription: ToggleBoolRule.description,
|
|
severity: configuration.severity,
|
|
location: Location(file: file, characterOffset: $0.location)
|
|
)
|
|
}
|
|
}
|
|
|
|
public func violationRanges(in file: SwiftLintFile) -> [NSRange] {
|
|
let pattern = "(?<![\\w.])([\\w.]+) = !\\1\\b"
|
|
let excludingKinds = SyntaxKind.commentAndStringKinds
|
|
return file.match(pattern: pattern, excludingSyntaxKinds: excludingKinds)
|
|
}
|
|
|
|
public func substitution(for violationRange: NSRange, in file: SwiftLintFile) -> (NSRange, String)? {
|
|
let violationString = file.stringView.substring(with: violationRange)
|
|
let identifier = violationString.components(separatedBy: .whitespaces).first { !$0.isEmpty }
|
|
return (violationRange, identifier! + ".toggle()")
|
|
}
|
|
}
|