Files
SwiftLint/Source/SwiftLintFramework/Rules/OverriddenSuperCallRule.swift
T
2016-11-25 11:47:35 -08:00

113 lines
4.5 KiB
Swift

//
// OverriddenSuperCallRule.swift
// SwiftLint
//
// Created by Angel Garcia on 04/09/16.
// Copyright © 2016 Realm. All rights reserved.
//
import SourceKittenFramework
public struct OverriddenSuperCallRule: ConfigurationProviderRule, ASTRule, OptInRule {
public var configuration = OverridenSuperCallConfiguration()
public init() { }
public static let description = RuleDescription(
identifier: "overridden_super_call",
name: "Overridden methods call super",
description: "Some overridden methods should always call super",
nonTriggeringExamples: [
"class VC: UIViewController {\n" +
"\toverride func viewWillAppear(_ animated: Bool) {\n" +
"\t\tsuper.viewWillAppear(animated)\n" +
"\t}\n" +
"}\n",
"class VC: UIViewController {\n" +
"\toverride func viewWillAppear(_ animated: Bool) {\n" +
"\t\tself.method1()\n" +
"\t\tsuper.viewWillAppear(animated)\n" +
"\t\tself.method2()\n" +
"\t}\n" +
"}\n",
"class VC: UIViewController {\n" +
"\toverride func loadView() {\n" +
"\t}\n" +
"}\n",
"class Some {\n" +
"\tfunc viewWillAppear(_ animated: Bool) {\n" +
"\t}\n" +
"}\n"
],
triggeringExamples: [
"class VC: UIViewController {\n" +
"\toverride func viewWillAppear(_ animated: Bool) ↓{\n" +
"\t\t//Not calling to super\n" +
"\t\tself.method()\n" +
"\t}\n" +
"}\n",
"class VC: UIViewController {\n" +
"\toverride func viewWillAppear(_ animated: Bool) ↓{\n" +
"\t\tsuper.viewWillAppear(animated)\n" +
"\t\t//Other code\n" +
"\t\tsuper.viewWillAppear(animated)\n" +
"\t}\n" +
"}\n",
"class VC: UIViewController {\n" +
"\toverride func didReceiveMemoryWarning() ↓{\n" +
"\t}\n" +
"}\n"
]
)
public func validateFile(file: File,
kind: SwiftDeclarationKind,
dictionary: [String: SourceKitRepresentable]) -> [StyleViolation] {
guard let offset = dictionary["key.bodyoffset"] as? Int64,
let name = dictionary["key.name"] as? String
else { return [] }
let substructure = (dictionary["key.substructure"] as? [SourceKitRepresentable]) ?? []
guard kind == .FunctionMethodInstance &&
configuration.resolvedMethodNames.contains(name) &&
extractAttributes(dictionary).contains("source.decl.attribute.override")
else { return [] }
let callsToSuper = extractCallsToSuper(name, substructure: substructure)
if callsToSuper.isEmpty {
return [StyleViolation(ruleDescription: self.dynamicType.description,
severity: configuration.severity,
location: Location(file: file, byteOffset: Int(offset)),
reason: "Method '\(name)' should call to super function")]
} else if callsToSuper.count > 1 {
return [StyleViolation(ruleDescription: self.dynamicType.description,
severity: configuration.severity,
location: Location(file: file, byteOffset: Int(offset)),
reason: "Method '\(name)' should call to super only once")]
}
return []
}
private func extractAttributes(dictionary: [String: SourceKitRepresentable]) -> [String] {
guard let attributesDict = dictionary["key.attributes"] as? [SourceKitRepresentable]
else { return [] }
return attributesDict.flatMap {
($0 as? [String: SourceKitRepresentable])?["key.attribute"] as? String
}
}
private func extractCallsToSuper(name: String,
substructure: [SourceKitRepresentable]) -> [String] {
let superCall = "super.\(name)"
return substructure.flatMap {
guard let elems = $0 as? [String: SourceKitRepresentable],
type = elems["key.kind"] as? String,
name = elems["key.name"] as? String
where type == "source.lang.swift.expr.call" && superCall.containsString(name)
else { return nil }
return name
}
}
}