mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
JP Simard
86d60400c1
Over the years, SwiftLintFramework had become a fairly massive monolith, containing over 400 source files with both core infrastructure and rules. Architecturally, the rules should rely on the core infrastructure but not the other way around. There are two exceptions to this: `custom_rules` and `superfluous_disable_command` which need special integration with the linter infrastructure. Now the time has come to formalize this architecture and one way to do that is to move the core SwiftLint functionality out of SwiftLintFramework and into a new SwiftLintCore module that the rules can depend on. Beyond enforcing architectural patterns, this also has the advantage of speeding up incremental compilation by skipping rebuilding the core functionality when iterating on rules. Because the core functionality is always useful when building rules, I'm opting to import SwiftLintCore in SwiftLintFramework as `@_exported` so that it's implicitly available to all files in SwiftLintFramework without needing to import it directly. In a follow-up I'll also split the built-in rules and the extra rules into their own modules. More modularization is possible from there, but not planned. The bulk of this PR just moves files from `Source/SwiftLintFramework/*` to `Source/SwiftLintCore/*`. There are some other changes that can't be split up into their own PRs: * Change jazzy to document the SwiftLintCore module instead of SwiftLintFramework. * Change imports in unit tests to reflect where code was moved to. * Update `sourcery` make rule to reflect where code was moved to. * Create a new `coreRules` array and register those rules with the registry. This allows the `custom_rules` and `superfluous_disable_command` rule implementations to remain internal to the SwiftLintCore module, preventing more implementation details from leaking across architectural layers. * Move `RuleRegistry.registerAllRulesOnce()` out of the type declaration and up one level so it can access rules defined downstream from SwiftLintCore.
85 lines
2.6 KiB
Swift
85 lines
2.6 KiB
Swift
import Foundation
|
|
import SourceKittenFramework
|
|
|
|
/// A unit of Swift source code, either on disk or in memory.
|
|
public final class SwiftLintFile {
|
|
/// The underlying SourceKitten file.
|
|
public let file: File
|
|
let id: UUID
|
|
/// Whether or not this is a file generated for testing purposes.
|
|
public private(set) var isTestFile = false
|
|
/// A file is virtual if it is not backed by a filesystem path.
|
|
private(set) var isVirtual = false
|
|
|
|
/// Creates a `SwiftLintFile` with a SourceKitten `File`.
|
|
///
|
|
/// - parameter file: A file from SourceKitten.
|
|
public init(file: File) {
|
|
self.file = file
|
|
self.id = UUID()
|
|
}
|
|
|
|
/// Creates a `SwiftLintFile` by specifying its path on disk.
|
|
/// Fails if the file does not exist.
|
|
///
|
|
/// - parameter path: The path to a file on disk. Relative and absolute paths supported.
|
|
public convenience init?(path: String) {
|
|
guard let file = File(path: path) else { return nil }
|
|
self.init(file: file)
|
|
}
|
|
|
|
/// Creates a `SwiftLintFile` by specifying its path on disk. Unlike the `SwiftLintFile(path:)` initializer, this
|
|
/// one does not read its contents immediately, but rather traps at runtime when attempting to access its contents.
|
|
///
|
|
/// - parameter path: The path to a file on disk. Relative and absolute paths supported.
|
|
public convenience init(pathDeferringReading path: String) {
|
|
self.init(file: File(pathDeferringReading: path))
|
|
}
|
|
|
|
/// Creates a `SwiftLintFile` that is not backed by a file on disk by specifying its contents.
|
|
///
|
|
/// - parameter contents: The contents of the file.
|
|
public convenience init(contents: String) {
|
|
self.init(file: File(contents: contents))
|
|
isVirtual = true
|
|
}
|
|
|
|
/// The path on disk for this file.
|
|
public var path: String? {
|
|
return file.path
|
|
}
|
|
|
|
/// The file's contents.
|
|
public var contents: String {
|
|
return file.contents
|
|
}
|
|
|
|
/// A string view into the contents of this file optimized for string manipulation operations.
|
|
public var stringView: StringView {
|
|
return file.stringView
|
|
}
|
|
|
|
/// The parsed lines for this file's contents.
|
|
public var lines: [Line] {
|
|
return file.lines
|
|
}
|
|
|
|
/// Mark this file as used for testing purposes.
|
|
@_spi(TestHelper)
|
|
public func markAsTestFile() {
|
|
isTestFile = true
|
|
}
|
|
}
|
|
|
|
// MARK: - Hashable Conformance
|
|
|
|
extension SwiftLintFile: Equatable, Hashable {
|
|
public static func == (lhs: SwiftLintFile, rhs: SwiftLintFile) -> Bool {
|
|
lhs.id == rhs.id
|
|
}
|
|
|
|
public func hash(into hasher: inout Hasher) {
|
|
hasher.combine(id)
|
|
}
|
|
}
|