mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
89 lines
3.2 KiB
Swift
89 lines
3.2 KiB
Swift
//
|
|
// ClassDelegateProtocolRule.swift
|
|
// SwiftLint
|
|
//
|
|
// Created by Marcelo Fabri on 12/23/16.
|
|
// Copyright © 2016 Realm. All rights reserved.
|
|
//
|
|
|
|
import Foundation
|
|
import SourceKittenFramework
|
|
|
|
public struct ClassDelegateProtocolRule: ASTRule, ConfigurationProviderRule {
|
|
public var configuration = SeverityConfiguration(.warning)
|
|
|
|
public init() {}
|
|
|
|
public static let description = RuleDescription(
|
|
identifier: "class_delegate_protocol",
|
|
name: "Class Delegate Protocol",
|
|
description: "Delegate protocols should be class-only so they can be weakly referenced.",
|
|
nonTriggeringExamples: [
|
|
"protocol FooDelegate: class {}\n",
|
|
"protocol FooDelegate: class, BarDelegate {}\n",
|
|
"protocol Foo {}\n",
|
|
"class FooDelegate {}\n",
|
|
"@objc protocol FooDelegate {}\n",
|
|
"@objc(MyFooDelegate)\n protocol FooDelegate {}\n",
|
|
"protocol FooDelegate: BarDelegate {}\n"
|
|
],
|
|
triggeringExamples: [
|
|
"↓protocol FooDelegate {}\n",
|
|
"↓protocol FooDelegate: Bar {}\n"
|
|
]
|
|
)
|
|
|
|
public func validateFile(_ file: File,
|
|
kind: SwiftDeclarationKind,
|
|
dictionary: [String: SourceKitRepresentable]) -> [StyleViolation] {
|
|
guard kind == .protocol else {
|
|
return []
|
|
}
|
|
|
|
// Check if name contains "Delegate"
|
|
guard let name = (dictionary["key.name"] as? String), isDelegateProtocol(name) else {
|
|
return []
|
|
}
|
|
|
|
// Check if @objc
|
|
let objcAttributes: Set<String> = ["source.decl.attribute.objc",
|
|
"source.decl.attribute.objc.name"]
|
|
let isObjc = !objcAttributes.intersection(dictionary.enclosedSwiftAttributes).isEmpty
|
|
guard !isObjc else {
|
|
return []
|
|
}
|
|
|
|
// Check if inherits from another Delegate protocol
|
|
guard dictionary.inheritedTypes.filter(isDelegateProtocol).isEmpty else {
|
|
return []
|
|
}
|
|
|
|
// Check if : class
|
|
guard let offset = (dictionary["key.offset"] as? Int64).flatMap({ Int($0) }),
|
|
let nameOffset = (dictionary["key.nameoffset"] as? Int64).flatMap({ Int($0) }),
|
|
let nameLength = (dictionary["key.namelength"] as? Int64).flatMap({ Int($0) }),
|
|
let bodyOffset = (dictionary["key.bodyoffset"] as? Int64).flatMap({ Int($0) }),
|
|
case let contents = file.contents.bridge(),
|
|
case let start = nameOffset + nameLength,
|
|
let range = contents.byteRangeToNSRange(start: start, length: bodyOffset - start),
|
|
!isClassProtocol(file: file, range: range) else {
|
|
return []
|
|
}
|
|
|
|
return [
|
|
StyleViolation(ruleDescription: type(of: self).description,
|
|
severity: configuration.severity,
|
|
location: Location(file: file, byteOffset: offset))
|
|
]
|
|
}
|
|
|
|
private func isClassProtocol(file: File, range: NSRange) -> Bool {
|
|
return !file.matchPattern("\\bclass\\b", withSyntaxKinds: [.keyword], range: range).isEmpty
|
|
}
|
|
|
|
private func isDelegateProtocol(_ name: String) -> Bool {
|
|
return name.hasSuffix("Delegate")
|
|
}
|
|
|
|
}
|