Files
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Idiomatic/LegacyCGGeometryFunctionsRule.swift
T
Danny Mösch 58928b7e40 Enforce any on existential types (#5273)
This makes syntactically clear which types are rather expensive.
2023-10-12 08:37:23 +02:00

115 lines
5.9 KiB
Swift

struct LegacyCGGeometryFunctionsRule: SwiftSyntaxCorrectableRule, ConfigurationProviderRule {
var configuration = SeverityConfiguration<Self>(.warning)
static let description = RuleDescription(
identifier: "legacy_cggeometry_functions",
name: "Legacy CGGeometry Functions",
description: "Struct extension properties and methods are preferred over legacy functions",
kind: .idiomatic,
nonTriggeringExamples: [
Example("rect.width"),
Example("rect.height"),
Example("rect.minX"),
Example("rect.midX"),
Example("rect.maxX"),
Example("rect.minY"),
Example("rect.midY"),
Example("rect.maxY"),
Example("rect.isNull"),
Example("rect.isEmpty"),
Example("rect.isInfinite"),
Example("rect.standardized"),
Example("rect.integral"),
Example("rect.insetBy(dx: 5.0, dy: -7.0)"),
Example("rect.offsetBy(dx: 5.0, dy: -7.0)"),
Example("rect1.union(rect2)"),
Example("rect1.intersect(rect2)"),
// "rect.divide(atDistance: 10.2, fromEdge: edge)", No correction available for divide
Example("rect1.contains(rect2)"),
Example("rect.contains(point)"),
Example("rect1.intersects(rect2)")
],
triggeringExamples: [
Example("↓CGRectGetWidth(rect)"),
Example("↓CGRectGetHeight(rect)"),
Example("↓CGRectGetMinX(rect)"),
Example("↓CGRectGetMidX(rect)"),
Example("↓CGRectGetMaxX(rect)"),
Example("↓CGRectGetMinY(rect)"),
Example("↓CGRectGetMidY(rect)"),
Example("↓CGRectGetMaxY(rect)"),
Example("↓CGRectIsNull(rect)"),
Example("↓CGRectIsEmpty(rect)"),
Example("↓CGRectIsInfinite(rect)"),
Example("↓CGRectStandardize(rect)"),
Example("↓CGRectIntegral(rect)"),
Example("↓CGRectInset(rect, 10, 5)"),
Example("↓CGRectOffset(rect, -2, 8.3)"),
Example("↓CGRectUnion(rect1, rect2)"),
Example("↓CGRectIntersection(rect1, rect2)"),
Example("↓CGRectContainsRect(rect1, rect2)"),
Example("↓CGRectContainsPoint(rect, point)"),
Example("↓CGRectIntersectsRect(rect1, rect2)")
],
corrections: [
Example("↓CGRectGetWidth( rect )"): Example("rect.width"),
Example("↓CGRectGetHeight(rect )"): Example("rect.height"),
Example("↓CGRectGetMinX( rect)"): Example("rect.minX"),
Example("↓CGRectGetMidX( rect)"): Example("rect.midX"),
Example("↓CGRectGetMaxX( rect)"): Example("rect.maxX"),
Example("↓CGRectGetMinY(rect )"): Example("rect.minY"),
Example("↓CGRectGetMidY(rect )"): Example("rect.midY"),
Example("↓CGRectGetMaxY( rect )"): Example("rect.maxY"),
Example("↓CGRectIsNull( rect )"): Example("rect.isNull"),
Example("↓CGRectIsEmpty( rect )"): Example("rect.isEmpty"),
Example("↓CGRectIsInfinite( rect )"): Example("rect.isInfinite"),
Example("↓CGRectStandardize( rect)"): Example("rect.standardized"),
Example("↓CGRectIntegral(rect )"): Example("rect.integral"),
Example("↓CGRectInset(rect, 5.0, -7.0)"): Example("rect.insetBy(dx: 5.0, dy: -7.0)"),
Example("↓CGRectOffset(rect, -2, 8.3)"): Example("rect.offsetBy(dx: -2, dy: 8.3)"),
Example("↓CGRectUnion(rect1, rect2)"): Example("rect1.union(rect2)"),
Example("↓CGRectIntersection( rect1 ,rect2)"): Example("rect1.intersection(rect2)"),
Example("↓CGRectContainsRect( rect1,rect2 )"): Example("rect1.contains(rect2)"),
Example("↓CGRectContainsPoint(rect ,point)"): Example("rect.contains(point)"),
Example("↓CGRectIntersectsRect( rect1,rect2 )"): Example("rect1.intersects(rect2)"),
Example("↓CGRectIntersectsRect(rect1, rect2 )\n↓CGRectGetWidth(rect )"):
Example("rect1.intersects(rect2)\nrect.width")
]
)
private static let legacyFunctions: [String: LegacyFunctionRuleHelper.RewriteStrategy] = [
"CGRectGetWidth": .property(name: "width"),
"CGRectGetHeight": .property(name: "height"),
"CGRectGetMinX": .property(name: "minX"),
"CGRectGetMidX": .property(name: "midX"),
"CGRectGetMaxX": .property(name: "maxX"),
"CGRectGetMinY": .property(name: "minY"),
"CGRectGetMidY": .property(name: "midY"),
"CGRectGetMaxY": .property(name: "maxY"),
"CGRectIsNull": .property(name: "isNull"),
"CGRectIsEmpty": .property(name: "isEmpty"),
"CGRectIsInfinite": .property(name: "isInfinite"),
"CGRectStandardize": .property(name: "standardized"),
"CGRectIntegral": .property(name: "integral"),
"CGRectInset": .function(name: "insetBy", argumentLabels: ["dx", "dy"]),
"CGRectOffset": .function(name: "offsetBy", argumentLabels: ["dx", "dy"]),
"CGRectUnion": .function(name: "union", argumentLabels: [""]),
"CGRectContainsRect": .function(name: "contains", argumentLabels: [""]),
"CGRectContainsPoint": .function(name: "contains", argumentLabels: [""]),
"CGRectIntersectsRect": .function(name: "intersects", argumentLabels: [""]),
"CGRectIntersection": .function(name: "intersection", argumentLabels: [""])
]
func makeVisitor(file: SwiftLintFile) -> ViolationsSyntaxVisitor {
LegacyFunctionRuleHelper.Visitor(legacyFunctions: Self.legacyFunctions)
}
func makeRewriter(file: SwiftLintFile) -> (some ViolationsSyntaxRewriter)? {
LegacyFunctionRuleHelper.Rewriter(
legacyFunctions: Self.legacyFunctions,
locationConverter: file.locationConverter,
disabledRegions: disabledRegions(file: file)
)
}
}