Files
SwiftLint/Source/SwiftLintFramework/Rules/IdentifierNameRule.swift
T
2017-01-23 21:38:56 -02:00

141 lines
5.7 KiB
Swift

//
// IdentifierNameRule.swift
// SwiftLint
//
// Created by JP Simard on 5/16/15.
// Copyright © 2015 Realm. All rights reserved.
//
import Foundation
import SourceKittenFramework
public struct IdentifierNameRule: ASTRule, ConfigurationProviderRule {
public var configuration = NameConfiguration(minLengthWarning: 3,
minLengthError: 2,
maxLengthWarning: 40,
maxLengthError: 60)
public init() {}
public static let description = RuleDescription(
identifier: "identifier_name",
name: "Identifier Name",
description: "Identifier names should only contain alphanumeric characters and " +
"start with a lowercase character or should only contain capital letters. " +
"In an exception to the above, variable names may start with a capital letter " +
"when they are declared static and immutable. Variable names should not be too " +
"long or too short.",
nonTriggeringExamples: [
"let myLet = 0",
"var myVar = 0",
"private let _myLet = 0",
"class Abc { static let MyLet = 0 }",
"let URL: NSURL? = nil",
"let XMLString: String? = nil",
"override var i = 0",
"enum Foo { case myEnum }",
"func isOperator(name: String) -> Bool",
"func typeForKind(_ kind: SwiftDeclarationKind) -> String",
"func == (lhs: SyntaxToken, rhs: SyntaxToken) -> Bool",
"override func IsOperator(name: String) -> Bool"
],
triggeringExamples: [
"↓let MyLet = 0",
"↓let _myLet = 0",
"private ↓let myLet_ = 0",
"↓let myExtremelyVeryVeryVeryVeryVeryVeryLongLet = 0",
"↓var myExtremelyVeryVeryVeryVeryVeryVeryLongVar = 0",
"private ↓let _myExtremelyVeryVeryVeryVeryVeryVeryLongLet = 0",
"↓let i = 0",
"↓var id = 0",
"private ↓let _i = 0",
"enum Foo { case ↓MyEnum }",
"↓func IsOperator(name: String) -> Bool"
]
)
private func nameIsViolatingCase(_ name: String) -> Bool {
let secondIndex = name.characters.index(after: name.startIndex)
let firstCharacter = name.substring(to: secondIndex)
if firstCharacter.isUppercase() {
if name.characters.count > 1 {
let range = secondIndex..<name.characters.index(after: secondIndex)
let secondCharacter = name.substring(with: range)
return secondCharacter.isLowercase()
}
return true
}
return false
}
public func validateFile(_ file: File, kind: SwiftDeclarationKind,
dictionary: [String: SourceKitRepresentable]) -> [StyleViolation] {
guard !dictionary.enclosedSwiftAttributes.contains("source.decl.attribute.override") else {
return []
}
return file.validateIdentifierName(dictionary, kind: kind).map { name, offset in
guard !configuration.excluded.contains(name) else {
return []
}
let nameCharacterSet = CharacterSet(fixedCharactersIn: name)
let isFunction = SwiftDeclarationKind.functionKinds().contains(kind)
let description = type(of: self).description
let type = typeForKind(kind)
if !isFunction {
if !CharacterSet.alphanumerics.isSuperset(of: nameCharacterSet) {
return [
StyleViolation(ruleDescription: description,
severity: .error,
location: Location(file: file, byteOffset: offset),
reason: "\(type) name should only contain alphanumeric " +
"characters: '\(name)'")
]
}
if let severity = severity(forLength: name.characters.count) {
let reason = "\(type) name should be between " +
"\(configuration.minLengthThreshold) and " +
"\(configuration.maxLengthThreshold) characters long: '\(name)'"
return [
StyleViolation(ruleDescription: type(of: self).description,
severity: severity,
location: Location(file: file, byteOffset: offset),
reason: reason)
]
}
}
if kind != .varStatic && nameIsViolatingCase(name) && !isOperator(name: name) {
let reason = "\(type) name should start with a lowercase character: '\(name)'"
return [
StyleViolation(ruleDescription: description,
severity: .error,
location: Location(file: file, byteOffset: offset),
reason: reason)
]
}
return []
} ?? []
}
private func isOperator(name: String) -> Bool {
let operators = ["/", "=", "-", "+", "!", "*", "|", "^", "~", "?", ".", "%", "<", ">", "&"]
return !operators.filter { name.hasPrefix($0) }.isEmpty
}
private func typeForKind(_ kind: SwiftDeclarationKind) -> String {
if SwiftDeclarationKind.functionKinds().contains(kind) {
return "Function"
} else if kind == .enumelement {
return "Enum element"
} else {
return "Variable"
}
}
}