mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
b83e0991b9
The MIT license doesn't require that all files be prepended with this licensing or copyright information. Realm confirmed that they're ok with this change. This will enable some companies to contribute to SwiftLint and the date & authorship information will remain accessible via git source control.
102 lines
3.9 KiB
Swift
102 lines
3.9 KiB
Swift
import Foundation
|
|
import SourceKittenFramework
|
|
|
|
public struct WeakDelegateRule: ASTRule, ConfigurationProviderRule {
|
|
public var configuration = SeverityConfiguration(.warning)
|
|
|
|
public init() {}
|
|
|
|
public static let description = RuleDescription(
|
|
identifier: "weak_delegate",
|
|
name: "Weak Delegate",
|
|
description: "Delegates should be weak to avoid reference cycles.",
|
|
kind: .lint,
|
|
nonTriggeringExamples: [
|
|
"class Foo {\n weak var delegate: SomeProtocol?\n}\n",
|
|
"class Foo {\n weak var someDelegate: SomeDelegateProtocol?\n}\n",
|
|
"class Foo {\n weak var delegateScroll: ScrollDelegate?\n}\n",
|
|
// We only consider properties to be a delegate if it has "delegate" in its name
|
|
"class Foo {\n var scrollHandler: ScrollDelegate?\n}\n",
|
|
// Only trigger on instance variables, not local variables
|
|
"func foo() {\n var delegate: SomeDelegate\n}\n",
|
|
// Only trigger when variable has the suffix "-delegate" to avoid false positives
|
|
"class Foo {\n var delegateNotified: Bool?\n}\n",
|
|
// There's no way to declare a property weak in a protocol
|
|
"protocol P {\n var delegate: AnyObject? { get set }\n}\n",
|
|
"class Foo {\n protocol P {\n var delegate: AnyObject? { get set }\n}\n}\n",
|
|
"class Foo {\n var computedDelegate: ComputedDelegate {\n return bar() \n} \n}"
|
|
],
|
|
triggeringExamples: [
|
|
"class Foo {\n ↓var delegate: SomeProtocol?\n}\n",
|
|
"class Foo {\n ↓var scrollDelegate: ScrollDelegate?\n}\n"
|
|
]
|
|
)
|
|
|
|
public func validate(file: File, kind: SwiftDeclarationKind,
|
|
dictionary: [String: SourceKitRepresentable]) -> [StyleViolation] {
|
|
guard kind == .varInstance else {
|
|
return []
|
|
}
|
|
|
|
// Check if name contains "delegate"
|
|
guard let name = dictionary.name,
|
|
name.lowercased().hasSuffix("delegate") else {
|
|
return []
|
|
}
|
|
|
|
// Check if non-weak
|
|
let isWeak = dictionary.enclosedSwiftAttributes.contains(.weak)
|
|
guard !isWeak else { return [] }
|
|
|
|
// if the declaration is inside a protocol
|
|
if let offset = dictionary.offset,
|
|
!protocolDeclarations(forByteOffset: offset, structure: file.structure).isEmpty {
|
|
return []
|
|
}
|
|
|
|
// Check if non-computed
|
|
let isComputed = dictionary.bodyLength ?? 0 > 0
|
|
guard !isComputed else { return [] }
|
|
|
|
// Violation found!
|
|
let location: Location
|
|
if let offset = dictionary.offset {
|
|
location = Location(file: file, byteOffset: offset)
|
|
} else {
|
|
location = Location(file: file.path)
|
|
}
|
|
|
|
return [
|
|
StyleViolation(
|
|
ruleDescription: type(of: self).description,
|
|
severity: configuration.severity,
|
|
location: location
|
|
)
|
|
]
|
|
}
|
|
|
|
private func protocolDeclarations(forByteOffset byteOffset: Int,
|
|
structure: Structure) -> [[String: SourceKitRepresentable]] {
|
|
var results = [[String: SourceKitRepresentable]]()
|
|
|
|
func parse(dictionary: [String: SourceKitRepresentable]) {
|
|
|
|
// Only accepts protocols declarations which contains a body and contains the
|
|
// searched byteOffset
|
|
if let kindString = (dictionary.kind),
|
|
SwiftDeclarationKind(rawValue: kindString) == .protocol,
|
|
let offset = dictionary.bodyOffset,
|
|
let length = dictionary.bodyLength {
|
|
let byteRange = NSRange(location: offset, length: length)
|
|
|
|
if NSLocationInRange(byteOffset, byteRange) {
|
|
results.append(dictionary)
|
|
}
|
|
}
|
|
dictionary.substructure.forEach(parse)
|
|
}
|
|
parse(dictionary: structure.dictionary)
|
|
return results
|
|
}
|
|
}
|