mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
b83e0991b9
The MIT license doesn't require that all files be prepended with this licensing or copyright information. Realm confirmed that they're ok with this change. This will enable some companies to contribute to SwiftLint and the date & authorship information will remain accessible via git source control.
109 lines
4.1 KiB
Swift
109 lines
4.1 KiB
Swift
import Foundation
|
|
import SourceKittenFramework
|
|
|
|
public struct ShorthandOperatorRule: ConfigurationProviderRule {
|
|
|
|
public var configuration = SeverityConfiguration(.error)
|
|
|
|
public init() {}
|
|
|
|
public static let description = RuleDescription(
|
|
identifier: "shorthand_operator",
|
|
name: "Shorthand Operator",
|
|
description: "Prefer shorthand operators (+=, -=, *=, /=) over doing the operation and assigning.",
|
|
kind: .style,
|
|
nonTriggeringExamples: allOperators.flatMap { operation in
|
|
[
|
|
"foo \(operation)= 1",
|
|
"foo \(operation)= variable",
|
|
"foo \(operation)= bar.method()",
|
|
"self.foo = foo \(operation) 1",
|
|
"foo = self.foo \(operation) 1",
|
|
"page = ceilf(currentOffset \(operation) pageWidth)",
|
|
"foo = aMethod(foo \(operation) bar)",
|
|
"foo = aMethod(bar \(operation) foo)"
|
|
]
|
|
} + [
|
|
"var helloWorld = \"world!\"\n helloWorld = \"Hello, \" + helloWorld",
|
|
"angle = someCheck ? angle : -angle",
|
|
"seconds = seconds * 60 + value"
|
|
],
|
|
triggeringExamples: allOperators.flatMap { operation in
|
|
[
|
|
"↓foo = foo \(operation) 1\n",
|
|
"↓foo = foo \(operation) aVariable\n",
|
|
"↓foo = foo \(operation) bar.method()\n",
|
|
"↓foo.aProperty = foo.aProperty \(operation) 1\n",
|
|
"↓self.aProperty = self.aProperty \(operation) 1\n"
|
|
]
|
|
} + [
|
|
"n = n + i / outputLength",
|
|
"n = n - i / outputLength"
|
|
// "d = d * 60 * 60"
|
|
]
|
|
)
|
|
|
|
private static let allOperators = ["-", "/", "+", "*"]
|
|
|
|
private static let pattern: String = {
|
|
let escaped = { (operators: [String]) -> String in
|
|
return "[\(operators.map { "\\\($0)" }.joined())]"
|
|
}
|
|
|
|
let escapedAll = escaped(allOperators)
|
|
let operatorsWithoutPrecedence = escaped(["-", "+"])
|
|
let operatorsWithPrecedence = escaped(["/", "*"])
|
|
let operand = "[\\w\\d\\.]+?"
|
|
let spaces = "[^\\S\\r\\n]*?"
|
|
|
|
let pattern1 = "\(operatorsWithoutPrecedence)"
|
|
let pattern2 = "\(operatorsWithPrecedence)\(spaces)\\S+$"
|
|
return "^\(spaces)(\(operand))\(spaces)=\(spaces)(\\1)\(spaces)(\(pattern1)|\(pattern2))"
|
|
}()
|
|
|
|
private static let violationRegex: NSRegularExpression = {
|
|
return regex(pattern, options: [.anchorsMatchLines])
|
|
}()
|
|
|
|
public func validate(file: File) -> [StyleViolation] {
|
|
let contents = file.contents.bridge()
|
|
let range = NSRange(location: 0, length: contents.length)
|
|
|
|
let matches = ShorthandOperatorRule.violationRegex.matches(in: file.contents, options: [], range: range)
|
|
|
|
return matches.compactMap { match -> StyleViolation? in
|
|
|
|
// byteRanges will have the ranges of captured groups
|
|
let byteRanges: [NSRange?] = (1..<match.numberOfRanges).map { rangeIdx in
|
|
let range = match.range(at: rangeIdx)
|
|
guard range.location != NSNotFound else {
|
|
return nil
|
|
}
|
|
|
|
return contents.NSRangeToByteRange(start: range.location, length: range.length)
|
|
}
|
|
|
|
guard let byteRange = byteRanges[0] else {
|
|
return nil
|
|
}
|
|
|
|
let kindsInCaptureGroups = byteRanges.map { range -> [SyntaxKind] in
|
|
return range.flatMap(file.syntaxMap.kinds(inByteRange:)) ?? []
|
|
}
|
|
|
|
guard kindsAreValid(kindsInCaptureGroups[0]) &&
|
|
kindsAreValid(kindsInCaptureGroups[1]) else {
|
|
return nil
|
|
}
|
|
|
|
return StyleViolation(ruleDescription: type(of: self).description,
|
|
severity: configuration.severity,
|
|
location: Location(file: file, byteOffset: byteRange.location))
|
|
}
|
|
}
|
|
|
|
private func kindsAreValid(_ kinds: [SyntaxKind]) -> Bool {
|
|
return Set(kinds).isSubset(of: [.identifier, .keyword])
|
|
}
|
|
}
|