mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
b83e0991b9
The MIT license doesn't require that all files be prepended with this licensing or copyright information. Realm confirmed that they're ok with this change. This will enable some companies to contribute to SwiftLint and the date & authorship information will remain accessible via git source control.
79 lines
3.3 KiB
Swift
79 lines
3.3 KiB
Swift
import Foundation
|
|
import SourceKittenFramework
|
|
|
|
public struct EmptyParametersRule: ConfigurationProviderRule, CorrectableRule {
|
|
public var configuration = SeverityConfiguration(.warning)
|
|
|
|
public init() {}
|
|
|
|
public static let description = RuleDescription(
|
|
identifier: "empty_parameters",
|
|
name: "Empty Parameters",
|
|
description: "Prefer `() -> ` over `Void -> `.",
|
|
kind: .style,
|
|
nonTriggeringExamples: [
|
|
"let abc: () -> Void = {}\n",
|
|
"func foo(completion: () -> Void)\n",
|
|
"func foo(completion: () thows -> Void)\n",
|
|
"let foo: (ConfigurationTests) -> Void throws -> Void)\n",
|
|
"let foo: (ConfigurationTests) -> Void throws -> Void)\n",
|
|
"let foo: (ConfigurationTests) ->Void throws -> Void)\n"
|
|
],
|
|
triggeringExamples: [
|
|
"let abc: ↓(Void) -> Void = {}\n",
|
|
"func foo(completion: ↓(Void) -> Void)\n",
|
|
"func foo(completion: ↓(Void) throws -> Void)\n",
|
|
"let foo: ↓(Void) -> () throws -> Void)\n"
|
|
],
|
|
corrections: [
|
|
"let abc: ↓(Void) -> Void = {}\n": "let abc: () -> Void = {}\n",
|
|
"func foo(completion: ↓(Void) -> Void)\n": "func foo(completion: () -> Void)\n",
|
|
"func foo(completion: ↓(Void) throws -> Void)\n":
|
|
"func foo(completion: () throws -> Void)\n",
|
|
"let foo: ↓(Void) -> () throws -> Void)\n": "let foo: () -> () throws -> Void)\n"
|
|
]
|
|
)
|
|
|
|
public func validate(file: File) -> [StyleViolation] {
|
|
return violationRanges(file: file).map {
|
|
StyleViolation(ruleDescription: type(of: self).description,
|
|
severity: configuration.severity,
|
|
location: Location(file: file, characterOffset: $0.location))
|
|
}
|
|
}
|
|
|
|
private func violationRanges(file: File) -> [NSRange] {
|
|
let voidPattern = "\\(Void\\)"
|
|
let pattern = voidPattern + "\\s*(throws\\s+)?->"
|
|
let excludingPattern = "->\\s*" + pattern // excludes curried functions
|
|
|
|
return file.match(pattern: pattern,
|
|
excludingSyntaxKinds: SyntaxKind.commentAndStringKinds,
|
|
excludingPattern: excludingPattern).compactMap { range in
|
|
let voidRegex = regex(voidPattern)
|
|
return voidRegex.firstMatch(in: file.contents, options: [], range: range)?.range
|
|
}
|
|
}
|
|
|
|
public func correct(file: File) -> [Correction] {
|
|
let violatingRanges = file.ruleEnabled(violatingRanges: violationRanges(file: file), for: self)
|
|
var correctedContents = file.contents
|
|
var adjustedLocations = [Int]()
|
|
|
|
for violatingRange in violatingRanges.reversed() {
|
|
if let indexRange = correctedContents.nsrangeToIndexRange(violatingRange) {
|
|
correctedContents = correctedContents
|
|
.replacingCharacters(in: indexRange, with: "()")
|
|
adjustedLocations.insert(violatingRange.location, at: 0)
|
|
}
|
|
}
|
|
|
|
file.write(correctedContents)
|
|
|
|
return adjustedLocations.map {
|
|
Correction(ruleDescription: type(of: self).description,
|
|
location: Location(file: file, characterOffset: $0))
|
|
}
|
|
}
|
|
}
|