mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
b83e0991b9
The MIT license doesn't require that all files be prepended with this licensing or copyright information. Realm confirmed that they're ok with this change. This will enable some companies to contribute to SwiftLint and the date & authorship information will remain accessible via git source control.
159 lines
6.4 KiB
Swift
159 lines
6.4 KiB
Swift
import Foundation
|
|
import SourceKittenFramework
|
|
|
|
private func wrapInSwitch(variable: String = "foo", _ str: String) -> String {
|
|
return "switch \(variable) {\n" +
|
|
" \(str): break\n" +
|
|
"}"
|
|
}
|
|
|
|
private func wrapInFunc(_ str: String) -> String {
|
|
return """
|
|
func example(foo: Foo) {
|
|
switch foo {
|
|
case \(str):
|
|
break
|
|
}
|
|
}
|
|
"""
|
|
}
|
|
|
|
public struct EmptyEnumArgumentsRule: ASTRule, ConfigurationProviderRule, CorrectableRule {
|
|
public var configuration = SeverityConfiguration(.warning)
|
|
|
|
public init() {}
|
|
|
|
public static let description = RuleDescription(
|
|
identifier: "empty_enum_arguments",
|
|
name: "Empty Enum Arguments",
|
|
description: "Arguments can be omitted when matching enums with associated types if they are not used.",
|
|
kind: .style,
|
|
nonTriggeringExamples: [
|
|
wrapInSwitch("case .bar"),
|
|
wrapInSwitch("case .bar(let x)"),
|
|
wrapInSwitch("case let .bar(x)"),
|
|
wrapInSwitch(variable: "(foo, bar)", "case (_, _)"),
|
|
wrapInSwitch("case \"bar\".uppercased()"),
|
|
wrapInSwitch(variable: "(foo, bar)", "case (_, _) where !something"),
|
|
wrapInSwitch("case (let f as () -> String)?"),
|
|
wrapInSwitch("default")
|
|
],
|
|
triggeringExamples: [
|
|
wrapInSwitch("case .bar↓(_)"),
|
|
wrapInSwitch("case .bar↓()"),
|
|
wrapInSwitch("case .bar↓(_), .bar2↓(_)"),
|
|
wrapInSwitch("case .bar↓() where method() > 2"),
|
|
wrapInFunc("case .bar↓(_)")
|
|
],
|
|
corrections: [
|
|
wrapInSwitch("case .bar↓(_)"): wrapInSwitch("case .bar"),
|
|
wrapInSwitch("case .bar↓()"): wrapInSwitch("case .bar"),
|
|
wrapInSwitch("case .bar↓(_), .bar2↓(_)"): wrapInSwitch("case .bar, .bar2"),
|
|
wrapInSwitch("case .bar↓() where method() > 2"): wrapInSwitch("case .bar where method() > 2"),
|
|
wrapInFunc("case .bar↓(_)"): wrapInFunc("case .bar")
|
|
]
|
|
)
|
|
|
|
public func validate(file: File, kind: StatementKind,
|
|
dictionary: [String: SourceKitRepresentable]) -> [StyleViolation] {
|
|
return violationRanges(in: file, kind: kind, dictionary: dictionary).map {
|
|
StyleViolation(ruleDescription: type(of: self).description,
|
|
severity: configuration.severity,
|
|
location: Location(file: file, characterOffset: $0.location))
|
|
}
|
|
}
|
|
|
|
private func violationRanges(in file: File, kind: StatementKind,
|
|
dictionary: [String: SourceKitRepresentable]) -> [NSRange] {
|
|
guard kind == .case else {
|
|
return []
|
|
}
|
|
|
|
let contents = file.contents.bridge()
|
|
|
|
let callsRanges = dictionary.substructure.compactMap { dict -> NSRange? in
|
|
guard dict.kind.flatMap(SwiftExpressionKind.init(rawValue:)) == .call,
|
|
let offset = dict.offset,
|
|
let length = dict.length,
|
|
let range = contents.byteRangeToNSRange(start: offset, length: length) else {
|
|
return nil
|
|
}
|
|
|
|
return range
|
|
}
|
|
|
|
return dictionary.elements.flatMap { subDictionary -> [NSRange] in
|
|
guard subDictionary.kind == "source.lang.swift.structure.elem.pattern",
|
|
let offset = subDictionary.offset,
|
|
let length = subDictionary.length,
|
|
let caseRange = contents.byteRangeToNSRange(start: offset, length: length) else {
|
|
return []
|
|
}
|
|
|
|
let emptyArgumentRegex = regex("\\.\\S+\\s*(\\([,\\s_]*\\))")
|
|
return emptyArgumentRegex.matches(in: file.contents, options: [], range: caseRange).compactMap { match in
|
|
let parenthesesRange = match.range(at: 1)
|
|
|
|
// avoid matches after `where` keyworkd
|
|
if let whereRange = file.match(pattern: "where", with: [.keyword], range: caseRange).first {
|
|
if whereRange.location < parenthesesRange.location {
|
|
return nil
|
|
}
|
|
|
|
// avoid matches in "(_, _) where"
|
|
if let whereByteRange = contents.NSRangeToByteRange(start: whereRange.location,
|
|
length: whereRange.length),
|
|
case let length = whereByteRange.location - offset,
|
|
case let byteRange = NSRange(location: offset, length: length),
|
|
Set(file.syntaxMap.kinds(inByteRange: byteRange)) == [.keyword] {
|
|
return nil
|
|
}
|
|
}
|
|
|
|
if callsRanges.contains(where: parenthesesRange.intersects) {
|
|
return nil
|
|
}
|
|
|
|
return parenthesesRange
|
|
}
|
|
}
|
|
}
|
|
|
|
private func violationRanges(in file: File, dictionary: [String: SourceKitRepresentable]) -> [NSRange] {
|
|
return dictionary.substructure.flatMap { subDict -> [NSRange] in
|
|
var ranges = violationRanges(in: file, dictionary: subDict)
|
|
if let kind = subDict.kind.flatMap(StatementKind.init(rawValue:)) {
|
|
ranges += violationRanges(in: file, kind: kind, dictionary: subDict)
|
|
}
|
|
|
|
return ranges
|
|
}
|
|
}
|
|
|
|
private func violationRanges(in file: File) -> [NSRange] {
|
|
return violationRanges(in: file, dictionary: file.structure.dictionary).sorted { lhs, rhs in
|
|
lhs.location < rhs.location
|
|
}
|
|
}
|
|
|
|
public func correct(file: File) -> [Correction] {
|
|
let violatingRanges = file.ruleEnabled(violatingRanges: violationRanges(in: file), for: self)
|
|
var correctedContents = file.contents
|
|
var adjustedLocations = [Int]()
|
|
|
|
for violatingRange in violatingRanges.reversed() {
|
|
if let indexRange = correctedContents.nsrangeToIndexRange(violatingRange) {
|
|
correctedContents = correctedContents.replacingCharacters(in: indexRange, with: "")
|
|
adjustedLocations.insert(violatingRange.location, at: 0)
|
|
}
|
|
}
|
|
|
|
file.write(correctedContents)
|
|
|
|
return adjustedLocations.map {
|
|
Correction(ruleDescription: type(of: self).description,
|
|
location: Location(file: file, characterOffset: $0))
|
|
}
|
|
}
|
|
}
|