mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
b83e0991b9
The MIT license doesn't require that all files be prepended with this licensing or copyright information. Realm confirmed that they're ok with this change. This will enable some companies to contribute to SwiftLint and the date & authorship information will remain accessible via git source control.
140 lines
6.2 KiB
Swift
140 lines
6.2 KiB
Swift
import Foundation
|
|
import SourceKittenFramework
|
|
|
|
public struct CommaRule: CorrectableRule, ConfigurationProviderRule {
|
|
|
|
public var configuration = SeverityConfiguration(.warning)
|
|
|
|
public init() {}
|
|
|
|
public static let description = RuleDescription(
|
|
identifier: "comma",
|
|
name: "Comma Spacing",
|
|
description: "There should be no space before and one after any comma.",
|
|
kind: .style,
|
|
nonTriggeringExamples: [
|
|
"func abc(a: String, b: String) { }",
|
|
"abc(a: \"string\", b: \"string\"",
|
|
"enum a { case a, b, c }",
|
|
"func abc(\n a: String, // comment\n bcd: String // comment\n) {\n}\n",
|
|
"func abc(\n a: String,\n bcd: String\n) {\n}\n"
|
|
],
|
|
triggeringExamples: [
|
|
"func abc(a: String↓ ,b: String) { }",
|
|
"func abc(a: String↓ ,b: String↓ ,c: String↓ ,d: String) { }",
|
|
"abc(a: \"string\"↓,b: \"string\"",
|
|
"enum a { case a↓ ,b }",
|
|
"let result = plus(\n first: 3↓ , // #683\n second: 4\n)\n"
|
|
],
|
|
corrections: [
|
|
"func abc(a: String↓,b: String) {}\n": "func abc(a: String, b: String) {}\n",
|
|
"abc(a: \"string\"↓,b: \"string\"\n": "abc(a: \"string\", b: \"string\"\n",
|
|
"abc(a: \"string\"↓ , b: \"string\"\n": "abc(a: \"string\", b: \"string\"\n",
|
|
"enum a { case a↓ ,b }\n": "enum a { case a, b }\n",
|
|
"let a = [1↓,1]\nlet b = 1\nf(1, b)\n": "let a = [1, 1]\nlet b = 1\nf(1, b)\n",
|
|
"let a = [1↓,1↓,1↓,1]\n": "let a = [1, 1, 1, 1]\n"
|
|
]
|
|
)
|
|
|
|
public func validate(file: File) -> [StyleViolation] {
|
|
return violationRanges(in: file).map {
|
|
StyleViolation(ruleDescription: type(of: self).description,
|
|
severity: configuration.severity,
|
|
location: Location(file: file, characterOffset: $0.location))
|
|
}
|
|
}
|
|
|
|
public func correct(file: File) -> [Correction] {
|
|
let violations = violationRanges(in: file)
|
|
let matches = file.ruleEnabled(violatingRanges: violations, for: self)
|
|
if matches.isEmpty { return [] }
|
|
|
|
var contents = file.contents.bridge()
|
|
let description = type(of: self).description
|
|
var corrections = [Correction]()
|
|
for range in matches.reversed() {
|
|
contents = contents.replacingCharacters(in: range, with: ", ").bridge()
|
|
let location = Location(file: file, characterOffset: range.location)
|
|
corrections.append(Correction(ruleDescription: description, location: location))
|
|
}
|
|
file.write(contents.bridge())
|
|
return corrections
|
|
}
|
|
|
|
// captures spaces and comma only
|
|
// http://userguide.icu-project.org/strings/regexp
|
|
|
|
private static let mainPatternGroups =
|
|
"(" + // start first capure
|
|
"\\s+" + // followed by whitespace
|
|
"," + // to the left of a comma
|
|
"[\\t\\p{Z}]*" + // followed by any amount of tab or space.
|
|
"|" + // or
|
|
"," + // immediately followed by a comma
|
|
"(?:[\\t\\p{Z}]{0}|" + // followed by 0
|
|
"[\\t\\p{Z}]{2,})" + // or 2+ tab or space characters.
|
|
")" + // end capture
|
|
"(\\S)" // second capture is not whitespace.
|
|
|
|
private static let pattern =
|
|
"\\S\(mainPatternGroups)" + // Regexp will match if expression not begin with comma
|
|
"|" + // or
|
|
"\(mainPatternGroups)" // Regexp will match if expression begins with comma
|
|
|
|
private static let regularExpression = regex(pattern, options: [])
|
|
private static let excludingSyntaxKindsForFirstCapture = SyntaxKind.commentAndStringKinds
|
|
private static let excludingSyntaxKindsForSecondCapture = SyntaxKind.commentKinds
|
|
|
|
private func violationRanges(in file: File) -> [NSRange] {
|
|
let contents = file.contents
|
|
let nsstring = contents.bridge()
|
|
let range = NSRange(location: 0, length: nsstring.length)
|
|
let syntaxMap = file.syntaxMap
|
|
return CommaRule.regularExpression
|
|
.matches(in: contents, options: [], range: range)
|
|
.compactMap { match -> NSRange? in
|
|
if match.numberOfRanges != 5 { return nil } // Number of Groups in regexp
|
|
|
|
var indexStartRange = 1
|
|
if match.range(at: indexStartRange).location == NSNotFound {
|
|
indexStartRange += 2
|
|
}
|
|
|
|
// check first captured range
|
|
let firstRange = match.range(at: indexStartRange)
|
|
guard let matchByteFirstRange = nsstring
|
|
.NSRangeToByteRange(start: firstRange.location, length: firstRange.length)
|
|
else { return nil }
|
|
|
|
// first captured range won't match kinds if it is not comment neither string
|
|
let firstCaptureIsCommentOrString = syntaxMap.kinds(inByteRange: matchByteFirstRange)
|
|
.contains(where: CommaRule.excludingSyntaxKindsForFirstCapture.contains)
|
|
if firstCaptureIsCommentOrString {
|
|
return nil
|
|
}
|
|
|
|
// If the first range does not start with comma, it already violates this rule
|
|
// no matter what is contained in the second range.
|
|
if !nsstring.substring(with: firstRange).hasPrefix(", ") {
|
|
return firstRange
|
|
}
|
|
|
|
// check second captured range
|
|
let secondRange = match.range(at: indexStartRange + 1)
|
|
guard let matchByteSecondRange = nsstring
|
|
.NSRangeToByteRange(start: secondRange.location, length: secondRange.length)
|
|
else { return nil }
|
|
|
|
// second captured range won't match kinds if it is not comment
|
|
let secondCaptureIsComment = syntaxMap.kinds(inByteRange: matchByteSecondRange)
|
|
.contains(where: CommaRule.excludingSyntaxKindsForSecondCapture.contains)
|
|
if secondCaptureIsComment {
|
|
return nil
|
|
}
|
|
|
|
// return first captured range
|
|
return firstRange
|
|
}
|
|
}
|
|
}
|