mirror of
https://github.com/realm/SwiftLint.git
synced 2026-06-06 20:18:40 +00:00
86d60400c1
Over the years, SwiftLintFramework had become a fairly massive monolith, containing over 400 source files with both core infrastructure and rules. Architecturally, the rules should rely on the core infrastructure but not the other way around. There are two exceptions to this: `custom_rules` and `superfluous_disable_command` which need special integration with the linter infrastructure. Now the time has come to formalize this architecture and one way to do that is to move the core SwiftLint functionality out of SwiftLintFramework and into a new SwiftLintCore module that the rules can depend on. Beyond enforcing architectural patterns, this also has the advantage of speeding up incremental compilation by skipping rebuilding the core functionality when iterating on rules. Because the core functionality is always useful when building rules, I'm opting to import SwiftLintCore in SwiftLintFramework as `@_exported` so that it's implicitly available to all files in SwiftLintFramework without needing to import it directly. In a follow-up I'll also split the built-in rules and the extra rules into their own modules. More modularization is possible from there, but not planned. The bulk of this PR just moves files from `Source/SwiftLintFramework/*` to `Source/SwiftLintCore/*`. There are some other changes that can't be split up into their own PRs: * Change jazzy to document the SwiftLintCore module instead of SwiftLintFramework. * Change imports in unit tests to reflect where code was moved to. * Update `sourcery` make rule to reflect where code was moved to. * Create a new `coreRules` array and register those rules with the registry. This allows the `custom_rules` and `superfluous_disable_command` rule implementations to remain internal to the SwiftLintCore module, preventing more implementation details from leaking across architectural layers. * Move `RuleRegistry.registerAllRulesOnce()` out of the type declaration and up one level so it can access rules defined downstream from SwiftLintCore.
98 lines
5.2 KiB
Swift
98 lines
5.2 KiB
Swift
/// A detailed description for a SwiftLint rule. Used for both documentation and testing purposes.
|
|
public struct RuleDescription: Equatable {
|
|
/// The rule's unique identifier, to be used in configuration files and SwiftLint commands.
|
|
/// Should be short and only comprised of lowercase latin alphabet letters and underscores formatted in snake case.
|
|
public let identifier: String
|
|
|
|
/// The rule's human-readable name. Should be short, descriptive and formatted in Title Case. May contain spaces.
|
|
public let name: String
|
|
|
|
/// The rule's verbose description. Should read as a sentence or short paragraph. Good things to include are an
|
|
/// explanation of the rule's purpose and rationale.
|
|
public let description: String
|
|
|
|
/// The `RuleKind` that best categorizes this rule.
|
|
public let kind: RuleKind
|
|
|
|
/// Swift source examples that do not trigger a violation for this rule. Used for documentation purposes to inform
|
|
/// users of various samples of code that are considered valid by this rule. Should be valid Swift syntax but is not
|
|
/// required to compile.
|
|
///
|
|
/// These examples are also used for automatic testing purposes. Tests will validate that the rule does not trigger
|
|
/// any violations for these examples.
|
|
public let nonTriggeringExamples: [Example]
|
|
|
|
/// Swift source examples that do trigger one or more violations for this rule. Used for documentation purposes to
|
|
/// inform users of various samples of code that are considered invalid by this rule. Should be valid Swift syntax
|
|
/// but is not required to compile.
|
|
///
|
|
/// Violations should occur where `↓` markers are located.
|
|
///
|
|
/// These examples are also used for automatic testing purposes. Tests will validate that the rule triggers
|
|
/// violations for these examples wherever `↓` markers are located.
|
|
public let triggeringExamples: [Example]
|
|
|
|
/// Pairs of Swift source examples, where keys are examples that trigger violations for this rule, and the values
|
|
/// are the expected value after applying corrections with the rule.
|
|
///
|
|
/// Rules that aren't correctable (conforming to the `CorrectableRule` protocol) should leave property empty.
|
|
///
|
|
/// These examples are used for testing purposes if the rule conforms to `AutomaticTestableRule`. Tests will
|
|
/// validate that the rule corrects all keys to their corresponding values.
|
|
public let corrections: [Example: Example]
|
|
|
|
/// Any previous iteration of the rule's identifier that was previously shipped with SwiftLint.
|
|
public let deprecatedAliases: Set<String>
|
|
|
|
/// The oldest version of the Swift compiler supported by this rule.
|
|
public let minSwiftVersion: SwiftVersion
|
|
|
|
/// Whether or not this rule can only be executed on a file physically on-disk. Typically necessary for rules
|
|
/// conforming to `AnalyzerRule`.
|
|
public let requiresFileOnDisk: Bool
|
|
|
|
/// The console-printable string for this description.
|
|
public var consoleDescription: String { return "\(name) (\(identifier)): \(description)" }
|
|
|
|
/// All identifiers that have been used to uniquely identify this rule in past and current SwiftLint versions.
|
|
public var allIdentifiers: [String] {
|
|
return Array(deprecatedAliases) + [identifier]
|
|
}
|
|
|
|
/// Creates a `RuleDescription` by specifying all its properties directly.
|
|
///
|
|
/// - parameter identifier: Sets the description's `identifier` property.
|
|
/// - parameter name: Sets the description's `name` property.
|
|
/// - parameter description: Sets the description's `description` property.
|
|
/// - parameter kind: Sets the description's `kind` property.
|
|
/// - parameter minSwiftVersion: Sets the description's `minSwiftVersion` property.
|
|
/// - parameter nonTriggeringExamples: Sets the description's `nonTriggeringExamples` property.
|
|
/// - parameter triggeringExamples: Sets the description's `triggeringExamples` property.
|
|
/// - parameter corrections: Sets the description's `corrections` property.
|
|
/// - parameter deprecatedAliases: Sets the description's `deprecatedAliases` property.
|
|
/// - parameter requiresFileOnDisk: Sets the description's `requiresFileOnDisk` property.
|
|
public init(identifier: String, name: String, description: String, kind: RuleKind,
|
|
minSwiftVersion: SwiftVersion = .five,
|
|
nonTriggeringExamples: [Example] = [], triggeringExamples: [Example] = [],
|
|
corrections: [Example: Example] = [:],
|
|
deprecatedAliases: Set<String> = [],
|
|
requiresFileOnDisk: Bool = false) {
|
|
self.identifier = identifier
|
|
self.name = name
|
|
self.description = description
|
|
self.kind = kind
|
|
self.nonTriggeringExamples = nonTriggeringExamples
|
|
self.triggeringExamples = triggeringExamples
|
|
self.corrections = corrections
|
|
self.deprecatedAliases = deprecatedAliases
|
|
self.minSwiftVersion = minSwiftVersion
|
|
self.requiresFileOnDisk = requiresFileOnDisk
|
|
}
|
|
|
|
// MARK: Equatable
|
|
|
|
public static func == (lhs: RuleDescription, rhs: RuleDescription) -> Bool {
|
|
return lhs.identifier == rhs.identifier
|
|
}
|
|
}
|