Files
2024-12-26 20:40:29 +01:00

41 lines
1.5 KiB
Swift

import SwiftSyntax
@SwiftSyntaxRule(optIn: true)
struct FlatMapOverMapReduceRule: Rule {
var configuration = SeverityConfiguration<Self>(.warning)
static let description = RuleDescription(
identifier: "flatmap_over_map_reduce",
name: "Flat Map over Map Reduce",
description: "Prefer `flatMap` over `map` followed by `reduce([], +)`",
kind: .performance,
nonTriggeringExamples: [
Example("let foo = bar.map { $0.count }.reduce(0, +)"),
Example("let foo = bar.flatMap { $0.array }"),
],
triggeringExamples: [
Example("let foo = ↓bar.map { $0.array }.reduce([], +)")
]
)
}
private extension FlatMapOverMapReduceRule {
final class Visitor: ViolationsSyntaxVisitor<ConfigurationType> {
override func visitPost(_ node: FunctionCallExprSyntax) {
guard
let memberAccess = node.calledExpression.as(MemberAccessExprSyntax.self),
memberAccess.declName.baseName.text == "reduce",
node.arguments.count == 2,
let firstArgument = node.arguments.first?.expression.as(ArrayExprSyntax.self),
firstArgument.elements.isEmpty,
let secondArgument = node.arguments.last?.expression.as(DeclReferenceExprSyntax.self),
secondArgument.baseName.text == "+"
else {
return
}
violations.append(node.positionAfterSkippingLeadingTrivia)
}
}
}