Files
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Idiomatic/UnavailableFunctionRule.swift
Danny Mösch 40bd97038a Support arbitrary configurations in @SwiftSyntaxRule (#5275)
Almost all rules based on SwiftSyntax can be set up now by just adding
`@SwiftSyntaxRule` to the rule struct.
2023-10-16 19:34:43 +02:00

172 lines
5.5 KiB
Swift

import SwiftSyntax
@SwiftSyntaxRule
struct UnavailableFunctionRule: OptInRule {
var configuration = SeverityConfiguration<Self>(.warning)
static let description = RuleDescription(
identifier: "unavailable_function",
name: "Unavailable Function",
description: "Unimplemented functions should be marked as unavailable",
kind: .idiomatic,
nonTriggeringExamples: [
Example("""
class ViewController: UIViewController {
@available(*, unavailable)
public required init?(coder aDecoder: NSCoder) {
preconditionFailure("init(coder:) has not been implemented")
}
}
"""),
Example("""
func jsonValue(_ jsonString: String) -> NSObject {
let data = jsonString.data(using: .utf8)!
let result = try! JSONSerialization.jsonObject(with: data, options: [])
if let dict = (result as? [String: Any])?.bridge() {
return dict
} else if let array = (result as? [Any])?.bridge() {
return array
}
fatalError()
}
"""),
Example("""
func resetOnboardingStateAndCrash() -> Never {
resetUserDefaults()
// Crash the app to re-start the onboarding flow.
fatalError("Onboarding re-start crash.")
}
""")
],
triggeringExamples: [
Example("""
class ViewController: UIViewController {
public required ↓init?(coder aDecoder: NSCoder) {
fatalError("init(coder:) has not been implemented")
}
}
"""),
Example("""
class ViewController: UIViewController {
public required ↓init?(coder aDecoder: NSCoder) {
let reason = "init(coder:) has not been implemented"
fatalError(reason)
}
}
"""),
Example("""
class ViewController: UIViewController {
public required ↓init?(coder aDecoder: NSCoder) {
preconditionFailure("init(coder:) has not been implemented")
}
}
"""),
Example("""
↓func resetOnboardingStateAndCrash() {
resetUserDefaults()
// Crash the app to re-start the onboarding flow.
fatalError("Onboarding re-start crash.")
}
""")
]
)
}
private extension UnavailableFunctionRule {
final class Visitor: ViolationsSyntaxVisitor<ConfigurationType> {
override func visitPost(_ node: FunctionDeclSyntax) {
guard !node.returnsNever,
!node.attributes.hasUnavailableAttribute,
node.body.containsTerminatingCall,
!node.body.containsReturn else {
return
}
violations.append(node.funcKeyword.positionAfterSkippingLeadingTrivia)
}
override func visitPost(_ node: InitializerDeclSyntax) {
guard !node.attributes.hasUnavailableAttribute,
node.body.containsTerminatingCall,
!node.body.containsReturn else {
return
}
violations.append(node.initKeyword.positionAfterSkippingLeadingTrivia)
}
}
}
private extension FunctionDeclSyntax {
var returnsNever: Bool {
if let expr = signature.returnClause?.type.as(IdentifierTypeSyntax.self) {
return expr.name.text == "Never"
}
return false
}
}
private extension AttributeListSyntax {
var hasUnavailableAttribute: Bool {
contains { elem in
guard let attr = elem.as(AttributeSyntax.self),
let arguments = attr.arguments?.as(AvailabilityArgumentListSyntax.self) else {
return false
}
let attributeName = attr.attributeNameText
return attributeName == "available" && arguments.contains { arg in
arg.argument.as(TokenSyntax.self)?.tokenKind.isUnavailableKeyword == true
}
}
}
}
private extension CodeBlockSyntax? {
var containsTerminatingCall: Bool {
guard let statements = self?.statements else {
return false
}
let terminatingFunctions: Set = [
"abort",
"fatalError",
"preconditionFailure"
]
return statements.contains { item in
guard let function = item.item.as(FunctionCallExprSyntax.self),
let identifierExpr = function.calledExpression.as(DeclReferenceExprSyntax.self) else {
return false
}
return terminatingFunctions.contains(identifierExpr.baseName.text)
}
}
var containsReturn: Bool {
guard let statements = self?.statements else {
return false
}
return ReturnFinderVisitor(viewMode: .sourceAccurate)
.walk(tree: statements, handler: \.containsReturn)
}
}
private final class ReturnFinderVisitor: SyntaxVisitor {
private(set) var containsReturn = false
override func visitPost(_ node: ReturnStmtSyntax) {
containsReturn = true
}
override func visit(_ node: ClosureExprSyntax) -> SyntaxVisitorContinueKind {
.skipChildren
}
override func visit(_ node: FunctionCallExprSyntax) -> SyntaxVisitorContinueKind {
.skipChildren
}
}