mirror of
https://github.com/realm/SwiftLint.git
synced 2026-05-07 20:12:49 +00:00
47335d7f95
Report number of corrections per file instead.
85 lines
3.4 KiB
Swift
85 lines
3.4 KiB
Swift
import SwiftSyntax
|
|
|
|
@SwiftSyntaxRule(explicitRewriter: true)
|
|
struct EmptyParenthesesWithTrailingClosureRule: Rule {
|
|
var configuration = SeverityConfiguration<Self>(.warning)
|
|
|
|
static let description = RuleDescription(
|
|
identifier: "empty_parentheses_with_trailing_closure",
|
|
name: "Empty Parentheses with Trailing Closure",
|
|
description: "When using trailing closures, empty parentheses should be avoided " +
|
|
"after the method call",
|
|
kind: .style,
|
|
nonTriggeringExamples: [
|
|
Example("[1, 2].map { $0 + 1 }"),
|
|
Example("[1, 2].map({ $0 + 1 })"),
|
|
Example("[1, 2].reduce(0) { $0 + $1 }"),
|
|
Example("[1, 2].map { number in\n number + 1 \n}"),
|
|
Example("let isEmpty = [1, 2].isEmpty()"),
|
|
Example("""
|
|
UIView.animateWithDuration(0.3, animations: {
|
|
self.disableInteractionRightView.alpha = 0
|
|
}, completion: { _ in
|
|
()
|
|
})
|
|
"""),
|
|
],
|
|
triggeringExamples: [
|
|
Example("[1, 2].map↓() { $0 + 1 }"),
|
|
Example("[1, 2].map↓( ) { $0 + 1 }"),
|
|
Example("[1, 2].map↓() { number in\n number + 1 \n}"),
|
|
Example("[1, 2].map↓( ) { number in\n number + 1 \n}"),
|
|
Example("func foo() -> [Int] {\n return [1, 2].map↓() { $0 + 1 }\n}"),
|
|
],
|
|
corrections: [
|
|
Example("[1, 2].map↓() { $0 + 1 }"): Example("[1, 2].map { $0 + 1 }"),
|
|
Example("[1, 2].map↓( ) { $0 + 1 }"): Example("[1, 2].map { $0 + 1 }"),
|
|
Example("[1, 2].map↓() { number in\n number + 1 \n}"):
|
|
Example("[1, 2].map { number in\n number + 1 \n}"),
|
|
Example("[1, 2].map↓( ) { number in\n number + 1 \n}"):
|
|
Example("[1, 2].map { number in\n number + 1 \n}"),
|
|
Example("func foo() -> [Int] {\n return [1, 2].map↓() { $0 + 1 }\n}"):
|
|
Example("func foo() -> [Int] {\n return [1, 2].map { $0 + 1 }\n}"),
|
|
Example("class C {\n#if true\nfunc f() {\n[1, 2].map↓() { $0 + 1 }\n}\n#endif\n}"):
|
|
Example("class C {\n#if true\nfunc f() {\n[1, 2].map { $0 + 1 }\n}\n#endif\n}"),
|
|
]
|
|
)
|
|
}
|
|
|
|
private extension EmptyParenthesesWithTrailingClosureRule {
|
|
final class Visitor: ViolationsSyntaxVisitor<ConfigurationType> {
|
|
override func visitPost(_ node: FunctionCallExprSyntax) {
|
|
guard let position = node.violationPosition else {
|
|
return
|
|
}
|
|
|
|
violations.append(position)
|
|
}
|
|
}
|
|
|
|
final class Rewriter: ViolationsSyntaxRewriter<ConfigurationType> {
|
|
override func visit(_ node: FunctionCallExprSyntax) -> ExprSyntax {
|
|
guard node.violationPosition != nil else {
|
|
return super.visit(node)
|
|
}
|
|
numberOfCorrections += 1
|
|
let newNode = node
|
|
.with(\.leftParen, nil)
|
|
.with(\.rightParen, nil)
|
|
.with(\.trailingClosure, node.trailingClosure?.with(\.leadingTrivia, .spaces(1)))
|
|
return super.visit(newNode)
|
|
}
|
|
}
|
|
}
|
|
|
|
private extension FunctionCallExprSyntax {
|
|
var violationPosition: AbsolutePosition? {
|
|
guard trailingClosure != nil,
|
|
let leftParen,
|
|
arguments.isEmpty else {
|
|
return nil
|
|
}
|
|
return leftParen.positionAfterSkippingLeadingTrivia
|
|
}
|
|
}
|