Files
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Style/EmptyParametersRule.swift
Danny Mösch 47335d7f95 Remove tracking of correction positions (#5950)
Report number of corrections per file instead.
2025-04-05 06:04:37 -04:00

73 lines
2.8 KiB
Swift

import SwiftSyntax
@SwiftSyntaxRule(explicitRewriter: true)
struct EmptyParametersRule: Rule {
var configuration = SeverityConfiguration<Self>(.warning)
static let description = RuleDescription(
identifier: "empty_parameters",
name: "Empty Parameters",
description: "Prefer `() -> ` over `Void -> `",
kind: .style,
nonTriggeringExamples: [
Example("let abc: () -> Void = {}"),
Example("func foo(completion: () -> Void)"),
Example("func foo(completion: () throws -> Void)"),
Example("let foo: (ConfigurationTests) -> Void throws -> Void)"),
Example("let foo: (ConfigurationTests) -> Void throws -> Void)"),
Example("let foo: (ConfigurationTests) ->Void throws -> Void)"),
],
triggeringExamples: [
Example("let abc: ↓(Void) -> Void = {}"),
Example("func foo(completion: ↓(Void) -> Void)"),
Example("func foo(completion: ↓(Void) throws -> Void)"),
Example("let foo: ↓(Void) -> () throws -> Void)"),
],
corrections: [
Example("let abc: ↓(Void) -> Void = {}"): Example("let abc: () -> Void = {}"),
Example("func foo(completion: ↓(Void) -> Void)"): Example("func foo(completion: () -> Void)"),
Example("func foo(completion: ↓(Void) throws -> Void)"):
Example("func foo(completion: () throws -> Void)"),
Example("let foo: ↓(Void) -> () throws -> Void)"): Example("let foo: () -> () throws -> Void)"),
]
)
}
private extension EmptyParametersRule {
final class Visitor: ViolationsSyntaxVisitor<ConfigurationType> {
override func visitPost(_ node: FunctionTypeSyntax) {
guard let violationPosition = node.emptyParametersViolationPosition else {
return
}
violations.append(violationPosition)
}
}
final class Rewriter: ViolationsSyntaxRewriter<ConfigurationType> {
override func visit(_ node: FunctionTypeSyntax) -> TypeSyntax {
guard node.emptyParametersViolationPosition != nil else {
return super.visit(node)
}
numberOfCorrections += 1
return super.visit(node.with(\.parameters, TupleTypeElementListSyntax([])))
}
}
}
private extension FunctionTypeSyntax {
var emptyParametersViolationPosition: AbsolutePosition? {
guard
let argument = parameters.onlyElement,
leftParen.presence == .present,
rightParen.presence == .present,
let simpleType = argument.type.as(IdentifierTypeSyntax.self),
simpleType.typeName == "Void"
else {
return nil
}
return leftParen.positionAfterSkippingLeadingTrivia
}
}