Files
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Lint/TestCaseAccessibilityRule.swift
2024-12-27 09:58:53 +01:00

142 lines
5.4 KiB
Swift

import SwiftSyntax
@SwiftSyntaxRule(correctable: true, optIn: true)
struct TestCaseAccessibilityRule: Rule {
var configuration = TestCaseAccessibilityConfiguration()
static let description = RuleDescription(
identifier: "test_case_accessibility",
name: "Test Case Accessibility",
description: "Test cases should only contain private non-test members",
kind: .lint,
nonTriggeringExamples: TestCaseAccessibilityRuleExamples.nonTriggeringExamples,
triggeringExamples: TestCaseAccessibilityRuleExamples.triggeringExamples,
corrections: TestCaseAccessibilityRuleExamples.corrections
)
}
private extension TestCaseAccessibilityRule {
final class Visitor: ViolationsSyntaxVisitor<ConfigurationType> {
override var skippableDeclarations: [any DeclSyntaxProtocol.Type] { .all }
override func visitPost(_ node: ClassDeclSyntax) {
guard !configuration.testParentClasses.isDisjoint(with: node.inheritedTypes) else {
return
}
XCTestClassVisitor(configuration: configuration, file: file)
.walk(tree: node.memberBlock, handler: \.violations)
.forEach { violation in
let position = violation.position
violations.append(
ReasonedRuleViolation(
position: position,
correction: .init(start: position, end: position, replacement: "private ")
)
)
}
}
}
final class XCTestClassVisitor: ViolationsSyntaxVisitor<ConfigurationType> {
override var skippableDeclarations: [any DeclSyntaxProtocol.Type] { .all }
override func visitPost(_ node: VariableDeclSyntax) {
guard !node.modifiers.containsPrivateOrFileprivate(),
!XCTestHelpers.isXCTestVariable(node) else {
return
}
for binding in node.bindings {
guard let pattern = binding.pattern.as(IdentifierPatternSyntax.self),
case let name = pattern.identifier.text,
!configuration.allowedPrefixes.contains(where: name.hasPrefix) else {
continue
}
violations.append(node.bindingSpecifier.positionAfterSkippingLeadingTrivia)
return
}
}
override func visitPost(_ node: FunctionDeclSyntax) {
guard hasViolation(modifiers: node.modifiers, identifierToken: node.name),
!XCTestHelpers.isXCTestFunction(node) else {
return
}
violations.append(node.positionAfterSkippingLeadingTrivia)
}
override func visitPost(_ node: ClassDeclSyntax) {
if hasViolation(modifiers: node.modifiers, identifierToken: node.name) {
violations.append(node.classKeyword.positionAfterSkippingLeadingTrivia)
}
}
override func visitPost(_ node: EnumDeclSyntax) {
if hasViolation(modifiers: node.modifiers, identifierToken: node.name) {
violations.append(node.enumKeyword.positionAfterSkippingLeadingTrivia)
}
}
override func visitPost(_ node: StructDeclSyntax) {
if hasViolation(modifiers: node.modifiers, identifierToken: node.name) {
violations.append(node.structKeyword.positionAfterSkippingLeadingTrivia)
}
}
override func visitPost(_ node: ActorDeclSyntax) {
if hasViolation(modifiers: node.modifiers, identifierToken: node.name) {
violations.append(node.actorKeyword.positionAfterSkippingLeadingTrivia)
}
}
override func visitPost(_ node: TypeAliasDeclSyntax) {
if hasViolation(modifiers: node.modifiers, identifierToken: node.name) {
violations.append(node.typealiasKeyword.positionAfterSkippingLeadingTrivia)
}
}
private func hasViolation(modifiers: DeclModifierListSyntax, identifierToken: TokenSyntax) -> Bool {
!modifiers.containsPrivateOrFileprivate()
&& !configuration.allowedPrefixes.contains(where: identifierToken.text.hasPrefix)
}
}
}
private extension ClassDeclSyntax {
var inheritedTypes: [String] {
inheritanceClause?.inheritedTypes.compactMap { type in
type.type.as(IdentifierTypeSyntax.self)?.name.text
} ?? []
}
}
private enum XCTestHelpers {
private static let testVariableNames: Set = [
"allTests"
]
static func isXCTestFunction(_ function: FunctionDeclSyntax) -> Bool {
guard !function.modifiers.contains(keyword: .override) else {
return true
}
return !function.modifiers.containsStaticOrClass &&
function.name.text.hasPrefix("test") &&
function.signature.parameterClause.parameters.isEmpty
}
static func isXCTestVariable(_ variable: VariableDeclSyntax) -> Bool {
guard !variable.modifiers.contains(keyword: .override) else {
return true
}
return
variable.modifiers.containsStaticOrClass &&
variable.bindings
.compactMap { $0.pattern.as(IdentifierPatternSyntax.self)?.identifier.text }
.allSatisfy(testVariableNames.contains)
}
}