import SwiftSyntax @SwiftSyntaxRule struct PatternMatchingKeywordsRule: OptInRule { var configuration = SeverityConfiguration(.warning) static let description = RuleDescription( identifier: "pattern_matching_keywords", name: "Pattern Matching Keywords", description: "Combine multiple pattern matching bindings by moving keywords out of tuples", kind: .idiomatic, nonTriggeringExamples: [ Example("default"), Example("case 1"), Example("case bar"), Example("case let (x, y)"), Example("case .foo(let x)"), Example("case let .foo(x, y)"), Example("case .foo(let x), .bar(let x)"), Example("case .foo(let x, var y)"), Example("case var (x, y)"), Example("case .foo(var x)"), Example("case var .foo(x, y)") ].map(wrapInSwitch), triggeringExamples: [ Example("case (↓let x, ↓let y)"), Example("case (↓let x, ↓let y, .foo)"), Example("case (↓let x, ↓let y, _)"), Example("case .foo(↓let x, ↓let y)"), Example("case (.yamlParsing(↓let x), .yamlParsing(↓let y))"), Example("case (↓var x, ↓var y)"), Example("case .foo(↓var x, ↓var y)"), Example("case (.yamlParsing(↓var x), .yamlParsing(↓var y))") ].map(wrapInSwitch) ) } private extension PatternMatchingKeywordsRule { final class Visitor: ViolationsSyntaxVisitor { override func visitPost(_ node: SwitchCaseItemSyntax) { let localViolations = TupleVisitor(configuration: configuration, file: file) .walk(tree: node.pattern, handler: \.violations) violations.append(contentsOf: localViolations) } } } private final class TupleVisitor: ViolationsSyntaxVisitor { override func visitPost(_ node: LabeledExprListSyntax) { let list = node.flatteningEnumPatterns() .compactMap { elem in elem.expression.asValueBindingPattern() } guard list.count > 1, let firstLetOrVar = list.first?.bindingSpecifier.tokenKind else { return } let hasViolation = list.allSatisfy { elem in elem.bindingSpecifier.tokenKind == firstLetOrVar } guard hasViolation else { return } violations.append(contentsOf: list.compactMap { elem in return elem.bindingSpecifier.positionAfterSkippingLeadingTrivia }) } } private extension LabeledExprListSyntax { func flatteningEnumPatterns() -> [LabeledExprSyntax] { flatMap { elem in guard let pattern = elem.expression.as(FunctionCallExprSyntax.self), pattern.calledExpression.is(MemberAccessExprSyntax.self) else { return [elem] } return Array(pattern.arguments) } } } private extension ExprSyntax { func asValueBindingPattern() -> ValueBindingPatternSyntax? { if let pattern = self.as(PatternExprSyntax.self) { return pattern.pattern.as(ValueBindingPatternSyntax.self) } return nil } } private func wrapInSwitch(_ example: Example) -> Example { return example.with(code: """ switch foo { \(example.code): break } """) }