Commit Graph

1296 Commits

Author SHA1 Message Date
Ornithologist Coder f6dc900400 Adds more examples with closures 2017-10-21 10:58:10 +02:00
Ornithologist Coder d356fbb8cf Fix false positive in multiline_parameters rule
when parameter is a closure has default value. Fixes #1912.
2017-10-21 10:58:03 +02:00
JP Simard 95f40be8bc Add catch to the statements checked by the control_statement rule 2017-10-20 12:28:07 -07:00
Ornithologist Coder c1a63db729 Adds xitBehavesLike 2017-10-17 16:06:05 +02:00
Ornithologist Coder f84354f3e0 Fixes indentation 2017-10-17 15:48:14 +02:00
Ornithologist Coder c7e3692ddf Adds quick_discouraged_pending_test opt-in rule
Implements #1909.
2017-10-17 14:49:36 +02:00
JP Simard 234f987445 Merge pull request #1904 from ornithocoder/quick_calls
Adds [f,x]{describe, context, itBehavesLike} to quick_discouraged_call rule
2017-10-16 13:31:09 -07:00
Ornithologist Coder 98cc4e083e Moves examples to another file 2017-10-16 08:54:37 +02:00
Ornithologist Coder c4b0053ed0 Adds fitBehavesLike and xitBehavesLike 2017-10-16 06:48:56 +02:00
Ornithologist Coder d039434b5c Adds fitBehavesLike 2017-10-16 06:35:01 +02:00
Ornithologist Coder b12280cfc2 Adds opt-in quick_discouraged_focused_test rule
Implements #1905.
2017-10-15 23:14:35 +02:00
Ornithologist Coder 61e19ea47f Adds [f,x]{describe, context, it} to Quick Call rule
* fdescribe
* fcontext
* fi
* xdescribe
* xcontext
* xit

are valid Quick calls and should not trigger this violation.

There should be another SwiftLint rule to discourage the use of focused
tests, so people don't commit and push code with focused tests.
2017-10-15 16:31:06 +02:00
Marcelo Fabri a45a7da03f Make rule opt-in 2017-10-08 21:03:55 -03:00
Marcelo Fabri c384ec4f19 Don’t trigger violations for extensions in same file 2017-10-07 20:28:11 -03:00
Marcelo Fabri f971d4bc39 Add override_in_extension rule
Fixes #1884
2017-10-07 19:33:59 -03:00
Marcelo Fabri e84100eed4 Remove SwiftExpressionKind.other 2017-10-05 14:33:32 -03:00
JP Simard 60ffa73253 Remove intermediate closure 2017-10-04 14:41:08 -07:00
Marcelo Fabri 0be8c855d2 Move functions to properties and Sets instead of Arrays 2017-10-04 14:34:00 -07:00
JP Simard c57c47d66f Remove unnecessary Swift version differences 2017-10-04 13:49:40 -07:00
Marcelo Fabri ee02e0f8e5 Remove support for building with Swift 3.1 2017-10-04 13:48:17 -07:00
Marcelo Fabri c585ee9568 Fix false positive in array_init when using map without closure
Fixes #1878
2017-10-04 01:24:16 -03:00
Marcelo Fabri aa88d5a707 Fix existing violations 2017-10-02 02:09:53 -03:00
Marcelo Fabri 81b832c372 Add literal_expression_end_indentation opt-in rule 2017-10-02 02:09:45 -03:00
Marcelo Fabri 192411f9c4 Add unneeded_break_in_switch rule
Fixes #1870
2017-10-02 00:21:27 -03:00
Marcelo Fabri 41f8b1971d Merge pull request #1862 from sirlantis/add-new-multiline-arguments-rule
Add MultilineArgumentsRule
2017-10-02 00:20:28 -03:00
Marcelo Fabri 05685785f2 Merge pull request #1864 from marcelofabri/improve-allowed-symbols
Fix false negatives when using allowed_symbols
2017-10-01 01:11:46 -03:00
Marcelo Fabri ffa4e8a3fb Workaround union not working on Linux on Swift 3.1 2017-10-01 00:45:52 -03:00
Marcelo Fabri be341f90b9 Introduce queuedFatalError
`fatalError` prints the full path of the file, which leaks filesystem information from the machine that built the binary. Now that we release via CocoaPods, this is more critical.
2017-09-30 15:07:23 -03:00
Marcelo Fabri e24d847596 Prevent crash on Swift 3.x 2017-09-30 01:38:26 -03:00
Marcelo Fabri 06f9d4c0f7 Fix false negatives when using allowed_symbols 2017-09-30 00:50:30 -03:00
Marcelo Fabri dc3991ad27 Fix failing test 2017-09-30 00:29:23 -03:00
Marcelo Fabri d21262d1bc Ignore SwiftLint commands in file_header rule
Fixes #1810
2017-09-30 00:29:23 -03:00
Marcel Jackwerth e9d65e3b5d MultilineArgumentsRuleConfiguration -> MultilineArgumentsConfiguration 2017-09-30 01:28:45 +02:00
Marcel Jackwerth b97dc5814f Refactor MultilineArgumentsRuleConfiguration 2017-09-30 01:26:29 +02:00
Marcel Jackwerth c435475c2c Added first_argument_location option 2017-09-30 01:01:56 +02:00
Marcel Jackwerth 4899c0b171 Add a few more examples 2017-09-29 23:08:46 +02:00
Marcel Jackwerth 25ad3f0d1d Fix some and add more tests 2017-09-29 23:08:46 +02:00
Marcel Jackwerth 4945ee29b7 Add MultilineArgumentsRule 2017-09-29 23:08:46 +02:00
JP Simard b228a4ffa6 Speed up LetVarWhitespaceRule.attributeLineNumbers(file:)
By treating each .attributeBuiltin as a match rather than performing
a regular expression along with many byte offset to string offset
conversions.
2017-09-28 17:06:20 -07:00
Marcelo Fabri a0e0824b59 Fix false positive in class_delegate_protocol with Swift 4.0.1
Fixes #1856
2017-09-28 14:11:15 -03:00
JP Simard 6367d541b2 Improve compile time by speeding up slow type inference expressions 2017-09-19 17:26:24 -07:00
JP Simard eb9acae04d Revert use of NSRange.contains(_:) added in b3340c3
Since that's only available in Swift 4.0 or later, and we still support
Swift 3.x.
2017-09-19 11:10:35 -07:00
JP Simard b3340c30b3 Small changes to ContainsOverFirstNotNilRule 2017-09-17 16:50:58 -07:00
Samuel Susla 9dcb3dbeb7 Add contains_over_first_not_nil rule 2017-09-17 15:59:40 +01:00
Marcelo Fabri 3431f2e455 Fix unit tests on Linux with Swift 3.1 2017-09-16 13:34:19 -03:00
Marcelo Fabri 4c8d25185b Fix false positives 2017-09-16 04:27:56 -03:00
Marcelo Fabri 8f05f92cd1 Add array_init opt-in rule
Fixes #1271
2017-09-16 02:32:48 -03:00
Marcelo Fabri 07e011e237 Refactor isCommentLike to use existing list 2017-09-16 02:26:26 -03:00
Marcelo Fabri 038af4effb Merge pull request #1839 from marcelofabri/function-call-colon
Add support to function calls on `colon` rule
2017-09-14 16:58:39 -03:00
Marcelo Fabri b5f51bb761 Fix false positive in for_where with if var
Fixes #1838
2017-09-14 11:10:28 -03:00