Commit Graph

604 Commits

Author SHA1 Message Date
JP Simard f0804fa51c fix some false positives in detecting for initializers
in function_parameter_count
2016-12-07 16:24:54 -08:00
Denis Lebedev 427a0c3b6f Replace contains with hasPrefix 2016-12-07 15:58:43 -08:00
Denis Lebedev 74ae00b1c7 Ignore initializers parameter count 2016-12-07 15:57:18 -08:00
Marcelo Fabri 0fb4c6d691 Handling signals 2016-12-06 22:09:34 -02:00
Marcelo Fabri 2340056932 Handling exponentials 2016-12-06 22:00:19 -02:00
Marcelo Fabri 00a891ad29 Handle other formats than decimal 2016-12-06 21:52:24 -02:00
Marcelo Fabri 27456823e3 Add number_separator opt-in rule
Fixes #924
2016-12-06 00:17:28 -02:00
Philip Webster 340f78c6b3 omit trailing commas 2016-12-03 14:41:22 -08:00
Philip Webster 0c6674186c delegate suffix example 2016-12-02 11:13:53 -08:00
Philip Webster e08f6d6f54 match strong delegate suffix 2016-12-01 22:49:40 -08:00
JP Simard 576e1a5d4d remove unnecessary .lowercased() calls
now that ViolationSeverity is already lowercase.
2016-12-01 22:29:09 -08:00
JP Simard 19fad01b29 make all enum members lowercase to comply with Swift 3 API Guidelines 2016-12-01 22:16:21 -08:00
JP Simard 0b481f1e16 change Array.arrayOf(_:) to Array.array(of:) 2016-12-01 18:09:38 -08:00
JP Simard c305f2b485 remove unnecessary swiftlint:disable command 2016-12-01 00:38:10 -08:00
JP Simard 39e1001629 make lots of Swift 3 related changes
many of which are to help with otherwise very long compile times
2016-12-01 00:34:29 -08:00
JP Simard b238438381 Merge branch 'master' into swift3.0
* master:
  optimize MarkRule.violationRangesInFile() a tiny bit
  fix missing variable rename
  fix #778
2016-11-30 22:50:30 -08:00
JP Simard 4bb82285d6 optimize MarkRule.violationRangesInFile() a tiny bit
instead of allocating a SyntaxKind for all syntax tokens, we just
care about the first one.
2016-11-30 21:55:31 -08:00
JP Simard 98e8c87397 fix missing variable rename 2016-11-30 21:51:39 -08:00
JP Simard fc2e887315 fix #778 2016-11-30 21:38:14 -08:00
Norio Nomura 4aa4322991 Merge branch 'master' into swift3.0
* master:
  TrailingCommaRule only triggers when multi-line
2016-12-01 11:39:02 +09:00
Norio Nomura b672f27717 Fix build error on SPM 2016-12-01 10:42:01 +09:00
Marcelo Fabri 485518faef TrailingCommaRule only triggers when multi-line
Fixes #910 and #911
2016-11-30 19:02:12 -02:00
Norio Nomura 363bcf5c73 Merge branch 'master' into swift3.0
* master:
  add empty changelog section
  update Releasing.md with `brew bump-formula-pr`
  0.13.1: Heavy Cycle
  remove unused function dictFromKeyValuePairs
  add tests for reporterFromString(_:)
  small refactoring of SwitchCaseOnNewlineRule.swift

# Conflicts:
#	Source/SwiftLintFramework/Extensions/File+Cache.swift
#	Source/SwiftLintFramework/Rules/SwitchCaseOnNewlineRule.swift
2016-11-30 22:33:16 +09:00
Norio Nomura b7862b9f6a Merge commit 'e0cafea80ffba746a103d8d5a25be8fcd0993c81' into swift3.0
* commit 'e0cafea80ffba746a103d8d5a25be8fcd0993c81':
  remove unnecessary file.invalidateCache()
  add changelog entry for #893
  fix up indentation in MarkRule.swift
  omit self if it can be inferred
  Corrections for mark rule
  Update regex part to be more precise.
  Add autocorrection to MarkRule

# Conflicts:
#	Source/SwiftLintFramework/Rules/ConditionalReturnsOnNewline.swift
#	Source/SwiftLintFramework/Rules/MarkRule.swift
#	Source/SwiftLintFramework/Rules/StatementPositionRule.swift
2016-11-30 22:26:51 +09:00
Norio Nomura 48b25b6aab Merge commit '83830861d6c6b7fee3218461f699c7d3b457bf2a' into swift3.0
* commit '83830861d6c6b7fee3218461f699c7d3b457bf2a':
  refactor isPrivateLevel(identifier:)
  refactor nameStrippingLeadingUnderscoreIfPrivate
  combine changelog entries for #781 and #831
  Add support for filePrivate and open in rules

# Conflicts:
#	Source/SwiftLintFramework/Extensions/String+SwiftLint.swift
#	Source/SwiftLintFramework/Rules/MissingDocsRule.swift
2016-11-30 20:16:47 +09:00
Norio Nomura 20a597e683 Merge commit 'b9ac89376d7aad517ef215c400c04b90bb3d2ee9' into swift3.0
* commit 'b9ac89376d7aad517ef215c400c04b90bb3d2ee9':
  fix some issues with ExplicitInitRule.swift

# Conflicts:
#	Source/SwiftLintFramework/Rules/ExplicitInitRule.swift
2016-11-30 20:08:16 +09:00
Norio Nomura 0f203bf32d Merge commit '60852d7b5746f789f28d8e292c40fc629f8f7969' into swift3.0
* commit '60852d7b5746f789f28d8e292c40fc629f8f7969':
  Fix ValidIBInspectable rule implementation
2016-11-30 19:42:46 +09:00
Norio Nomura 191e022ca2 Merge commit 'e63c6ce4172f201554ab70c0e4fec694d82d8f60' into swift3.0
* commit 'e63c6ce4172f201554ab70c0e4fec694d82d8f60':
  Use severityConfiguration in rules == function
2016-11-30 19:41:44 +09:00
Norio Nomura f1e7311575 Fix trailing_comma violations 2016-11-30 19:41:28 +09:00
Norio Nomura 84ca11b6aa Merge commit 'b22d1a93c93537acde79a2496031012489fe270d' into swift3.0
* commit 'b22d1a93c93537acde79a2496031012489fe270d':
  Updating CHANGELOG entry
  Updates existing code to respect TrailingCommaRule
  Add configuration to enforce/forbid trailing comma
  Fixing rebase
  Addded TrailingCommaRule
2016-11-30 19:38:31 +09:00
Norio Nomura 06e0e83ad4 Merge commit 'ad019afd7124c07ef34fb22e6165976116202477' into swift3.0
* commit 'ad019afd7124c07ef34fb22e6165976116202477':
  move #872 fix to appropriate changelog section
  closure_spacing accepts empty bodies with a space

# Conflicts:
#	Source/SwiftLintFramework/Rules/ClosureSpacingRule.swift
2016-11-30 19:18:27 +09:00
Norio Nomura b94f2cc292 Merge commit '0dc882b0801c03fcc52d7c4eed72fa5f68f32370' into swift3.0
* commit '0dc882b0801c03fcc52d7c4eed72fa5f68f32370':
  Improving comma rule to support expressions that begin with the comma (fixes a gap when there are consecutive comma violations)
  Improving comma rule to support expressions that begin with the comma (fixes a gap when there are consecutive comma violations)

# Conflicts:
#	Source/SwiftLintFramework/Rules/CommaRule.swift
2016-11-30 19:14:41 +09:00
Norio Nomura 63a2b207b4 Merge commit 'e65437cd7a7a1e97f68ddb62d572952d74fa3876' into swift3.0
* commit 'e65437cd7a7a1e97f68ddb62d572952d74fa3876':
  Fixing #878
  `switch_case_on_newline` should ignore trailing comments

# Conflicts:
#	Source/SwiftLintFramework/Rules/SwitchCaseOnNewlineRule.swift
2016-11-30 19:08:05 +09:00
Norio Nomura 1d7fbe17eb Merge commit '3ce57ba71ac2167d44aae39095475669bb5ec98c' into swift3.0
* commit '3ce57ba71ac2167d44aae39095475669bb5ec98c':
  Add NimbleOperatorRule
2016-11-30 18:50:24 +09:00
Norio Nomura 7c12a63e8f Merge commit '58eb0f69c4055bb2cb89b3df278eca6ce0fb1c34' into swift3.0
* commit '58eb0f69c4055bb2cb89b3df278eca6ce0fb1c34':
  generally clean up usage of swiftlint comment commands
  update README to reflect the ability to specify multiple rules in commands
  add changelog entry
  allow specifying multiple rule identifiers in comment commands

# Conflicts:
#	Source/SwiftLintFramework/Extensions/NSRegularExpression+SwiftLint.swift
#	Source/SwiftLintFramework/Models/Command.swift
#	Source/SwiftLintFramework/Rules/LegacyNSGeometryFunctionsRule.swift
#	Tests/SwiftLintFrameworkTests/ConfigurationTests.swift
#	Tests/SwiftLintFrameworkTests/IntegrationTests.swift
2016-11-30 18:42:40 +09:00
Norio Nomura 636efb5b14 Merge commit 'aeb5d7ae442d6b590e7693a7214098a9328f951a' into swift3.0
* commit 'aeb5d7ae442d6b590e7693a7214098a9328f951a':
  Updating changelog
  Updating regex after PR feedback
  Adding SyntacticSugar rule

# Conflicts:
#	Source/SwiftLintFramework/Extensions/File+Cache.swift
2016-11-30 18:10:10 +09:00
Norio Nomura e922e08c5b Merge commit '6ffab45c2b6ee9c3532afa2f647d34daf320be1d' into swift3.0
* commit '6ffab45c2b6ee9c3532afa2f647d34daf320be1d':
  Fix severity configuration in ColonRule

# Conflicts:
#	Source/SwiftLintFramework/Rules/ColonRule.swift
2016-11-30 17:44:49 +09:00
Norio Nomura b9426fb78e Merge commit '487f8cccdfe27771f6cd9ec46470a3b3578eaec4' into swift3.0
* commit '487f8cccdfe27771f6cd9ec46470a3b3578eaec4':
  fix changelog entry: weak rule isn't opt-in
  minor WeakDelegateRule formatting
  fix up changelog entry
  [weak_delegate] Better code style for testing string matching
  Thinking back about it, WeakDelegate rule should in fact maybe not be Opt-In, but rather enabled by default
  Additional code comments
  [New Rule] weak_delegate
2016-11-30 17:27:44 +09:00
Norio Nomura 7593deff3f Merge commit 'b591ec71085572825616e9ac0ed15450198b52bb' into swift3.0
* commit 'b591ec71085572825616e9ac0ed15450198b52bb':
  minor Tests comment formatting
  ValidIBInspectableRule formatting
  fix typo in OverriddenSuperCallRule file name

# Conflicts:
#	Source/SwiftLintFramework/Rules/ValidIBInspectableRule.swift
2016-11-30 17:14:40 +09:00
Norio Nomura 5d1a3c225a Merge commit '4072ca298193bac6c1d068c2fa6eba5ea82fc99d' into swift3.0
* commit '4072ca298193bac6c1d068c2fa6eba5ea82fc99d':
  OverriddenSuperCallRule formatting
  comment indentation
  ClosureSpacingRule formatting

# Conflicts:
#	Source/SwiftLintFramework/Rules/ClosureSpacingRule.swift
#	Source/SwiftLintFramework/Rules/LegacyCGGeometryFunctionsRule.swift
#	Source/SwiftLintFramework/Rules/OverridenSuperCallRule.swift
2016-11-30 14:57:08 +09:00
Norio Nomura 5b41474f56 Merge commit '1f98e72e179f07947ecf2679a685dac7255d50f3' into swift3.0
* commit '1f98e72e179f07947ecf2679a685dac7255d50f3':
  small formatting fixes to ImplicitGetterRule

# Conflicts:
#	Source/SwiftLintFramework/Rules/ImplicitGetterRule.swift
2016-11-30 14:35:25 +09:00
Norio Nomura 397b3ad8fc Merge commit '1151c1883100fc2c65450a9266a06e0c9a4c83b3' into swift3.0
* commit '1151c1883100fc2c65450a9266a06e0c9a4c83b3':
  Updating changelog
  Rewriting rule to deal with nested structures
  Add ImplicitGetterRule
2016-11-30 14:14:24 +09:00
Norio Nomura abecb87672 Merge commit 'aa520f35481c7a83f9c94f217d48919bd37432fa' into swift3.0
* commit 'aa520f35481c7a83f9c94f217d48919bd37432fa':
  make minor changes to tests for ACL or reusing existing constants

# Conflicts:
#	Tests/SwiftLintFrameworkTests/TestHelpers.swift
2016-11-30 13:01:00 +09:00
Norio Nomura aaf008c527 Merge commit '8f140ffdfe13c4f17398aa2d1256e2ed95bfdfe6' into swift3.0
* commit '8f140ffdfe13c4f17398aa2d1256e2ed95bfdfe6':
  improve debugging failing tests due to mismatched violation locations
  fix MarkRule edge cases

# Conflicts:
#	Source/SwiftLintFramework/Rules/MarkRule.swift
2016-11-30 12:54:47 +09:00
JP Simard 7d94f2b461 small refactoring of SwitchCaseOnNewlineRule.swift 2016-11-28 22:59:04 -08:00
JP Simard ed70259198 remove unnecessary file.invalidateCache()
this is already called in Linter.correct() if corrections were applied
2016-11-28 22:43:02 -08:00
JP Simard 0b39dec1b0 fix up indentation in MarkRule.swift 2016-11-28 22:30:31 -08:00
JP Simard 99005133de Merge pull request #893 from kohtenko/master
Add autocorrection to MarkRule
2016-11-28 22:28:25 -08:00
JP Simard 4bb23dd75a omit self if it can be inferred 2016-11-28 22:18:56 -08:00
JP Simard 83830861d6 Merge pull request #905 from marcelofabri/swift3-acls
Add support for Swift 3 ACLs (open & fileprivate) in existing rules
2016-11-28 22:02:55 -08:00