Commit Graph

100 Commits

Author SHA1 Message Date
Sebastian Grail 2d27db5e1f Fix typo in FunctionBodyLengthRule and TypeBodyLengthRule 2016-01-04 15:38:54 +11:00
JP Simard 1e553a54bb fix ConfigurationTests
by moving String.stringByAppendingPathComponent to the test

also remove @testable annotation because it is unused
2016-01-02 16:06:32 -08:00
Scott Hoyt 6c2adce0cf Cleaned up project mock *.yml's. 2016-01-02 15:41:53 -08:00
Scott Hoyt 246adf6353 No longer needed RuleMocks at global scope. 2016-01-02 15:41:53 -08:00
Scott Hoyt 39a0953f32 Replace manual config mocks with file-driven. 2016-01-02 15:41:53 -08:00
Scott Hoyt 314f72a7d7 Added Nested Configuration testing. 2016-01-02 15:41:53 -08:00
Scott Hoyt 5b023501c2 Tested merge. 2016-01-02 15:41:53 -08:00
Scott Hoyt 369ef23c1f Extracted Configuration mocks to test class constants. 2016-01-02 15:41:53 -08:00
Scott Hoyt 7b2f4bff43 Moved == implementation for [Rule] to more appropriate spot. Wrote missing test. 2016-01-02 15:41:53 -08:00
Scott Hoyt fcf9396a08 Added isEqual for Rule and ParameterizedRule. Made Configuration and RuleParameter conform to Equatable. Wrote tests to verify. All done in support of testing recursive configuration file search. 2016-01-02 15:41:53 -08:00
JP Simard c8fa4e08f2 only generate violations once for triggering examples in verifyRule() 2015-12-27 21:51:06 -05:00
JP Simard 85d8c68978 test violation locations 2015-12-27 13:33:42 -05:00
JP Simard e546ecb094 add checkstyle reporter. addresses #277 2015-12-25 02:31:38 -05:00
Yasuhiro Inami 05efe54d28 Add ClosingBraceRule. 2015-12-19 15:59:32 +09:00
michallaskowski f3e5277641 Exclude files from included folders. 2015-12-13 01:20:49 +01:00
JP Simard 4d2db186f0 fix spelling in assertCorrection failures 2015-12-05 21:09:43 -08:00
JP Simard 5be62adfd4 report corrections 2015-12-05 21:09:43 -08:00
JP Simard 9498153690 test corrections in verifyRule 2015-12-05 21:09:43 -08:00
JP Simard 9cc9e64374 add Valid Docs rule 2015-11-29 21:58:16 -08:00
Marcelo Fabri 1fec14180f Adding LegacyConstructorRule 2015-11-29 01:46:06 -02:00
JP Simard 5ebc80a689 minor stylistic refactor of verifyRule 2015-11-27 14:39:14 -08:00
JP Simard 8d86e8647c verify that triggering examples in a string literal don't trigger violations 2015-11-23 15:07:39 -08:00
JP Simard 737ab0ca6f only run the tests for the current rule in verifyRule(_:)
this makes tests run twice as fast (from 13.5s to 6.2s)
2015-11-21 18:54:48 -08:00
JP Simard cacc1aa616 use regular comments rather than doc comments when testing commented violations 2015-11-20 23:38:11 -08:00
JP Simard 427d58b14e fix formatting issues in ExtendedNSStringTests 2015-11-20 23:37:48 -08:00
JP Simard 173c0058ca Merge pull request #217 from crimsonwoods/fix_issue_213_wrong_line_number_is_detected
Fix an issue: wrong line number and/or index is reported
2015-11-17 19:44:57 -08:00
crimsonwoods 2611a75ffb Add test code to verify change: 247f02eff4
That change is made to fix issue #213.
2015-11-18 12:05:08 +09:00
JP Simard 73896ee04c add force try rule 2015-11-17 16:51:37 -08:00
Samuel Giddins d24bc96f90 [TestHelpers] Consolidate comment testing 2015-11-17 16:39:39 -06:00
Samuel Giddins 426373824e [StringRuleTests] Omit default parameter value 2015-11-17 16:37:05 -06:00
Samuel Giddins 959c7e0188 Test comments cause violations when they should 2015-11-17 16:34:23 -06:00
JP Simard d269bde1fa allow trailing semicolons in comments 2015-11-17 11:41:02 -08:00
JP Simard 0a2b9e8a54 add trailing semicolon rule 2015-11-17 10:46:26 -08:00
JP Simard a45043bbaf use verifyRule to test Trailing Newline rule 2015-11-17 10:44:30 -08:00
JP Simard 8a30cb2e3d organize Xcode project
make Extensions, Models & Protocols groups under SourceKittenFramework
2015-11-15 15:07:25 -08:00
David Paschich 4af4909ad2 Filter out rules which don't exist rather than failing the configuration. 2015-11-12 20:55:07 -08:00
JP Simard 2131613166 no longer trigger a nesting violation for enums one level deep. fixes #190 2015-11-10 08:58:53 -08:00
Mickael Morier 91aa913c62 add 2 new parameter rules to check min and max length of variable names and remove length check in VariableNameRule 2015-11-07 03:03:08 +01:00
JP Simard 0335f155ab Perform major refactor of rule description, identifiers and examples
Fixes #183.
2015-11-04 12:24:33 -08:00
JP Simard 5cb80cfd22 All rules now print their identifiers in reports. Fixes #180. 2015-11-04 10:30:36 -08:00
Alex Culeva aa1fc70c9c Add StatementPosition rule 2015-11-03 22:27:26 +02:00
Alex Culeva 5af582ca53 Add Comma rule 2015-11-03 22:05:31 +02:00
JP Simard 5b34dabe30 Merge pull request #176 from zippy1978/master
Added rule reference on command output to enable batch processing
2015-11-03 11:25:23 -08:00
Gilles Grousset 7feb26ebe2 Refactored Rule reference in StyleViolation
Now uses a String with the rule identifier
2015-11-03 13:31:29 +01:00
Alex Culeva 023466e843 Add OpeningBrace Rule 2015-11-03 11:06:16 +02:00
Gilles Grousset f877af1720 Added rule id on RulesCommand and XcodeReporter 2015-11-01 02:16:34 +01:00
Gilles Grousset 7328b41da8 Added rule reference to StyleViolation
- Added rule reference to StyleViolation
- Added rule_id field on JSONReporter and CSVReporter
2015-11-01 02:00:04 +01:00
Daniel Beard 4339a281df PR comments 2015-10-07 11:16:20 -07:00
Daniel Beard 137cb6ad92 Fix tests 2015-10-07 11:15:18 -07:00
Keith Smiley e320b2e363 Remove allRules
Now that the Configuration struct is creating a list of rules based on
optional yaml, this list duplicates the same behavior. By removing it
you no longer have to maintain duplicate lists of rules.
2015-09-30 13:18:12 -07:00