Commit Graph

1363 Commits

Author SHA1 Message Date
Frederick Pietschmann 0ad2488d7e Add all keyword 2018-03-21 07:42:46 +01:00
Marcelo Fabri 8e3b929d44 Fix colon autocorrect when preprocessor macros are present
Fixes #2099
2018-03-17 18:51:30 -07:00
Marcelo Fabri e810689ca7 Make legacy_constructor rule more reliable
Fixes #2098
2018-03-17 18:19:46 -07:00
Marcelo Fabri 7b34b4b92b Merge pull request #2094 from notorca/master
Fix for crash on Linux on sources with surrogate characters
2018-03-17 16:00:03 -07:00
Marcelo Fabri bbe2923263 Update rule name 2018-03-17 13:20:43 -07:00
Marcelo Fabri 6b00950d43 Simplify implementation 2018-03-17 12:55:05 -07:00
Daniel Metzing 96d29817b4 Add untyped_error_in_catch opt-in rule 2018-03-17 12:54:51 -07:00
Cyril Lashkevich 10ba712748 Fix for crash on Linux on sources with surrogate characters
Because of the bug https://bugs.swift.org/browse/SR-5971 SwiftLint
crashes when linting on Linux files like https://github.com/xmartlabs/Eureka/blob/master/Example/Example/ViewController.swift
2018-03-17 19:51:24 +01:00
Marcelo Fabri d2c43020fc Merge pull request #2069 from donileo/fix/todos-lint-message
Fix TODOs violation message
2018-03-17 11:50:07 -07:00
Davide Sibilio 5c8d6069b6 Implemented empty_string rule (#2064)
Added empty_string rule
2018-03-17 11:47:04 -07:00
Adonis Peralta 9fff3d3472 Fix TODOs violation message
Change lint message for TODOs/FIXMEs to state that they should be
"resolved"/implemented instead of "avoided"/not used.
2018-02-25 22:28:58 -05:00
rounak 639522163f Improve console description for ExplicitTypeInterfaceConfiguration
Add more tests for ExplicitTypeInterface
2018-02-25 19:18:38 -08:00
rounak e515f43424 Add separate test files for ExplicitTypeInterfaceRule & Config
Respond to PR comments
2018-02-25 19:18:38 -08:00
Rounak 975bd7b86e Fix linter warnings 2018-02-25 19:18:38 -08:00
Rounak 2a7abcf542 Add new configuration for Explicit Type Interface Rule to allow exempting certain types of variables
Signed-off-by: Rounak <rounak91@gmail.com>
2018-02-25 19:18:38 -08:00
Marcelo Fabri cc38e33013 Fix some cases where colon rule wouldn't autocorrect dictionary literals
Fixes #2050
2018-02-14 22:13:53 -08:00
Marcelo Fabri 4eb749c870 Fix false positive in force_unwrapping when returning collection from function
Fixes #2042
2018-02-11 17:34:15 -08:00
Marcelo Fabri 8c2c4b0a01 Fix false positive in empty_enum_arguments rule when using closures
Fixes #2041
2018-02-10 20:21:58 -08:00
Marcelo Fabri 03b4d6b020 Fix violations introduced when linting with Swift 4.1
Part of #2021
2018-02-03 22:23:48 -08:00
Marcelo Fabri d4346d2d37 Merge pull request #2013 from ornithocoder/optional_boolean
Adds opt-in discouraged_optional_boolean rule
2018-02-03 15:53:10 -08:00
Marcelo Fabri 4c8df19c84 Use SourceKit to validate associatedtype and typealias in type_name rule when linting with Swift 4.1
Part of #2021
2018-01-26 22:08:59 -08:00
Marcelo Fabri b204c18d04 Improve type_name rule violations to be positioned on the type name
Part of #2021
2018-01-25 20:28:33 -08:00
Marcelo Fabri 5d7346b8a2 Don’t validate local vars in let_var_whitespace rule
As part of #2021
2018-01-25 20:00:31 -08:00
Marcelo Fabri 203d2439bd Merge pull request #2015 from realm/mf-explict-acl-false-positives
Fix false positives in `explicit_acl` rule
2018-01-25 09:43:25 -08:00
Marcelo Fabri 19c8536500 Fix false negative in unneeded_parentheses_in_closure_argument
Fixes #2017
2018-01-24 14:07:56 -08:00
Marcelo Fabri a4f701b96e Fix false positives in explicit_acl rule
Fixes #2014
2018-01-22 11:22:49 -08:00
Ornithologist Coder d31550f61f Updates examples 2018-01-22 07:29:04 +01:00
Ornithologist Coder 9787cf01d4 Adds more triggering examples 2018-01-22 01:20:57 +01:00
Ornithologist Coder f485be257d Adds opt-in discouraged_optional_boolean rule 2018-01-22 00:44:23 +01:00
Manabu Nakazawa daeb13c2bb Add testcases to ColonRule.description 2018-01-16 01:45:49 +09:00
Manabu Nakazawa e2bd9f8ed8 Fix: Colon Rule's autocorrect not working properly 2018-01-16 01:00:56 +09:00
Ornithologist Coder a2c8233d95 Ignores computed variables 2018-01-05 10:41:05 +01:00
Ornithologist Coder 561e10a71f Uses .setterAccessibility to differentiate variables from constant
As suggested by @marcelofabri.
2018-01-05 08:36:09 +01:00
Ornithologist Coder ecd8ac67b6 Fixes file name on header 2018-01-05 07:29:41 +01:00
Ornithologist Coder 2039ee6b7b Improves 'let' keyword validation 2018-01-05 06:48:54 +01:00
Ornithologist Coder 1295c5d182 Adds opt-in prefixed_toplevel_constant rule
Implements #1907.
2018-01-05 04:07:10 +01:00
Ornithologist Coder a3c6a7f40c Adds opt-in discouraged_object_literal rule
Implements #1987.
2018-01-03 23:00:54 -08:00
JP Simard 5966896575 Fix missing word in comment 2018-01-03 21:42:55 -08:00
Donald Ritter 1deddf2334 Adds a new rule which allows for enums that conform to protocol to
require cases.
2017-12-22 13:08:51 -05:00
JP Simard 1541f519b2 Merge pull request #1966 from joseprl89/feature/explicit_acl_rule
Add explicit acl rule to satisfy Issue #1649
2017-12-22 12:51:48 -05:00
JP Simard a9b6a6f07e Fix false positives in unused_closure_parameter rule
when closure is wrapped in parentheses. Fixes #1979.

Definitely not elegant, but it should help.
2017-12-21 17:52:06 -05:00
JP Simard c7c77f55ea Merge pull request #1965 from dirtydanee/yoda-condition
Introduction of Yoda condition checking.
2017-12-20 15:18:54 -05:00
JP Simard a35e231417 Fix Linux compilation 2017-12-20 14:50:56 -05:00
JP Simard a973a89818 Refactor YodaConditionRule a bit 2017-12-20 14:44:54 -05:00
JP Simard f1a3374261 Add .repeatWhile to list of conditional statement kinds 2017-12-20 14:44:54 -05:00
JP Simard 47c47262ff Minor style fixes to YodaConditionRule 2017-12-20 14:44:54 -05:00
JP Simard 84a39a57a6 Replace use of YodaConditionConfiguration with SeverityConfiguration
since YodaConditionConfiguration had no additional configuration points
2017-12-20 14:44:54 -05:00
Marcelo Fabri c1da2bd194 Fix false positives in for_where with pattern matching
Fixes #1968
2017-12-20 11:23:05 -08:00
Daniel Metzing f8f9c0e7f1 Introduction of Yoda condition checking.
This PR aims to implement [#1924][1].
[1]: https://github.com/realm/SwiftLint/issues/1924
2017-12-18 15:42:13 +01:00
Marcelo Fabri 02792c1a01 Fix false positives in control_statement when methods with keyword names are used
Fixes #1946
2017-12-04 23:18:16 -08:00