Commit Graph

1372 Commits

Author SHA1 Message Date
JP Simard e2ecafea5d refactor hasExplicitType a tiny bit 2017-04-06 14:36:16 -07:00
Jeremy David Giesbrecht 9b4f495507 Fixed false positives in redundant let rule. 2017-04-06 14:35:02 -07:00
Daniel Rodríguez Troitiño c29cf9a4d0 Avoid pattern matching false positives
The rule for unused optional binding was false triggering for pattern matching where the associated value was just an underscore. Additionally, pattern matching mixed with unused optional binding was not triggering in some cases.

New non triggering and triggering examples have been added for the failing cases, and new regular expressions are used to catch all the cases.

Modify the code in `File+SwiftLint` to expose full `NSTextCheckingResult` (and not just ranges) and rewire some pieces to use the new functions.

Fixes #1376
2017-04-06 14:16:12 -07:00
Keith Smiley b410c9376a Update optional interpolated strings for Xcode 8.3 2017-04-06 13:37:49 -07:00
JP Simard 1b69b90691 remove superfluous string interpolation of a single String 2017-04-06 13:33:38 -07:00
Norio Nomura b4f85d873a Make yaml error message to be locatable by Xcode’s Issue Navigator 2017-04-05 12:45:27 +09:00
Norio Nomura b5cba7ae40 Replace YamlSwift with Yams 2017-04-03 09:16:04 +09:00
Marcelo Fabri 802a7ddeca Improve for_where rule
Fixes #1387
2017-03-25 01:06:45 +01:00
Marcelo Fabri cc9e81754f 0.17.0: Extra Rinse Cycle 2017-03-23 22:32:37 +01:00
Marcelo Fabri a3547aa185 Merge pull request #1218 from keith/ks/sorted-imports-lowercase
Lowercase imports before sorting
2017-03-23 10:55:40 +01:00
Marcelo Fabri e26710c0ad Merge pull request #1362 from SiarheiFedartsou/implicitly_unwrapped_optional_rule
Add `implicitly_unwrapped_optional` rule
2017-03-22 21:16:18 +01:00
Siarhei Fedartsou a992ee0e84 Merge remote-tracking branch 'realm/master' into implicitly_unwrapped_optional_rule 2017-03-22 20:24:04 +03:00
Marcelo Fabri 87a0316751 Merge pull request #1365 from kimdv/FatalErrorMessageRule
Fatal error message rule
2017-03-21 22:45:20 +01:00
Marcelo Fabri 1cdee5e274 Make fatal_error_message opt-in 2017-03-21 21:56:13 +01:00
Yuki Oya f590507270 Remove empty identifier case. 2017-03-20 23:37:54 +09:00
Yuki Oya a3cf8451e0 Fix unique file element 2017-03-20 21:57:34 +09:00
Yuki Oya be5daeb993 Add source attribute 2017-03-20 19:08:35 +09:00
Marcelo Fabri 843b8386fa Merge pull request #1368 from SiarheiFedartsou/colon_configuration_equals_operator_fix
Fix `==` operator in ColonConfiguration
2017-03-19 18:04:27 +01:00
Marcelo Fabri 35e6474f0c Refactoring and make rule enabled by default 2017-03-19 17:52:55 +01:00
Siarhei Fedartsou e6c718bdbd Fix operator in ColonConfiguration 2017-03-19 13:19:55 +03:00
Kim de Vos 65972c9280 Headerfix 2017-03-19 09:01:56 +01:00
Kim de Vos f838bd6627 Added FatalErrorMessageRule 2017-03-19 00:30:02 +01:00
Siarhei Fedartsou 2e579aaa6c Add configuration for implicitly_unwrapped_optional_rule, add triggering on complex types(AnyCollection<Int!> for ex.) 2017-03-19 00:27:13 +03:00
Marcelo Fabri 1aff588043 Fix tests on Swift 2.3 2017-03-18 16:57:44 +01:00
Kim de Vos ec25033b73 Ordered by name 2017-03-18 16:57:44 +01:00
Marcelo Fabri fac653ed67 Fix header 2017-03-18 16:57:44 +01:00
Kim de Vos 3f4720ef22 Linted file 2017-03-18 16:57:44 +01:00
Kim de Vos 87f0170f3c Fixed the tests 2017-03-18 16:57:43 +01:00
Kim de Vos 90d8a44bbb Added more var types and added more test cases 2017-03-18 16:57:43 +01:00
Kim de Vos d475ed0241 Changed rule name from TypeInterfaceRule to ExplicitTypeInterfaceRule 2017-03-18 16:57:43 +01:00
Kim de Vos d1558eb4bf Made rule optin 2017-03-18 16:57:10 +01:00
Kim de Vos 0cbeab2c6d Added TypeInterfaceRule to the MasterRuleList 2017-03-18 16:57:10 +01:00
Kim de Vos 6a182ca094 Code cleaning 2017-03-18 16:57:10 +01:00
Kim de Vos 568d1dbfc7 Code cleaning 2017-03-18 16:57:10 +01:00
Kim de Vos 7b271296d3 Added Typeinterface rule 2017-03-18 16:57:10 +01:00
Siarhei Fiedartsou d25ec1f1fc Make implicitly_unwrapped_optional opt-in 2017-03-18 00:45:49 +03:00
Siarhei Fedartsou fe8359a81d Add implicitly_unwrapped_optional rule 2017-03-18 00:01:32 +03:00
Keith Smiley 0303a8e54f Lowercase imports before sorting
Currently if you have imports that differ in case, they are not sorted
as you would expect.
2017-03-12 15:58:54 -07:00
t_hayashi aa1be945fa Add test case 2017-03-12 21:44:39 +09:00
t_hayashi 55cff0d593 Fix false negative on unused_closure_parameter rule. 2017-03-11 21:58:59 +09:00
JP Simard 1d27ae1549 Merge pull request #1299 from mlwelles/cyclomatic_complexity_ignores_case_statments
Cyclomatic complexity ignores case statments
2017-03-10 15:19:46 -08:00
JP Simard 1e0e84e47a Merge pull request #1340 from sora0077/nesting-configuration
Add configuration for NestingRule
2017-03-10 15:14:50 -08:00
JP Simard 3f880432c3 Merge pull request #1331 from marcelofabri/bugfix_1304
Fix `todo` rule messages when the comment is not on a new line
2017-03-09 15:58:08 -08:00
JP Simard edc8262ef6 import Foundation from TodoRule.swift 2017-03-09 15:32:02 -08:00
JP Simard 34f40c861f make regex cache thread-safe 2017-03-09 12:10:40 -08:00
t_hayashi a8faa318bf Modify to keep original violation message 2017-03-04 01:55:35 +09:00
t_hayashi 6872018862 Add configuration for NestingRule 2017-03-04 01:14:30 +09:00
Michael Welles eff055109f Merge branch 'master' of github.com:realm/SwiftLint into cyclomatic_complexity_ignores_case_statments 2017-03-02 15:35:06 -05:00
Marcelo Fabri 1fd47dc008 Fix todo rule messages when the comment is not on a new line
Fixes #1304
2017-02-26 01:35:52 -03:00
Michael Welles a6175faad0 made adjustments per PR feedback, added tests for cyclomatic complexity configuration class 2017-02-15 11:20:17 -05:00