GitHub/SwiftLint
1
0
Fork 0
mirror of https://github.com/realm/SwiftLint.git synced 2026-06-06 20:18:40 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,779 Commits 134 Branches 150 Tags
e2b195a4e22d75f1244d43bbddb742522fa4d23f
Commit Graph

284 Commits

Author SHA1 Message Date
Marcelo Fabri e2b195a4e2 Use SwiftDeclarationAttributeKind instead of string constants 2018-04-24 22:23:36 -07:00
Marcelo Fabri 1a9a4f7516 Add redundant_set_access_control rule 
Fixes #1869
 2018-04-08 21:54:50 -07:00
Norio Nomura 133cef8df1 ObjCBool is no longer implicitly converted to Bool on Linux 2018-04-08 13:28:09 +09:00
Norio Nomura 2a0ac455bc 'flatMap' is deprecated: renamed to 'compactMap(_:)' 2018-04-08 13:28:09 +09:00
Norio Nomura 7d0f239e2a Update dependencies 
- Update SourceKitten from 0.19.1 to 0.20.0
- Update SWXMLHash from 4.3.6 to 4.6.0
- Update Yams from 0.5.0 to 0.7.0
 2018-04-08 13:28:08 +09:00
Ash Furrow 7ed962d1ee Adds force-exclusion config. 2018-03-22 09:42:56 -07:00
Frederick Pietschmann fdbc391e52 Improve all keyword-related code 
As per PR #2095 review, suggested by @marcelofabri
 2018-03-21 07:42:46 +01:00
Frederick Pietschmann 0ad2488d7e Add all keyword 2018-03-21 07:42:46 +01:00
Cyril Lashkevich 10ba712748 Fix for crash on Linux on sources with surrogate characters 
Because of the bug https://bugs.swift.org/browse/SR-5971 SwiftLint
crashes when linting on Linux files like https://github.com/xmartlabs/Eureka/blob/master/Example/Example/ViewController.swift
 2018-03-17 19:51:24 +01:00
Norio Nomura 85542a6f8d Remove DispatchQueue.sync from Array.parallelMap 
`DispatchQueue.sync` was required to avoid CoW on calling `subscript` from multiple copied instances of `Array`.
Since `UnsafeMutableBufferPointer` does not cause CoW on same situation, `DispatchQueue.sync` can be removed.
 2018-03-08 15:56:28 +09:00
JP Simard a7a8a69fa2 Improve Array.parallelMap 
By applying concepts from Swift Talk 90: https://talk.objc.io/episodes/S01E90-concurrent-map

Notably:
* Removing `@escaping` from block parameter
* Avoiding Array.append & sorting
* Using a constant DispatchQueue label
 2018-03-07 09:27:35 -08:00
Jamie Edge 0a4b562452 Removed dependency upon non-Linux NSString method. 2018-02-11 18:01:09 -08:00
Jamie Edge b80798b875 Fix directories with a '.swift' suffix being treated as files. 2018-02-11 18:01:09 -08:00
Marcelo Fabri 5eb48d69b7 Merge pull request #2030 from mshibanami/ignoring_functions_of_line_length 
Fix ignores_function_declarations of line_length doesn't work in some cases
 2018-02-03 23:05:53 -08:00
Manabu Nakazawa 9677c92285 Fix ignores_function_declarations of line_length doesn't work in some cases 2018-02-04 15:44:35 +09:00
Marcelo Fabri 03b4d6b020 Fix violations introduced when linting with Swift 4.1 
Part of #2021
 2018-02-03 22:23:48 -08:00
JP Simard 623590acd1 Update dependencies 2018-02-01 15:35:41 -08:00
Marcelo Fabri 4c8df19c84 Use SourceKit to validate associatedtype and typealias in type_name rule when linting with Swift 4.1 
Part of #2021
 2018-01-26 22:08:59 -08:00
Marcelo Fabri 19edf2608b Fix enclosedSwiftAttributes in Swift 4.1 
Fixes #2019
 2018-01-25 09:47:11 -08:00
JP Simard e70710bedb Don't log if indentation isn't set in config 
Fixes #1998
 2018-01-10 10:08:39 -08:00
JP Simard 34d2fb3949 Move Configuration.defaultIndentation() to IndentationStyle init 2018-01-03 23:31:12 -08:00
JP Simard fa13551af1 Rename Configuration.Indentation to IndentationStyle 
and move to its own file
 2018-01-03 23:21:23 -08:00
Noah McCann ab29b75d20 Addressed most linting errors 2018-01-03 23:05:48 -08:00
Noah McCann 093367073a Renamed IndentationMode to Indentation, better handled default value 2018-01-03 23:05:48 -08:00
Noah McCann 38f869bf81 Added indentationMode to configuration, updated parsing to handle it 2018-01-03 23:05:48 -08:00
JP Simard 93ded518a7 Remove uses of String.characters, deprecated in Swift 4.0.2 2017-11-10 14:37:53 -08:00
JP Simard 170ad413f0 Lock accesses to assert handler storage 
This fixes races seen "in the wild" causing crashes.
 2017-11-09 12:28:45 -08:00
JP Simard aa73566b39 Convert Cache struct to a class 
to avoid having to lock calls to mutating functions that don't
actually perform mutating operations.

This fixes races seen "in the wild" causing crashes.
 2017-11-09 12:28:45 -08:00
JP Simard 34f429b0a3 Fix caching on Linux 
This has never worked for two reasons:

1. We've used dictionaries to represent cache descriptions, which
   don't guarantee stable ordering of keys across invocations.
   This is true both on Darwin and Linux, but in practice ordering
   varies significantly more on Linux.
2. Storing a `TimeInterval` value in a `[String: Any]` dictionary
   and retrieving it again will not be dynamically castable to
   `Double` or `TimeInterval` but will be castable to `Int`.
 2017-10-26 12:23:13 -07:00
JP Simard 3a32d6b479 Speed up reading cached results by about 200% 
also slightly speed up writing to the cache.

For example, on the Lyft codebase with 1,500 Swift files:

```bash
$ time swiftlint lint --quiet
swiftlint --quiet  3.53s user 0.27s system 388% cpu 0.979 total
$ rm -rf ~/Library/Caches/SwiftLint && time swiftlint lint --quiet
swiftlint --quiet  35.20s user 1.22s system 371% cpu 9.806 total
$ time swiftlint lint --quiet
swiftlint lint --quiet  0.90s user 0.13s system 218% cpu 0.472 total
$ rm -rf ~/Library/Caches/SwiftLint && time swiftlint lint --quiet
swiftlint lint --quiet  31.78s user 1.18s system 360% cpu 9.146 total
```
 2017-10-19 23:17:01 -07:00
Marcelo Fabri e84100eed4 Remove SwiftExpressionKind.other 2017-10-05 14:33:32 -03:00
Marcelo Fabri 0be8c855d2 Move functions to properties and Sets instead of Arrays 2017-10-04 14:34:00 -07:00
JP Simard c57c47d66f Remove unnecessary Swift version differences 2017-10-04 13:49:40 -07:00
Marcelo Fabri ee02e0f8e5 Remove support for building with Swift 3.1 2017-10-04 13:48:17 -07:00
Marcelo Fabri 81f90e6326 Add custom rule to enforce using queuedFatalError 2017-10-01 20:05:46 -03:00
Marcelo Fabri 05685785f2 Merge pull request #1864 from marcelofabri/improve-allowed-symbols 
Fix false negatives when using allowed_symbols
 2017-10-01 01:11:46 -03:00
Marcelo Fabri ffa4e8a3fb Workaround union not working on Linux on Swift 3.1 2017-10-01 00:45:52 -03:00
Marcelo Fabri be341f90b9 Introduce queuedFatalError 
`fatalError` prints the full path of the file, which leaks filesystem information from the machine that built the binary. Now that we release via CocoaPods, this is more critical.
 2017-09-30 15:07:23 -03:00
Marcelo Fabri e24d847596 Prevent crash on Swift 3.x 2017-09-30 01:38:26 -03:00
Marcelo Fabri d21262d1bc Ignore SwiftLint commands in file_header rule 
Fixes #1810
 2017-09-30 00:29:23 -03:00
JP Simard 06781c7ddd Simplify CharacterSet+LinuxHack.swift 2017-09-17 17:28:32 -07:00
Marcelo Fabri de6809b40f Remove hack for SR-3485 when building with Swift 4 2017-09-16 13:23:49 -03:00
JP Simard 01e4831a7c Update for Swift 4 in Xcode 9 beta 6 and latest Linux snapshot 2017-09-10 13:48:37 -07:00
Marcelo Fabri 53380531ff Improve unneeded_parentheses_in_closure_argument 2017-08-29 16:43:56 -03:00
Marcelo Fabri 54f9c22c60 Fix existing violations 2017-08-26 10:05:56 -03:00
JP Simard 5c1c9389c7 produce an error when a 'disable' command doesn't silence any rules 2017-08-20 23:27:48 +02:00
Marcelo Fabri 843ca9c535 Use configuration rootDirectory 2017-08-17 19:59:23 +02:00
Marcelo Fabri ffd7be5919 Fix picking the wrong configuration with —path 
Fixes #1744
 2017-08-17 19:59:23 +02:00
JP Simard 48aaff433f remove unused code in File+Cache.swift 2017-08-08 09:13:32 -07:00
JP Simard b829893b7d lower ACL of declarations that should be private 2017-08-08 09:10:31 -07:00