Commit Graph

2445 Commits

Author SHA1 Message Date
Xaver Lohmüller 88e23a9113 Replace word break with end of line match 2019-01-16 14:16:56 -08:00
Xaver Lohmüller ed60316501 Put false positives with IdenticalOperandsRule 2019-01-16 14:16:56 -08:00
JP Simard 7d339ec782 Fix unused import correction (#2562) 2019-01-16 14:12:18 -08:00
Marcelo Fabri f8e42d81e0 Add strong_iboutlet opt-in rule
Fixes #2433
2019-01-13 20:53:12 -08:00
Kim de Vos b5c5701e90 Warn when disabling non existing rules (#2504)
* Added violations when trying to disable non valid rule

* Added violations when trying to disable non valid rule

* Add changelog enty for 'superfluous_disable_command' improvement

* Uses all rule identifiers when running nonValidSuperfluousCommandViolations

* Address feedback from jpsim

* Uses all rule identifiers when running nonValidSuperfluousCommandViolations

* Address more feedback from jpsim

* Added customRuleIdentifiers when verifying undefinedSuperfluousCommandViolations

* Catch all invalid disable commands in a region

Not just the first one.

* Rename test
2019-01-13 15:10:44 -08:00
JP Simard 0e01e07326 #2441 - Fix inaccessible custom rules in nested configurations (#2556)
* #2441 - Pass custom rules identifiers to the enableRules function to consider custom rules of a parent of a nested configuration

* #2441 - Add custom rules merge

* #2441 - Fix line length violation

* #2441 - Add nested configutaion mocks with custom rules

* #2441 - Add nested configurations tests for custom rules

* #2441 - Disable function body length check

* #2441 - Update changelog

* Move changelog to appropriate position

* Split up and refactor Configuration.init to avoid being too long

* Add tests to LinuxMain.swift

* Remove redundant protocol conformances

Hashable implies Equatable

* Fix typo in changelog entry and add another fixed issue URL
2019-01-13 15:07:27 -08:00
JP Simard bd0f78a501 release 0.29.3 2019-01-07 16:30:54 -08:00
Marcelo Fabri 74abfc93a6 Merge pull request #2543 from BenStaveleyTaylor/issue_2538
Issue 2538: vertical_whitespace_between_cases gives false warning if blank line has whitespace
2019-01-06 12:50:08 -08:00
Ben Staveley-Taylor 09c266613d Implement review changes
Add new nonTriggeringExample for testing, with trailing spaces
2019-01-06 16:21:51 +00:00
JP Simard 0a42e64de0 Fix order in which corrections are applied
They're already ordered last to first in the file from the sorting
applied in `violationRanges(in file:)`
2019-01-05 21:33:42 -08:00
JP Simard 135a997c9c Re-use bridged string
and inline firstToken(afterByteOffset:)
2019-01-05 21:30:58 -08:00
Marcelo Fabri 41868b35cb Improvements on unused_control_flow_label correction 2019-01-05 19:21:18 -08:00
JP Simard eb8f398683 Add shitty implementation of correction 2019-01-05 19:11:39 -08:00
Marcelo Fabri d863fc9fb7 Add unused_control_flow_label rule
Fixes #2227
2019-01-05 18:59:32 -08:00
Ben Staveley-Taylor de3a24008f Fix false positives on vertical_whitespace_between_cases
Fixes #2538
2019-01-05 16:00:32 +00:00
Marcelo Fabri 91f37afcd1 Remove unused declaration 2019-01-03 02:02:32 -08:00
Marcelo Fabri d08b3888ad Add missing ↓ on triggering example 2019-01-03 01:53:07 -08:00
Marcelo Fabri 0c92b948a9 Warn on private declaration inside @objc extension 2019-01-03 01:48:08 -08:00
Marcelo Fabri 972bb0d347 Fix false positives on redundant_objc_attribute rule when using nested types
Fixes #2539
2019-01-03 00:57:15 -08:00
Marcelo Fabri eafd98971d Fix false positives on sorted_first_last with Realm
Fixes #2533
2018-12-25 19:25:53 -08:00
Marcelo Fabri 4b12e08731 Fix false positives on Realm collections 2018-12-25 18:41:53 -08:00
Marcelo Fabri 506e3086ba Enable last_where on SwiftLint 2018-12-25 18:12:26 -08:00
Marcelo Fabri c17e269cee Add last_where opt-in rule 2018-12-25 01:34:42 -08:00
JP Simard 61a5daa073 Fix false positives in UnusedPrivateDeclarationRule (#2530) 2018-12-24 12:55:17 -08:00
Marcelo Fabri 0cc6ccfcf5 Remove unneeded import 2018-12-24 01:36:57 -08:00
Marcelo Fabri e6ee8f7145 Fix violations after rebase 2018-12-24 01:04:25 -08:00
Ornithologist Coder 13d51e7b4c Rebase and remove file headers 2018-12-24 01:01:12 -08:00
Ornithologist Coder 8c7a0e0499 Sets min. Swift version to 4.1 2018-12-24 01:01:12 -08:00
Ornithologist Coder 6f668a6087 Uses compactMap instead of flatMap 2018-12-24 01:01:11 -08:00
Ornithologist Coder 488488ef0d Prepare for SR-5717 apple/swift#11542 2018-12-24 01:01:11 -08:00
Ornithologist Coder fb179a9760 Uses offset/length instead of bodyOffset/bodyLength 2018-12-24 01:01:11 -08:00
Ornithologist Coder e37baf106c Handles optinals when argument is true/false 2018-12-24 01:01:11 -08:00
Ornithologist Coder 8e4e68fe13 Removes tests SwiftLint already takes care of 2018-12-24 01:01:11 -08:00
Ornithologist Coder 3c30d6f519 Renames variables 2018-12-24 01:01:11 -08:00
Ornithologist Coder 22a21c8fe1 Renames variable 2018-12-24 01:01:11 -08:00
Ornithologist Coder 4b391d188d Moves validation to guard statement 2018-12-24 01:01:11 -08:00
Ornithologist Coder e497f63fe0 Adds additional tests for the reasons 2018-12-24 01:01:11 -08:00
Ornithologist Coder 6d60d03fca Moves tests to its own file 2018-12-24 01:01:11 -08:00
Ornithologist Coder 8bf9e7fb29 Adds additional examples 2018-12-24 01:01:11 -08:00
Ornithologist Coder ba31336cb3 Uses AST instead of regular expressions 2018-12-24 01:01:11 -08:00
Ornithologist Coder a9a2927814 Simplifies the regular expressions
but... removes the validation when the call has a message.
2018-12-24 01:01:11 -08:00
Ornithologist Coder b760ef2362 Adds more examples 2018-12-24 01:01:11 -08:00
Ornithologist Coder 74bb9150fd Improves regular expressions 2018-12-24 01:01:11 -08:00
Ornithologist Coder 96c434e21a Adds xct_specific_matcher opt-in rule 2018-12-24 01:01:11 -08:00
Marcelo Fabri 4fa417e06f Add configuration to discouraged_object_literal
Fixes #2439
2018-12-23 23:00:08 -08:00
JP Simard a21a8b3344 release 0.29.2 2018-12-23 20:32:25 -08:00
Timofey Solonin 735567dcb4 Make modifier_order rule autocorrectable (#2521)
* #2353 - Move violating modifiers search to a private function

* #2353 - Add offset and length to the ModifierDescription

* #2353 - Make modifier_oder rule correctable

* #2353 - Add modifier_oder rule correction tests

* #2353 - Upadte the changelog

* #2353 - Add missing Foundation import

* #2353 - Fix linux tests

* Small edits to ModifierOrderRule and changelog entry
2018-12-23 19:53:38 -08:00
JP Simard e6ff3521c8 Run analyze on CI with --strict (#2524)
and whitelist two intentional violations
2018-12-23 18:22:41 -08:00
JP Simard ce8ea70492 Stringify swiftlint_version (#2523)
to treat any specified value that doesn't match the version string
to fail the lint.
2018-12-23 16:29:42 -08:00
Maksym Grebenets 46aed849d6 Support glob patterns without the star (#2508)
Enables use of '[abc]', '?' and '[a-z]' glob syntax without the need to use '*' in the pattern.
2018-12-23 16:02:42 -08:00