Commit Graph

1702 Commits

Author SHA1 Message Date
Marcelo Fabri d9df6976d5 Migrate ExplicitInitRule 2019-01-27 18:42:34 -08:00
Marcelo Fabri d52eb0c64b Migrate ImplicitReturnRule 2019-01-27 18:40:56 -08:00
Marcelo Fabri 7c5c742d36 Migrate ProtocolPropertyAccessorsOrderRule 2019-01-27 18:39:08 -08:00
Marcelo Fabri 1dbd255c52 Migrate RedundantDiscardableLetRule 2019-01-27 18:38:04 -08:00
Marcelo Fabri d147ed43f4 Migrate VoidReturnRule 2019-01-27 18:35:48 -08:00
Marcelo Fabri b309dfd4ee Migrate TrailingCommaRule 2019-01-27 18:35:42 -08:00
Marcelo Fabri d6dac23bc1 Migrate UnusedControlFlowLabelRule 2019-01-27 18:35:30 -08:00
Marcelo Fabri 336fb20b48 Migrate UnusedClosureParameterRule 2019-01-27 18:35:24 -08:00
Marcelo Fabri 0ca9f6e85e Refactor WeakComputedProperyRule 2019-01-27 12:38:14 -08:00
Marcelo Fabri 5d4923f568 Add SubstitutionCorrectableRule and SubstitutionCorrectableASTRule 2019-01-27 12:32:10 -08:00
Marcelo Fabri 81ffa9b0bb Don’t trigger for stored properties with observers 2019-01-26 02:52:38 -08:00
Marcelo Fabri 757b5fb94d Add weak_computed_property rule
Fixes #2596
2019-01-26 02:11:35 -08:00
Marcelo Fabri 7c38722384 Merge pull request #2591 from marcelofabri/mf-deployment-target-rule
Add `deployment_target` rule
2019-01-26 00:46:05 -08:00
Marcelo Fabri a1b659aa1b Merge pull request #2588 from dirtydanee/bugfix/explicit-type-interface-in-groups-and-stmts
Fix ExplicitTypeInterfaceRule in groups and statements
2019-01-25 13:37:44 -08:00
Marcelo Fabri 1495f62203 Use SwiftDeclarationAttributeKind 2019-01-25 01:10:53 -08:00
Marcelo Fabri 293805cf11 Remove unused import 2019-01-24 22:28:45 -08:00
Marcelo Fabri 6fadf80eae Add deployment_target rule
Fixes #2589
2019-01-24 21:42:11 -08:00
Marcelo Fabri 7b84e2bf66 Extract two common operations to extensions 2019-01-24 21:14:10 -08:00
Daniel Metzing 4634467644 Fix ExplicitTypeInterfaceRule in groups and statements 2019-01-24 20:37:42 +01:00
Marcelo Fabri 14ef233987 PR feedback 2019-01-23 09:57:40 -08:00
Marcelo Fabri 8cde771e9c Allow string concatenation 2019-01-23 09:32:37 -08:00
Marcelo Fabri ea4e13b9a8 Add nslocalizedstring_key opt-in rule 2019-01-22 23:54:04 -08:00
Marcelo Fabri 6876419552 Fix false positives in array_init rule with prefix operators
Fixes #1877
2019-01-21 23:07:21 -08:00
Kim de Vos da4d25fa8d Silence CodingKeys violations in unused_private_declaration (#2575) 2019-01-21 13:11:00 -08:00
Marcelo Fabri 2b822e8c6d Fix false positives on trailing_closure with anonymous closures
Fixes #2159
2019-01-18 17:43:54 -08:00
Marcelo Fabri f8dda65637 Add only_single_muted_parameter configuration on `trailing_closure 2019-01-17 22:02:47 -08:00
Marcelo Fabri 8f93b21543 Fix typos in examples 2019-01-17 20:38:26 -08:00
Marcelo Fabri 26e531f771 Rename rule to UnusedSetterValueRule 2019-01-17 20:37:31 -08:00
Marcelo Fabri 17906b2ac6 Handle named arguments 2019-01-17 19:25:39 -08:00
Marcelo Fabri 105f8a8710 Add unused_setter_argument rule 2019-01-17 18:51:47 -08:00
Samuel Susla 90232d542e Add DuplicateImportsRule (#2004) 2019-01-17 15:42:29 -08:00
JP Simard a92c6870f0 Fix false positive in identical_operands (#2565) 2019-01-17 13:57:51 -08:00
Xaver Lohmüller 7b00a110a0 Fix line_length violation a different way 2019-01-16 14:16:56 -08:00
Xaver Lohmüller 0badea7cd1 Change termination condition 2019-01-16 14:16:56 -08:00
Xaver Lohmüller 88e23a9113 Replace word break with end of line match 2019-01-16 14:16:56 -08:00
Xaver Lohmüller ed60316501 Put false positives with IdenticalOperandsRule 2019-01-16 14:16:56 -08:00
JP Simard 7d339ec782 Fix unused import correction (#2562) 2019-01-16 14:12:18 -08:00
Marcelo Fabri f8e42d81e0 Add strong_iboutlet opt-in rule
Fixes #2433
2019-01-13 20:53:12 -08:00
Kim de Vos b5c5701e90 Warn when disabling non existing rules (#2504)
* Added violations when trying to disable non valid rule

* Added violations when trying to disable non valid rule

* Add changelog enty for 'superfluous_disable_command' improvement

* Uses all rule identifiers when running nonValidSuperfluousCommandViolations

* Address feedback from jpsim

* Uses all rule identifiers when running nonValidSuperfluousCommandViolations

* Address more feedback from jpsim

* Added customRuleIdentifiers when verifying undefinedSuperfluousCommandViolations

* Catch all invalid disable commands in a region

Not just the first one.

* Rename test
2019-01-13 15:10:44 -08:00
JP Simard 0e01e07326 #2441 - Fix inaccessible custom rules in nested configurations (#2556)
* #2441 - Pass custom rules identifiers to the enableRules function to consider custom rules of a parent of a nested configuration

* #2441 - Add custom rules merge

* #2441 - Fix line length violation

* #2441 - Add nested configutaion mocks with custom rules

* #2441 - Add nested configurations tests for custom rules

* #2441 - Disable function body length check

* #2441 - Update changelog

* Move changelog to appropriate position

* Split up and refactor Configuration.init to avoid being too long

* Add tests to LinuxMain.swift

* Remove redundant protocol conformances

Hashable implies Equatable

* Fix typo in changelog entry and add another fixed issue URL
2019-01-13 15:07:27 -08:00
Marcelo Fabri 74abfc93a6 Merge pull request #2543 from BenStaveleyTaylor/issue_2538
Issue 2538: vertical_whitespace_between_cases gives false warning if blank line has whitespace
2019-01-06 12:50:08 -08:00
Ben Staveley-Taylor 09c266613d Implement review changes
Add new nonTriggeringExample for testing, with trailing spaces
2019-01-06 16:21:51 +00:00
JP Simard 0a42e64de0 Fix order in which corrections are applied
They're already ordered last to first in the file from the sorting
applied in `violationRanges(in file:)`
2019-01-05 21:33:42 -08:00
JP Simard 135a997c9c Re-use bridged string
and inline firstToken(afterByteOffset:)
2019-01-05 21:30:58 -08:00
Marcelo Fabri 41868b35cb Improvements on unused_control_flow_label correction 2019-01-05 19:21:18 -08:00
JP Simard eb8f398683 Add shitty implementation of correction 2019-01-05 19:11:39 -08:00
Marcelo Fabri d863fc9fb7 Add unused_control_flow_label rule
Fixes #2227
2019-01-05 18:59:32 -08:00
Ben Staveley-Taylor de3a24008f Fix false positives on vertical_whitespace_between_cases
Fixes #2538
2019-01-05 16:00:32 +00:00
Marcelo Fabri 91f37afcd1 Remove unused declaration 2019-01-03 02:02:32 -08:00
Marcelo Fabri d08b3888ad Add missing ↓ on triggering example 2019-01-03 01:53:07 -08:00