GitHub/SwiftLint
1
0
Fork 0
mirror of https://github.com/realm/SwiftLint.git synced 2026-06-06 20:18:40 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,379 Commits 134 Branches 150 Tags
d99be668c56ea8a0c8abcb55ff32f577e22c78f2
Commit Graph

2146 Commits

Author SHA1 Message Date
Danny Moesch d99be668c5 Ignore more locations of static references not using 'Self' in classes (#3771) 
Static references with `Self` are not allowed to define

* default values of properties,
* annotation parameter values and
* default method parameter values

in classes.
 2022-01-21 12:43:12 -08:00
JP Simard e3f232ec28 Fix convenience_type false positives when using actors (#3812) 
Fixes https://github.com/realm/SwiftLint/issues/3761.
 2022-01-21 19:54:59 +00:00
JP Simard 341ec2a907 Remove 'weak_delegate' rule (#3809) 
This was very prone to false positives and not worth keeping.

The identifier will stick around for a release to ease the migration.
 2022-01-21 17:56:59 +00:00
Sergei aff3536bb8 Fix the regex for expiring-todos. (#3803) 
- Make "middle part" `.*` not so greedy with `?`.
- Use `(?!` negative look-ahead to improve matching.
- Added corresponding unit tests.

Co-authored-by: Sergei Shirokov <sshirokov@malwarebytes.com>
 2022-01-21 17:42:17 +00:00
Ikko Ashimine 640efba68d Fix typo: implict -> implicit 2022-01-21 11:05:21 -05:00
Ikko Ashimine 3d7775de11 Fix typo in CommentSpacingRule.swift (#3795) 
charcter -> character
 2022-01-21 07:47:14 -08:00
Ethan Wong 5fd8ef38c1 Fix malformed doc for rule "InclusiveLanguage". 2022-01-21 10:45:15 -05:00
Paul Williamson 9e37d0fa44 Prevent false triggering of unused_closure_parameter when using list bindings (#3799) 2022-01-21 07:35:12 -08:00
grosem c90c329f12 Allow unused_setter_value for overrides (#3653) 
Fixes #2585
 2022-01-20 22:53:18 +00:00
JP Simard 027bdcdc95 Fix crash when parsing multi-line attributes with the attributes rule (#3776) 
Fixes #3761
 2021-12-06 16:08:53 +00:00
iressler 3da6502bac Fix false positive in legacy_objc_type when a non-legacy Objective-C type name begins with a legacy Objective-C type name. (#3752) 2021-11-29 12:36:27 -08:00
Danny Mösch 050473a0e1 Add optional prefer_self_in_static_references rule (#3732) 2021-11-29 18:42:53 +00:00
Kaitlin Mahar 5429ff642c Fix false positives with async closures for large_tuple rule (#3754) 2021-11-29 18:06:15 +00:00
Ikko Ashimine d97bf0951e Fix typo in StrictFilePrivateRule.swift (#3737) 
occurences -> occurrences
 2021-11-29 09:47:17 -08:00
JP Simard 2544d7b945 [unused_import] Fix SwiftShims being considered a used import (#3766) 2021-11-29 17:07:38 +00:00
Paul Taykalo 945efde5f5 Prevent multiple recalculations of capture groups ranges (#3745) 2021-10-15 02:38:18 +03:00
Paul Taykalo a87aee1771 Colon rule should ignore cases when comment is in function argument (#3740) 2021-10-14 16:05:11 +03:00
Marcelo Fabri 383e5b5bc2 Handle get async and get throws in implicit_getter (#3743) 
Fixes #3684
 2021-10-12 10:32:34 -07:00
Artem Garmash 67114bb729 Exclude id from identifier_name by default (#3730) 2021-10-04 21:13:40 +00:00
Paul Taykalo 6b8c4442b0 Speed up "computed accessors order" rule (#3727) 2021-10-01 03:07:57 +03:00
Naruki Chigira e4ff164f64 Fix redundant_optional_initialization autocorrect (#3717) 
* Fix autocorrect for redundant_optional_initialization in case observer's brace exists.
 2021-09-30 23:15:53 +00:00
Marcelo Fabri b63a60df14 Fix false positive in unneeded_break_in_switch (#3725) 
Fixes #3724
 2021-09-29 12:00:08 -07:00
Marcelo Fabri 4052c43f16 Make rule more generic and rename it 2021-09-29 10:28:39 -07:00
Marcelo Fabri 2674d367f9 Fix violation 2021-09-29 10:28:39 -07:00
Marcelo Fabri eb3a405930 Remove unused function 2021-09-29 10:28:39 -07:00
Marcelo Fabri 68bfc13941 Add add_target_in_variable_declaration_closure rule 2021-09-29 10:28:39 -07:00
Ben Fox 00799cc782 Fixes MissingDocRuleConfiguration (#3713) 
* add configuration for missing_docs

* fix MissingDocsRuleConfiguration

* add to changelog

* fix up Config default values and update tests

* use XCTAssertTrue and XCTAssertFalse

* fix line length violation

* finish up unit tests

* rever Package.resolved
 2021-09-13 15:23:55 -04:00
Atsuto Yamashita db229aa221 fix typo in ExplicitTopLevelACLRule.swift (#3716) 2021-09-12 19:45:32 -04:00
JP Simard 888619912f Run CI with Xcode 12.5.1 & Swift 5.4 (#3710) 
And require Swift 5.4 or Xcode 12.5 or later to build SwiftLint.
 2021-09-10 08:32:02 -07:00
JP Simard 986d98c475 Fix tests on Swift 5.5 / Xcode 13 (#3709) 2021-09-09 21:11:22 +00:00
Ben Fox 1f44d56357 add configuration for missing_docs (#3701) 
* `excludes_extensions` defaults to `true` to skip reporting violations
  for extensions with missing documentation comments.
* `excludes_inherited_types` defaults to `true` to skip reporting
  violations for inherited declarations, like subclass overrides.
 2021-09-01 21:42:47 +00:00
Kane Cheshire 55b62cccb3 Updated file name to match type 2021-08-24 00:19:35 -07:00
Kane Cheshire 4a293632c2 Named rule correctly for Sourcery to work properly 2021-08-24 00:19:35 -07:00
Marcelo Fabri 50b6992852 Fix issues with explicit_type_interface on Swift 5.4 
Fixes #3615
 2021-08-16 02:23:28 -07:00
Marcelo Fabri cc79edd4af Fix issues in ImplicitReturnRule 2021-08-16 02:23:28 -07:00
Marcelo Fabri 9e3f0a8ff8 Fix some rules when using Swift 5.4 2021-08-16 02:23:28 -07:00
iressler 9aff1e0a8e This change addresses a false negative case in the RedundantOptionalInitializationRule. (#3671) 2021-08-16 02:01:17 -07:00
Ikko Ashimine 81eb0d9b1f Fix typo in ClosureSpacingRule.swift (#3669) 
occurences -> occurrences
 2021-07-06 10:41:59 -07:00
Marcelo Fabri 9939c536d5 Add anonymous_argument_in_multiline_closure opt-in rule (#3659) 
* Add anonymous_argument_in_multiline_closure opt-in rule

* Restrict match to the closure

* Fixes
 2021-06-17 17:03:19 -07:00
Steven Grosmark 300bf77967 Improve file_length warnings when excluding comments (#3654) 
* Improve `file_length` warnings when excluding comments

* Update changelog

* Update Source/SwiftLintFramework/Rules/Metrics/FileLengthRule.swift

Co-authored-by: Yegor Chsherbatykh <ego1309@yandex.ru>

Co-authored-by: Steven Grosmark <steven.grosmark@ww.com>
Co-authored-by: Yegor Chsherbatykh <ego1309@yandex.ru>
 2021-06-17 11:11:17 -07:00
Kane Cheshire 6367ff20c8 Updated triggering examples to indicate where the violation should occur 2021-05-24 12:05:29 -07:00
Kane Cheshire 50169fb556 Removed unused import causing CI to fail 2021-05-24 12:05:29 -07:00
Kane Cheshire 9c5d3b3c6f Tidy up 2021-05-24 12:05:29 -07:00
Kane Cheshire 3536a86ba1 Added more non-triggering examples 2021-05-24 12:05:29 -07:00
Kane Cheshire 91b125b001 Ran sourcery + tidied up 2021-05-24 12:05:29 -07:00
Kane Cheshire d6223893ed Moved description back 2021-05-24 12:05:29 -07:00
Kane Cheshire d7aeea39d9 Adding examples/tests 2021-05-24 12:05:29 -07:00
Kane Cheshire 0dd96d249e Uses correct enumcase instead of enum 2021-05-24 12:05:29 -07:00
Kane Cheshire 538764278b Adding new DisallowNoneCase rule 2021-05-24 12:05:29 -07:00
p-x9 050a10bbd9 Add Test 2021-05-21 14:33:16 -07:00