Commit Graph

1278 Commits

Author SHA1 Message Date
Michael Welles c9ff0aa07f Changes from PR feedback. Long comments following code in a line will now trigger, configuration will now fail if invalud value types are set for options 2017-02-06 15:33:44 -05:00
Michael Welles ccc840b340 Changed LineLengthConfigurationFlag enum to be an OptionSet struct, per pull request feedback 2017-01-31 13:56:26 -05:00
Michael Welles 04437ed30d Merge branch 'master' of github.com:realm/SwiftLint into line-length-rule-configurable 2017-01-30 17:55:34 -05:00
Michael Welles cd843e7fcd Added "ignores_comments" and "ignores_function_declarations" as boolean options to LineLengthRule 2017-01-30 17:51:56 -05:00
t_hayashi d4ccec2657 Remove unneeded positive lookahead pattern 2017-01-27 00:56:53 +09:00
t_hayashi 50b0febdb4 Modify regex pattern more simple 2017-01-26 23:01:27 +09:00
t_hayashi 851e6ec0db Fix redundant_void_return execution if return type starts with Void 2017-01-26 22:28:39 +09:00
Allen Zeng c3b4a43950 ascertain name lengths 2017-01-26 10:55:46 +11:00
Allen Zeng 6acf36bc97 use calculated property 2017-01-26 01:37:39 +11:00
Allen Zeng 9f1e81bb67 retain closure parameter types when they are specified during autocorrect 2017-01-26 00:04:43 +11:00
Marcelo Fabri d3693e1171 Merge pull request #1196 from marcelofabri/notification_center_detachment
Add notification_center_detachment rule
2017-01-24 23:00:17 -02:00
Marcelo Fabri 776484ded7 Merge pull request #1243 from marcelofabri/bugfix_1242
Fix number_separator rule for upcase exponentials
2017-01-24 22:34:21 -02:00
Marcelo Fabri a11e836c51 Refactor to use Dictionary extension 2017-01-24 22:27:46 -02:00
Marcelo Fabri 3800915e88 Swift 2.3 compatibility 2017-01-24 22:27:46 -02:00
Marcelo Fabri 46a2c25af4 Add notification_center_detachment rule
Fixes #1061
2017-01-24 22:27:45 -02:00
Marcelo Fabri 6772ef6668 Merge pull request #1192 from marcelofabri/discarded_notification_center_observer
Add discarded_notification_center_observer rule
2017-01-24 22:16:50 -02:00
Marcelo Fabri f03a0eda9a Fix number_separator rule for upcase exponentials
Fixes #1242
2017-01-24 22:15:49 -02:00
Aaron McTavish cb53af5cd6 Fix bool negation false positive for force_unwrap
Resolves #918 `force_unwrapping: false positive when using ! as boolean
operator`.
2017-01-24 07:35:13 +00:00
Marcelo Fabri ba33d10ee8 Merge branch 'master' into faster-vertical-whitespace 2017-01-23 22:54:28 -02:00
Marcelo Fabri 67b60c4d18 Merge branch 'master' into faster-first-where 2017-01-23 22:52:31 -02:00
Marcelo Fabri 96c81d126e Merge branch 'master' into faster-mark-rule 2017-01-23 22:51:27 -02:00
Marcelo Fabri c891efc8d6 Add discarded_notification_center_observer rule
Fixes #1062
2017-01-23 21:38:33 -02:00
Marcelo Fabri 8ac666400d Fix a false positive on large_tuple rule
Fixes #1234
2017-01-23 21:37:22 -02:00
Marcelo Fabri 28d22765f2 Make mark rule faster 2017-01-23 21:36:59 -02:00
Marcelo Fabri b17184d9b5 Make first_where rule faster 2017-01-23 21:36:06 -02:00
Marcelo Fabri 7f1cabc568 Make vertical_whitespace rule slightly faster
And also refactor it a bit.
2017-01-23 21:34:34 -02:00
JP Simard 29cdc86185 add some convenience members to SourceKit dictionaries 2017-01-22 11:00:57 -08:00
JP Simard 3599723a65 simplify equality check in AttributesRule 2017-01-22 09:40:23 -08:00
Marcelo Fabri 394069e1e3 Make redundant_nil_coalescing faster 2017-01-22 02:19:51 -02:00
Marcelo Fabri 6859d5f494 Performance improvements to generic_type_name rule
This simple regex change boosted the rule time from ~`0,500`s to ~`0,070`s.
2017-01-21 14:04:18 -02:00
JP Simard 85abab13b9 fix SPM build 2017-01-20 11:17:48 -08:00
JP Simard 16ca04905c 0.16.1: Commutative Fabric Sheets 2017-01-20 10:32:33 -08:00
JP Simard 3294e5cbab allow forcing Swift version via SWIFTLINT_SWIFT_VERSION 2017-01-20 10:14:33 -08:00
Marcelo Fabri 66e9635766 Add nonTriggering examples 2017-01-19 14:15:47 -02:00
Marcelo Fabri a11fe6accb Disable commutative operations on shorthand_operator rule
Fixes #1182, #1183, #1211
2017-01-18 22:07:45 -02:00
Aaron McTavish 980b8fff8f Clean LegacyConstantRule from code review
Comments by @marcelofabri
2017-01-18 12:16:27 +00:00
Aaron McTavish eb902f79ad Fix legacy_constant for Swift 2 2017-01-17 15:38:49 +00:00
Aaron McTavish edb0fedd0e Update legacy_constant to support CGFloat.pi
Resolves #1198 `Prefer CGFloat.pi to CGFloat(M_PI)`.
2017-01-17 08:10:56 +00:00
Marcelo Fabri 0b268ad606 Merge pull request #1202 from bjarkehs/decimal_number_separator
Add minimum_fraction_length to number_separator
2017-01-17 04:56:11 -02:00
Bjarke Hesthaven Søndergaard 4a9d354210 Fixes to comply with review 2017-01-16 20:38:29 +01:00
Bjarke Hesthaven Søndergaard ad749ac9f7 Add minimum_fraction_length configuration 2017-01-16 18:40:11 +01:00
Mikael Konradsson f8c2ed6a54 Fixed typo 2017-01-16 16:32:25 +01:00
Aaron McTavish 9cfc51a527 Ignore overrides for variable_name
Resolves #1169 `variable_name should not apply to overriding
properties`.
2017-01-16 10:41:01 +00:00
JP Simard df6cfa4d56 use enableAllRules in Configuration.swift 2017-01-12 14:13:48 -08:00
JP Simard 4d709b68d0 Merge pull request #1179 from rakaramos/unsued-optional-binding
Unused optional binding
2017-01-12 11:11:01 -08:00
rakaramos 7625c08d86 Improve tuples checking 2017-01-12 12:37:42 -02:00
Alpa Dedhia ec48387973 correct spelling mistake Redudant -> Redundant 2017-01-12 13:57:58 +05:30
Marcelo Fabri e6155ea76e Fix excluded configuration not excluding files.
Fixes #1166
2017-01-12 00:36:59 -02:00
Marcelo Fabri a761608403 Fix false positive on operator_usage_whitespace
Fixes #1153
2017-01-11 19:41:17 -02:00
Marcelo Fabri ece8c7b596 Fix more false positives on shorthand_operator
Fixes #1163
2017-01-11 18:02:59 -02:00