Commit Graph

1069 Commits

Author SHA1 Message Date
JP Simard 99d13d14a3 remove workaround for SR-3448/SR-3449
as they were fixed in the 3.1 release
2017-05-25 07:58:04 -07:00
Marcelo Fabri fd5ce1c4b0 Fix false positive in empty_enum_arguments rule
Fixes #1549
2017-05-25 04:57:11 +02:00
Marcelo Fabri 32e38c96cf Add kinds(inByteRange:) 2017-05-25 04:55:47 +02:00
JP Simard 0071b8c50d remove redundant protocol inheritance
since 'ConfigurationProviderRule' already inherits from 'Rule'
2017-05-24 15:36:58 -07:00
JP Simard 8a9b1023e1 fix style issues in ClosureSpacingRule 2017-05-24 13:26:19 -07:00
J Cheyo Jimenez 4b927d1479 made closure_spacing correctable 2017-05-24 13:07:38 -07:00
JP Simard 201a74ef0b recursively call extractCallsToSuper(methodName:) 2017-05-23 10:26:13 -07:00
JP Simard 572754f707 Merge pull request #1530 from realm/jp-reenable-cache-v2
Reenable cache
2017-05-21 22:43:12 -07:00
Marcelo Fabri 9d67308a92 Merge pull request #1511 from marcelofabri/protocol_property_accessors_order
Add protocol_property_accessors_order rule
2017-05-22 00:37:46 +02:00
Marcelo Fabri 12360cc386 Use ASTRule and check if token is ACL 2017-05-22 00:13:19 +02:00
J Cheyo Jimenez aef7f81056 Added NoExtensionAccessModifierRule 2017-05-21 23:53:56 +02:00
Marcelo Fabri 32913fe03e Merge pull request #1410 from sammy-SC/shorthand_operator-false-positive
Prevent false positive in shorthand_operator rule
2017-05-21 23:40:11 +02:00
Marcelo Fabri 09c29b169d Fix false positive in syntactic_sugar rule when using nested types
Fixes #1508
2017-05-21 23:17:53 +02:00
JP Simard 3968b01bb6 update tests to reflect unicode fixes in SourceKitten 2017-05-19 14:10:24 -07:00
JP Simard cea6f43f37 make PrivateUnitTestRule & its configuration conform to CacheDescriptionProvider 2017-05-19 09:30:09 -07:00
JP Simard 0c0952046c ensure deterministic consoleDescription & cacheDescription generation 2017-05-19 09:25:53 -07:00
JP Simard 2704b3e1de report file_header violations on line 1 for all reporters 2017-05-18 15:11:50 -07:00
JP Simard f639ae95f1 add CacheDescriptionProvider protocol
to provide more complete descriptions for cache invalidation
purposes.
2017-05-18 14:31:33 -07:00
JP Simard 8c9cba0c0f fallback to line 1 when no line is provided & reporting with xcode
this is a generalization of the fix from #1521
2017-05-17 14:56:46 -07:00
Richard Hodge 32c58aaf5a Update file_header rule to trigger on line 1 for files that are missing a header. (#1521)
Fixes #1520
2017-05-17 16:19:31 +02:00
JP Simard 65f32a14dd refactor CustomRules.validate(file:) 2017-05-16 11:28:01 -07:00
JP Simard d8ca9cb1fb use default implementation of configurationDescription
for ConditionalReturnsOnNewlineRule
2017-05-16 11:26:22 -07:00
Samuel Susla 42476d06bc Combine two regexes into one 2017-05-16 19:18:23 +01:00
JP Simard 92043af1c0 rename ConditionalReturnsOnNewline to ConditionalReturnsOnNewlineRule
to match conventions used for rules
2017-05-16 10:58:47 -07:00
Marcelo Fabri 98dc0f78f6 Add protocol_property_accessors_order rule
Fixes #1504
2017-05-16 08:10:04 +02:00
JP Simard 61e9b39327 prefer contains over first(where:) != nil 2017-05-15 11:50:53 -07:00
JP Simard bb4c94be27 fold patternKind & pattern into flatMap block
since these are string literals, they'll only be included once in the binary
2017-05-15 11:17:06 -07:00
Marcelo Fabri 85bd94d33a Merge pull request #1510 from marcelofabri/ignoreOptionalTry-default-false
Change the default of ignoreOptionalTry to false in UnusedOptionalBindingRule
2017-05-15 00:38:19 +02:00
Marcelo Fabri eec8935091 Merge pull request #1444 from jaherhi/identifier_name_allow_non_alphanumeric_and_uppercase_characters
Add options to disable some checks for identifier_name rule
2017-05-15 00:31:39 +02:00
Marcelo Fabri 1e115be030 Change the default of ignoreOptionalTry to false in UnusedOptionalBindingRule
To avoid breaking changes.
2017-05-15 00:19:07 +02:00
Javier Hernández d652cfe4ab Add options to generic_type_name and type_name rules 2017-05-10 21:02:30 +01:00
Javier Hernández 9d31eaccda Rename option to validates_start_lowercase 2017-05-10 20:53:44 +01:00
Javier Hernández 3245fd83a9 Fix tests 2017-05-10 20:53:44 +01:00
Javier Hernández fe916c121f Add option to allow names to start with uppercase 2017-05-10 20:53:44 +01:00
Javier Hernández 93583f3153 Add option to exclude non alphanumeric characters 2017-05-10 20:53:42 +01:00
Marcelo Fabri 991d1fa65a Add empty_enum_arguments rule
Fixes #1425
2017-05-08 08:29:27 +02:00
Marcelo Fabri db66e74ccd Merge pull request #1499 from marcelofabri/complexityConfigTypo
Fix `ignores_case_statements` key in `cyclomatic_complexity` description
2017-05-07 17:11:50 +02:00
Jeffrey Blagdon 2e3130048f Fix ignores_case_statements key in cyclomatic_complexity description
Fixes #1434.
2017-05-07 17:10:21 +02:00
Marcelo Fabri 6805c4a1e0 Merge pull request #1480 from marcelofabri/unused_optional_binding_rule_ignore_option
Unused optional binding rule ignore option
2017-05-07 17:03:15 +02:00
Marcelo Fabri 2282362989 Remove extra parenthesis on file header rule description 2017-05-04 21:37:34 +02:00
Samuel Susla de72f85db9 Merge branch 'master' of https://github.com/realm/SwiftLint into shorthand_operator-false-positive 2017-05-04 19:24:13 +02:00
Marcelo Fabri 9412861143 Prevent triggering redundant_optional_initialization rule on a lazy var
Fixes #1334
2017-05-02 00:15:44 +02:00
Marcelo Fabri 32d5266409 Small rule improvements 2017-05-01 16:11:12 +02:00
Сергей Галездинов 894416a1a1 filter optional try's from matches when ignore_optional_try is true 2017-05-01 14:59:00 +02:00
Сергей Галездинов 74e77e82bb Additional configuration for UnusedOptionalBindingRule 2017-05-01 14:59:00 +02:00
Marcelo Fabri d356522491 Add implicit_return rule
Fixes #1194
2017-05-01 00:58:58 +02:00
JP Simard a841508c0b Merge pull request #1476 from marcelofabri/top-acl
Add explicit_top_level_acl opt-in rule
2017-04-30 12:26:13 -07:00
Marcelo Fabri 4a9ba8248f Fix build with Swift 3.0.x 2017-04-30 20:42:09 +02:00
Marcelo Fabri 74b7744de6 Alternative implementation 2017-04-30 20:17:41 +02:00
Marcelo Fabri 42e6c8a06c Fix empty_parameters rule with Swift 3
Fixes #1460
2017-04-30 17:27:51 +02:00