Commit Graph

45 Commits

Author SHA1 Message Date
Martin Redington 0693d547b0 Add new unneeded_synthesized_initializer rule (#4812) 2023-06-21 22:15:02 +02:00
woxtu 21fbf59c2c Rewrite todo rule with SwiftSyntax (#5040) 2023-06-19 10:28:51 -04:00
Danny Mösch 3ec9bc85bc Inline variables 2023-06-18 12:01:28 +02:00
Danny Mösch f5ea2492dc Merge allowed symbols with alphanumerics where possible 2023-06-18 12:01:28 +02:00
Danny Mösch b89e43a799 Make sure case check can be disabled by new off option value (#5064) 2023-06-17 22:27:57 +02:00
Danny Mösch c8cd311615 Collapse conditional statements into single expression 2023-06-13 23:24:48 +02:00
Danny Mösch ba42a6aa36 Extract examples 2023-06-13 23:24:48 +02:00
Danny Mösch 83ab977a1b Introduce visitor that tracks declared variables while traversing the AST 2023-06-13 23:24:48 +02:00
Danny Mösch f12b8d66d3 Do not trigger prefer_self_in_static_references rule on collection types (#5055) 2023-06-12 16:40:45 -04:00
JP Simard e5cf99088b Update SwiftSyntax to 509.0.0-swift-DEVELOPMENT-SNAPSHOT-2023-06-05-a (#5058)
Diff: https://github.com/apple/swift-syntax/compare/509.0.0-swift-DEVELOPMENT-SNAPSHOT-2023-05-02-a...509.0.0-swift-DEVELOPMENT-SNAPSHOT-2023-06-05-a
2023-06-12 15:22:17 -04:00
Danny Mösch 23326fc433 Specify default options in configurations only (#5056) 2023-06-11 10:44:06 -07:00
woxtu 156f6aabc8 Fix false positives in sorted_first_last rule when first/last have a predicate (#5038) 2023-06-11 17:22:06 +02:00
woxtu 43190834c5 Fix legacy_random examples (#5047) 2023-06-10 23:53:45 +02:00
woxtu f1d5a55658 Fix typo (#5044) 2023-06-10 23:50:49 +02:00
woxtu 2f9997e2cc Fix typos (#5033) 2023-05-25 23:58:29 +02:00
Martin Redington 521df18fdb Fix false alarms in redundant_objc_attribute rule (#4742) 2023-05-20 21:45:27 +02:00
Danny Mösch a2ba0a0626 Omit "Rule" in configuration names (#5024) 2023-05-20 04:39:04 -04:00
Hilton Campbell 1094a3b70e Add grouping option to the sorted_imports rule (#4935) 2023-05-19 15:49:07 -04:00
Haocen Jiang 754127924f Update replacement for CGRectIntersection (#5023) 2023-05-19 15:17:14 -04:00
Danny Mösch 3f039f26d5 Connect configs with their referencing rules to have some context in error logging (#5017)
With the binding of configurations to their associated rule types
"unknown configuration" errors can be made more specific mentioning
also the rule's identifier in the printed message.
2023-05-19 20:58:24 +02:00
Danny Mösch 671589b1d4 Let configuration names match rule names (#5021) 2023-05-18 12:04:39 -04:00
Danny Mösch d938b2d3c3 Specify default options in configurations only (#5020) 2023-05-18 17:21:30 +02:00
Danny Mösch 7fd22e0d6e Use SeverityBasedRuleConfiguration where possible (#5019) 2023-05-18 16:04:20 +02:00
Danny Mösch fe312a06fe Rely on pre-defined issues and allow to print them directly to the console (#5013)
Advantages of having typical errors at a common place:
* Error message styling can be harmonized
* Existing messages can be reused
* Overview of prefixes ('error: ', 'warning: ')
* Manage how to print them to the console
2023-05-16 20:15:14 +02:00
Danny Mösch c0ea9d1925 Do not trigger prefer_self_in_static_references rule on typealias in classes (#5012) 2023-05-15 14:07:21 -04:00
Danny Mösch 405113f793 Open ConfigurationError up to be used more broadly (#5005) 2023-05-14 20:00:46 +02:00
Danny Mösch f4987071f0 Extract configuration into its own file (#5007) 2023-05-14 13:05:36 -04:00
Danny Mösch 4d4a330d46 Silence xct_specific_matcher rule on types and tuples used in "one argument asserts" (#4997) 2023-05-13 22:04:35 +02:00
JP Simard 1b1b19a902 Fix some unhandled_throwing_task false positives (#5001)
Fixes some of the cases reported in
https://github.com/realm/SwiftLint/issues/4987
2023-05-12 10:35:59 -04:00
JP Simard e7bf813f15 Make unhandled_throwing_task rule opt-in (#5000)
Because since it was included in a release a few days ago, we've had
several reports of false positives and so flipping to opt-in is
appropriate so users can determine for themselves if they should enable
the rule.
2023-05-12 09:46:07 -04:00
Danny Mösch 3cf9585b2e Exclude self.x = x from being reported in the redundant_self_in_closure rule (#4996) 2023-05-11 23:26:39 +02:00
Kyle Bashour 87e230ce87 Fix false positive when result is accessed (#4986) 2023-05-10 20:36:00 -04:00
Danny Mösch c99a4286b8 Let validates_start_with_lowercase option in name configurations expect a severity 2023-05-10 22:20:30 +02:00
Danny Mösch 8d5700afca Remove deprecation warning in identifier_name rule
It was introduced 6 years ago.
2023-05-10 22:20:30 +02:00
Danny Mösch 1fa8e484c4 Add expiring TODO comments on deprecation warnings 2023-05-10 21:44:20 +02:00
JP Simard fa32fbc4f0 Minor edits to unhandled_throwing_task changelog entry
And rule description.
2023-05-10 14:04:42 -04:00
Kyle Bashour 8822d40687 Add unhandled_throwing_task rule (#4958)
This rule will check Task's that are not explicitly annotated with success and
failure types for unhandled try expressions. These trys will silently fail if an
error is thrown.

See this forum thread for more details:
https://forums.swift.org/t/task-initializer-with-throwing-closure-swallows-error/56066
2023-05-10 14:03:01 -04:00
Danny Mösch 6fd5f98d38 Add examples for weak variables to implicitly_unwrapped_optional rule 2023-05-06 22:46:25 +02:00
Danny Mösch bc18ff14e3 Add violation markers 2023-05-06 22:46:25 +02:00
Danny Mösch 7756793356 Add new option to attributes rule to influence it for attributes with arguments (#4855) 2023-05-05 16:12:01 -04:00
Danny Mösch f0138ea1df Add example to proof that shorthand optional bindings work with unused_declaration rule (#4857) 2023-05-05 15:22:59 -04:00
Danny Mösch 6a2e973de3 Add new redundant_self_in_closure rule (#4911) 2023-05-05 21:14:14 +02:00
JP Simard 6b094dd711 [SwiftSyntax] Update to latest 509.0.0 tag (#4920)
* [bazel] Remove custom SwiftSyntax BUILD file

Something similar to this has been merged upstream instead now. This
also renames the repo name to SwiftSyntax in preparation for it being in
the BCR

* [SwiftSyntax] Update to latest 509.0.0 tag

https://github.com/apple/swift-syntax/releases/tag/509.0.0-swift-DEVELOPMENT-SNAPSHOT-2023-04-25-b
2023-05-03 11:34:26 -04:00
Chris White 71b89e66de Prepend warning: to error messages (#4927) 2023-05-01 18:26:25 +02:00
JP Simard a7bc9e20c7 Move built-in rules to new SwiftLintBuiltInRules module (#4950) 2023-04-27 11:16:01 -04:00