Marcelo Fabri
b303cd64ea
Make SyntaxRules Opt-In ( #3094 )
2020-02-09 16:20:14 -08:00
Marcelo Fabri
14da706ae9
Remove unused variable in AttributesRule ( #3090 )
2020-02-09 16:06:27 -08:00
Marcelo Fabri
b70b7778df
Fix UnownedVariableCaptureRuleTests in Swift 5.2 ( #3091 )
...
https://bugs.swift.org/browse/SR-12168
2020-02-09 16:06:11 -08:00
Marcelo Fabri
fdd16a6853
Add prohibited_nan_comparison opt-in rule ( #3089 )
...
Fixes #2086
2020-02-09 15:13:25 -08:00
Zsolt Kovács
ab8cd43e67
Empty count configuration ( #3052 )
...
* Add `only_after_dot` configuration option to `empty_count` rule
* Update CHANGELOG.md
* Adopt Example wrapper
* Change severity level to error
2020-02-09 15:12:54 -08:00
Marcelo Fabri
62e273c46c
Do not trigger optional_enum_case_matching on _? ( #3088 )
...
Fixes #3057
2020-02-08 14:42:55 -08:00
Marcelo Fabri
f95768d2e6
Add tuple_pattern opt-in rule ( #3086 )
...
* Add `tuple_pattern` opt-in rule
Fixes #2203
* Remove unused import
2020-02-08 13:57:17 -08:00
Marcelo Fabri
bdede7b9c1
Remove extra space in optional_enum_case_matching description ( #3087 )
2020-02-08 13:49:21 -08:00
David Harris
8c789bb3e2
feature: add config setting to exist successfully in case of no lintable ( #2732 )
...
files
2020-02-08 13:33:50 -08:00
Marcelo Fabri
1d39071dfd
Add void_function_in_ternary opt-in rule ( #3085 )
...
* Add `void_function_in_ternary` opt-in rule
Fixes #2358
* Remove unused import and improve description
2020-02-08 13:23:02 -08:00
Marcelo Fabri
8d9c501cb8
Add optional return_value_from_void_function rule using SwiftSyntax ( #3054 )
...
* Add optional return_value_from_void_function rule using SwiftSyntax
* Use Script/bootstrap in CI
* Make SwiftSyntax optional
* Make SwiftSyntax optional in SPM
* Fix Package.swift
* Try again
* Add minSwiftVersion
* Fix thread sanitizer issue
* Take 2
* Fix false positive on nested computed variables
* Remove support for Xcode 10.x
* Fix rule description
* Enable opt-in rule in configuration file
* Extract code into `SyntaxRule` protocol
* nit: make property private
* Missing docs
* Fix MasterRuleList.swift
* Update CHANGELOG
* Remove unused imports
* Use Example type
* Change rule kind to .idiomatic
* Update CHANGELOG
* Bump deployment target to macOS 10.12
* Simplify SyntaxRule.validate(file:visitor)
* Make TSan happy
* Use script/bootstrap in the README
2020-02-08 02:43:40 -08:00
John Buckley
efe8816315
ImplicitReturnConfiguration description now reports current config ( #3083 )
...
* ImplicitReturnConfiguration description now reports current config.
Previously only the default config was reported.
* Updating CHANGELOG.md
2020-02-08 01:55:58 -08:00
John Mueller
be44017675
Fix false positives when line ends with carriage return + line feed ( #3061 )
...
Fixes : #3060
2020-02-02 15:37:49 -08:00
Paul Taykalo
057bcb8921
Fixes #3066 Crash on missing ( #3067 )
2020-02-02 23:30:40 +02:00
Zev Eisenberg
fcf848608e
Add Inline test failure messages ( #3040 )
...
* Add Example wrapper in order to display test failures inline when running in Xcode.
* Stop using Swift 5.1-only features so we can compile on Xcode 10.2.
* Wrap strings in Example.
* Add Changelog entry.
* Wrap all examples in Example struct.
* Better and more complete capturing of line numbers.
* Fix broken test.
* Better test traceability.
* Address or disable linting warnings.
* Add documentation comments.
* Disable linter for a few cases.
* Limit mutability and add copy-and-mutate utility functions.
* Limit scope of mutability.
2020-02-02 10:35:37 +02:00
Paul Taykalo
25f07af7bc
Merge pull request #3031 from PetteriHuusko/dev
...
Fix discarded_notification_center_observer false positive on arrays
2020-01-30 09:19:26 +02:00
Petteri Huusko
3bd269fdd2
Fix discarded_notification_center_observer false positive when capturing observers into an array
2020-01-29 08:32:40 +02:00
Paul Taykalo
8ac124a494
A bit faster Explicit Self rule ( #3048 )
2020-01-17 13:57:54 -08:00
Steven
325af44c36
Add deinitializer to type_contents_order ( #3042 )
...
Add `deinitializer` type content to `type_contents_order` rule instead of grouping it with initializers. This allows the common use case of putting the deinitializer at the end of the class.
2020-01-16 16:49:37 -08:00
JP Simard
0b1140d874
Fix typo in examples for isEmpty
2020-01-16 16:29:11 -08:00
JP Simard
fe5baca7cd
Migrate to use SourceKitten's new ByteCount/ByteRange types ( #3037 )
...
New APIs were introduced in SourceKitten to allow for a more typesafe distinction between integers meaning NSString-based distances and byte-based distances.
* https://github.com/jpsim/SourceKitten/pull/639
* https://github.com/jpsim/SourceKitten/pull/642
This PR migrates SwiftLint's use of those APIs.
2020-01-16 15:18:37 -08:00
iliaskarim
4a56bf56c5
Update RedundantVoidReturnRule.swift ( #3039 )
...
Single argument function types require parentheses
2020-01-14 12:58:32 -08:00
JP Simard
399f5b7df6
Fix docstring formatting issues using DrString ( #3032 )
...
Using command:
$ drstring check -i 'Source/**/*.swift' --first-letter lowercase --vertical-align
2020-01-12 11:19:33 -08:00
JP Simard
5b5314ee70
Fix documentation in Version.swift
2020-01-08 12:14:42 -08:00
JP Simard
76d44cff39
release 0.38.2
2020-01-08 10:35:08 -08:00
JP Simard
37167a8a35
Add documentation comments to all public declarations ( #3027 )
2020-01-08 09:47:10 -08:00
JP Simard
d2643db495
[Docs] Build docs using jazzy ( #3016 )
...
* Add `.jazzy.yaml` configuration file
* Update `swiftlint generate-docs` to write docs to a directory rather than a single file
* Add jazzy to the Gemfile
* Run `bundle update`
* Add CI job to run jazzy automatically and publish to GitHub Pages

2020-01-07 20:31:29 -08:00
JP Simard
4388c9f899
Fix regressions in UnusedImportRule ( #3025 )
2020-01-07 12:43:47 -08:00
JP Simard
760383508e
Improve tuple handling in optional_enum_case_matching rule ( #3024 )
...
Catch previously missed violations in the `optional_enum_case_matching` rule when case expressions involved tuples. For example:
```swift
switch foo {
case (.bar↓?, .baz↓?): break
case (.bar↓?, _): break
case (_, .bar↓?): break
default: break
}
```
2020-01-07 09:36:08 -08:00
Frederick Pietschmann
601ea392c2
Merge pull request #2765 from fredpi/feature/indentation_width
...
Add new indentation_width rule
2020-01-06 10:47:09 +01:00
Frederick Pietschmann
3d0b568e2c
Fix bug with no-syntax-kind lines (e. g. "[")
2020-01-06 10:24:13 +01:00
Marcelo Fabri
4fd593ff39
Add more tests for OrphanedDocCommentRule ( #3017 )
2020-01-05 23:34:03 -08:00
Frederick Pietschmann
d283904b0a
Fix rebase issues
2020-01-06 08:30:49 +01:00
Frederick Pietschmann
98e870e726
Fix modifier order
2020-01-06 08:30:49 +01:00
Frederick Pietschmann
eb92e0b3a1
Fix wrong spacesEquivalent implementation; simplify validate method
2020-01-06 08:30:49 +01:00
Frederick Pietschmann
bc6396d516
Keep linting even when seeing mixed indentation
2020-01-06 08:30:49 +01:00
Frederick Pietschmann
0bed014cba
Add extensive tests for indentation_rule; fix duplicate warning avoidance mechanism
2020-01-06 08:30:49 +01:00
Frederick Pietschmann
35cd789ba1
Restructure indentation_width tests
2020-01-06 08:30:49 +01:00
Frederick Pietschmann
1fbb39dd50
Introduce mechanism to avoid duplicate indentation_width warnings for one single issue
2020-01-06 08:30:49 +01:00
Frederick Pietschmann
3a8ad943c3
Add configuration option whether to consider comment lines for indentation_width rule
2020-01-06 08:30:49 +01:00
Frederick Pietschmann
8c245c7581
Add new indentation_width rule
2020-01-06 08:30:49 +01:00
Marcelo Fabri
c2bdb589df
Add orphaned_doc_comment rule ( #3014 )
...
* Add orphaned_doc_comment rule
Fixes #2989
* Don’t trigger on lines with only “/“
2020-01-05 20:45:06 -08:00
Pyry Jahkola
805b9ab3ba
Add capture_group option to custom_rules
...
This option allows for more fine-grained placement of the location
marker for code violating a custom rule, e.g.:
```swift
print("Hello world.")
^~~~~
```
for this `.swiftlint.yml`:
```yaml
custom_rules:
world_preceded_by_hello:
name: "World Preceded by Hello"
included: ".+\\.swift"
message: "The word World predeced by the word hello should be capitalised."
severity: warning
regex: "(?i:hello)\\s+(world)"
match_kinds: [string]
capture_group: 1
```
2020-01-05 15:24:11 -08:00
Sven Münnich
72e2063531
Include functions and getters in rule implicit_return
2020-01-05 15:04:35 -08:00
JP Simard
cb325512fb
Run make sourcery
2020-01-03 19:56:18 -08:00
JP Simard
6f6c9fed8c
release 0.38.1
2020-01-03 19:44:27 -08:00
JP Simard
40ade98710
Update SourceKitten to 0.28.0 ( #3011 )
2020-01-03 16:47:18 -08:00
timcmiller
4112816077
Added 'file_name_no_space' rule ( #3008 )
...
* Added 'file_name_no_space' rule
* Removed unused var, and added to changelog
* Remove custom suffix from 'file-name-no-space' rule
* Fixed LinuxMain
* Switched to use a CharacterSet over Regex
2020-01-03 15:45:30 -08:00
timcmiller
29bff89a29
File name console description ( #3010 )
...
* Added parameters to FileNameConfiguration.consoleDescription
* Added bugfix to CHANGELOG
* Fix indentation
Co-authored-by: JP Simard <jp@jpsim.com >
2020-01-03 14:00:17 -08:00
Marcelo Fabri
093370c2b3
Add opt-in prefer_self_type_over_type_of_self rule ( #3006 )
...
Fixes #3003
2020-01-03 12:33:04 -08:00