96a4e6cc2f
remove init() from Rule.
2015-11-29 21:43:53 -08:00
63216c56cb
Refactoring LegacyConstructorRule
2015-11-29 21:40:08 -02:00
1fec14180f
Adding LegacyConstructorRule
2015-11-29 01:46:06 -02:00
1bc53b50fe
Fixing typo
2015-11-28 01:12:14 -02:00
815f19632b
Variable name violation should be ignored if the entire name is in capitals
2015-11-28 00:16:56 -02:00
9be89a686e
fix inappropriate uses of flatMap where we should be using map
2015-11-27 17:32:21 -08:00
9276ec178d
fix statement position rule false positives. fixes #237 .
2015-11-26 11:23:25 -08:00
717b36ca0c
print terminating newline from queuedPrint
2015-11-20 23:40:12 -08:00
80a1068a58
minor syntax fix in ControlStatementRule
2015-11-20 21:56:42 -08:00
68ec42d3cb
minor refactor of NestingRule
2015-11-20 21:46:45 -08:00
e0df8df817
Merge pull request #216 from realm/jp-queue-logs
...
Fix an issue where logs would be printed asynchronously
2015-11-18 08:21:07 -08:00
1201a9e38c
Release 0.4.0
2015-11-17 19:50:49 -08:00
173c0058ca
Merge pull request #217 from crimsonwoods/fix_issue_213_wrong_line_number_is_detected
...
Fix an issue: wrong line number and/or index is reported
2015-11-17 19:44:57 -08:00
4806e31f23
Rename lineAndCharacterForByteOffset to lineAndCharacterForCharacterOffset.
...
According to a change 247f02eff4
2015-11-18 12:05:08 +09:00
306a80a00a
Fix an issue where logs would be printed asynchronously. Fixes #200 .
2015-11-17 18:15:13 -08:00
247f02eff4
Issue fix #213 : offset parameter should be used as a character-offset, not a byte-offset.
2015-11-18 10:42:30 +09:00
73896ee04c
add force try rule
2015-11-17 16:51:37 -08:00
ecb2a8bee5
refactor variable name rules
2015-11-17 16:13:06 -08:00
c31f33b49e
check isEmpty rather than test count against zero
2015-11-17 13:17:24 -08:00
d269bde1fa
allow trailing semicolons in comments
2015-11-17 11:41:02 -08:00
0a2b9e8a54
add trailing semicolon rule
2015-11-17 10:46:26 -08:00
a45043bbaf
use verifyRule to test Trailing Newline rule
2015-11-17 10:44:30 -08:00
1048fb05e7
clean up Configuration.swift
2015-11-17 10:40:54 -08:00
66a8b4441d
minor improvements to the variable name family of rules
2015-11-17 10:30:53 -08:00
989127cbe0
[StyleViolation] use RuleDescription's description when reason is nil
...
Many cases just used a static string that was nearly identical to the rule
description as the `reason` parameter when initializing a StyleViolation.
2015-11-17 10:25:57 -08:00
76b30ee19b
make all rule descriptions follow a consistent format
2015-11-17 10:18:29 -08:00
4a5ac44897
add SyntaxKind.commentAndStringKinds()
2015-11-17 10:11:04 -08:00
8a30cb2e3d
organize Xcode project
...
make Extensions, Models & Protocols groups under SourceKittenFramework
2015-11-15 15:07:25 -08:00
2300904500
update dependencies & make minor improvements to some rules
2015-11-15 14:53:41 -08:00
6f643c4358
minor refactoring improvements
2015-11-15 14:28:33 -08:00
528af41764
fix colon rule issue #135
2015-11-15 16:11:56 +01:00
4af4909ad2
Filter out rules which don't exist rather than failing the configuration.
2015-11-12 20:55:07 -08:00
631bd965b4
Fix brace spelling error
2015-11-11 15:47:02 -08:00
8f1788ad5f
some refactor after code review
2015-11-11 21:20:51 +01:00
b18463154c
improve ControlStatementRule especially when several parentheses exists in condition and several bad cases appears
2015-11-11 16:36:47 +01:00
a73341e38d
[Configuration] fix whitespace
2015-11-10 14:10:43 -08:00
a96eb3a6ab
[Configuration] fix whitespace
2015-11-10 14:02:06 -08:00
2131613166
no longer trigger a nesting violation for enums one level deep. fixes #190
2015-11-10 08:58:53 -08:00
d36bf678a9
cut out some duplication in parameterRulesFromYAML
2015-11-07 11:14:40 -08:00
91aa913c62
add 2 new parameter rules to check min and max length of variable names and remove length check in VariableNameRule
2015-11-07 03:03:08 +01:00
a70e4bd759
change VariableNameRule to allow capital static let
...
There is at least one semi-common case where capitalized names should
probably be allowed: in OptionSetType classes, the standard pattern is
to use `static let = Foo` to declare each option for the type.
Apple docs demostrating this:
https://developer.apple.com/library/prerelease/ios/documentation/Swift/Reference/Swift_OptionSetType_Protocol/index.html
One downside of this implementation is that it would *also* pass a
capitalized "static var Foo", which is probably not desirable. It's not
clear to me how feasible addressing this is: it seems like SourceKitten
might need to be updated to support this better? Using `static var` at
all is code smell, though, so hopefully this isn't a huge deal. Perhaps
there should even be a rule identifying `static var` and considering it
a violation?
2015-11-05 11:35:07 -05:00
8e12dbd81d
move ASTRule function implementations into a protocol extension
2015-11-04 15:39:29 -08:00
0335f155ab
Perform major refactor of rule description, identifiers and examples
...
Fixes #183 .
2015-11-04 12:24:33 -08:00
5cb80cfd22
All rules now print their identifiers in reports. Fixes #180 .
2015-11-04 10:30:36 -08:00
ae595d67ed
Release 0.3.0
2015-11-03 13:13:51 -08:00
3e53537882
Merge pull request #172 from S2dentik/statementPosition
...
Add Statement Position rule
2015-11-03 12:58:00 -08:00
233429365e
Merge pull request #179 from realm/jp-update-dependencies
...
update dependencies & lint parameter variables
2015-11-03 12:52:50 -08:00
c6800e1ace
update dependencies & lint parameter variables
2015-11-03 12:31:37 -08:00
aa1fc70c9c
Add StatementPosition rule
2015-11-03 22:27:26 +02:00
5af582ca53
Add Comma rule
2015-11-03 22:05:31 +02:00
JP Simard
Marcelo Fabri
Keith Smiley
crimsonwoods
Mickael Morier
David Paschich
Will Fleming
Alex Culeva